Custom Collections are not Showing in Emulationstation for Windows

PittStone

Add Games specified Collection like "Zelda" not work if i use emulationstation portable. Everytime i start emulationstation, the collection "Zelda" is not Showing. After i go to the Options and enable collection from Theme and select "Zelda" the Collection is showing normal. The folder "collections" with "custom-zelda".cfg exists. After close and restart emulationstation, the "Zelda" in the Menue is gone. If i make a new collection from Theme and select "Zelda" again, my collection is showing again. All Collections are only showing in the time i have added it and not closing emulationstation complete. Whats wrong?

mitu

@pittstone Does the portable version saves its configuration somewhere ? Because this is likely the problem - ES's configuration file (es_settings.cfg) is not saved. Do other configuration you do in Emulationstation persist between restarting the program ?

PittStone

@mitu said in Custom Collections are not Showing in Emulationstation for Windows:

Does the portable version saves its configuration somewhere ? Because this is likely the problem - ES's configuration file (es_settings.cfg) is not saved. Do other configuration you do in Emulationstation persist between restarting the program ?

Yes, other configs are persist. "Favorites" are the one persists after restarting. Only Collections not. The "es_sttings.cfg" delete :

to

But if i make the "es_settings.cfg" read-only with the right entry vor collections, emulationstation ignore it and not showing any collections.

mitu

What version of ES are you using ? Try updating to the latest version https://retropie.org.uk/forum/topic/9094/updated-emulationstation-for-windows

PittStone

The Problem is with the newest Build. Problems with the PS2 gamelist are in this build, too. Some games showing with informations and videos, some not. Only in Ps2 is this issue.

mitu

@pittstone Hm, did some tests and there might be a problem with the custom collections path detection. Not sure if it's specific to Windows though.
So I created a custom-megaman.cfg in the collections folder, ES logs that it cannot find the file:

lvl2: 	Found non-collection config file in collections folder: ustom-megaman.cfg

The problem looks like it comes from computing the filename to be checked. Filename is passed as C:/Users/mitu/Desktop/es-toolkit-1.2/emulationstation/.emulationstation/collections/custom-megaman.cfg, but the collections path is detected as C:/Users/mitu/Desktop/es-toolkit-1.2/emulationstation//.emulationstation/collections/. If I replace

std::vector<std::string> CollectionSystemManager::getCollectionsFromConfigFolder()
{
	std::vector<std::string> systems;
	std::string configPath = getCollectionsFolder();

with

std::vector<std::string> CollectionSystemManager::getCollectionsFromConfigFolder()
{
	std::vector<std::string> systems;
	std::string configPath = Utils::FileSystem::getGenericPath(getCollectionsFolder());

then the error disappears and the custom collection is shown.
One thing I tried was to add a custom collection through the interface, but after finishing the collection editing (added one ROM), there was no config file created in the collections subfolder.
@pjft would you mind taking a look ? I tested with the latest master brach and the fix seems identical with your latest commit that was merged.

PittStone

Where do i replace it?

mitu

@pittstone The replacement is in the source code, but for now could you check that if you start emulationstationwith the -log parameter, you get the same kind of error like me ? The error should be in the .emulationstation/es_log.txt file, same place as the es_settings.cfg file.

PittStone

yes its the same error:
lvl2: Found non-collection config file in collections folder: ustom-streetfighter.cfg

Tomaz

I did some tests, and I think one of the patches done in the last couple of days should have fixed this.
At least I can't reproduce this bug.

PittStone

Its definitly not working for me with the latest build. The Custom Collection shows Only if i make a new collection from theme. After closing Emulationstation for windows and start it again, the collections gone. I need go in Menue, make a new custom collection with the same Name and the Collections with my Games i made earlyer are showing again.
On Closing and Starting next Time its gone again.

PittStone

@tomaz Have you used the portable.bat for emulationstation?

PittStone

@mitu Have you the Working .exe for me to test it?

Tomaz

@pittstone No, I use my own setup.

moonston333

hi all is this issue resolved as ive got the same problem with emulationstation windows the custom collections are not there when i shut down and reload

i have to go to setting and add them everytime