EmulationStation Grid View v1 ready for wider testing

lilbud · 26 May 2018, 19:10

@a12c4 wanna send a PR to my branch?

A12C4 · 26 May 2018, 19:52

@lilbud It's not complete, I half added the "custom collection", and I was too lazy to change all the system specific theme.xml so the color of the selector is based on the system color :)

You can find my changes here :

cloudlink · 26 May 2018, 20:49

I just installed emulationstation-dev from source. I also installed the new Carbon theme. In ES, when I sect the Carbon theme and Grid gamelist view style, then click Back, it just freezes and I have to reboot.
Am I missing a step?

A12C4 · 27 May 2018, 17:08

Hello @cloudlink , I'm sad to hear that you have troubles enabling the grid view.

What is your system running ES ? Can you detail a bit more what you are doing step by step (are you changing both the game list view style and the theme at the same time for example ?)

I am unable to completly reproduce your problem. When I switch theme and game list view style to the grid view on my pi 3B, it freeze for about 4~5 seconds but after that it work perfectly.

cloudlink · 27 May 2018, 17:26

@a12c4
Thanks for the reply.
Sorry, I should have included more detail.
I'm running the latest version of Retropie, upgraded from the latest official image, on a Raspberry Pi 3 B+.
The only custom changes I've made that I can think of that might interfere are a few emulator entries I manually added to es_systems.cfg. Those are unthemed right now as I'm using the new version of Carbon with no customizations.
Could that cause an issue?
I've tried changing to the Carbon theme first then enabling the grid view. It changes to the Carbon theme just fine, but freezes indefinitely when changing to grid view.

jdrassa · 28 May 2018, 16:38

@A12C4 I updated my main Pi which has a lot more games on it and saw the same hanging. I did some testing and traced the delay back to here. I believe at one point you explored having the ImageGridData holding the image path vs. a TextureResource. At a minimum we probably need a way to defer the creation of the TextureResource until they are first needed.

A12C4 · 29 May 2018, 01:09

@jdrassa Define "first needed".

Yes I explored instantiating the TextureResource while navigating in the grid and it gave really poor results, with huge fps drops.

Another solution could be to instantiate them only for the currently selected system, but that way you may experience big loading time if you switch to a system with a lot of games for the first time.

This 9000+ games collection ain't gonna get loaded by itself.

jdrassa · 2 Jun 2018, 16:01

@a12c4 said in EmulationStation Grid View v1 ready for wider testing:

@jdrassa Define "first needed".
Yes I explored instantiating the TextureResource while navigating in the grid and it gave really poor results, with huge fps drops.

Not entirely sure. My first thought was to load only the textures needed to fill the grid tiles and then load more as they are needed, maybe with some sort of predictive loading ahead based on scroll direction/speed. I assume that is along the lines of what you already tried.

After thinking about it further, it may be that the check for for file existence that happens before loading the texture may be contributing to the delay. I know that the auto-discovery of images was disabled on the stable branch due to the delay checking for the image existence was causing.

A12C4 · 6 Feb 2018, 17:13

@jdrassa Sorry for the late answer, I had some troubles with my computer that I needed to fix first.

So, after taking a look with callgrind, it look like the check for file existence have nearly no cost compared on the TextureResource instantiation. (btw if you have a better method than using callgrind to profile C++ code, I'm interested, as it's far from perfect and I would like to focus on the grid optimization along with debug in the next weeks).

I think we have 2 bottlenecks here : the TextureRessource instantiation and the TextureData loading.

The 2nd one can be easily delayed by loading only texturedata for the selected system instead of all system at the same time. This is actually something that I had already made in the first version of the "dynamic image loader" feature but didn't reimplemented when I restarted the final version from scratch.

I think this should help a lot here : Since the modified carbon theme that I shared display 15 grid tiles per system, this mean ES will load up to 15 texture per system (ofc it will load only 2 if you have only 2 games for a system), so if you have let's say a 30 system game collection, ES will load up to 15*30=450 texture at the same time, thus hanging a little bit ... With that modification, ES will only load the texture for the selected system, so if you change system using left/right shoulder button, it will take a little more time to load, but it should completely solve our problem with big game collections.

ruckage · 2 Jun 2018, 20:54

@jdrassa

Hi, is there an up to date version for windows that matches the raspberry pi as the version currently on your continuous build doesn't seem to be working correctly, setting the grid to <scrollDirection>horizontal</scrollDirection> results in no grid being displayed and if you try to activate grid through the menu or change the theme ES crashes.

Thanks in advance for your help.

A12C4 · 6 Feb 2018, 23:41

@ruckage Hi, I'm aware of this 2 issues and working on a fix for both of them. This is taking a bit longer than expected, as I said in the comment right above yours. Once both fixes are released, jrassa should come with a new version anytime soon. Thanks for your patience.

ruckage · 2 Jun 2018, 22:58

@a12c4
No problem, thanks for the reply and for your continued work. I've been working on some mock-ups for the grid that I'll be adding to my themes you can see them here if you're interested.

Thanks again.

lilbud · 4 Jun 2018, 22:22

Hmmm....

A12C4 · 4 Jun 2018, 23:37

@lilbud Can you give some context to this image ? Are you reporting a bug or do you just want to show your last creation ?

lilbud · 5 Jun 2018, 00:06

@a12c4 yes

Showing off a mockup I've been working on

EctoOne · 5 Jun 2018, 00:11

@lilbud do you even need grid view for that? I mean it's just a single image above an frame with some Metadata. You can do that in detailed view.

lilbud · 5 Jun 2018, 00:22

@ectoone Like I said, just the result of me screwing around in photoshop. I just wanted to see what different views looked like.

EctoOne · 5 Jun 2018, 00:46

@lilbud Yeah sure, asking for feedback is fine but I don't understand why you posted it here with no context.
I thought that you wanted to use grid view to show only one image. Which makes no sense to me, because it can be done without grid view. Also I find it has even less accessibility then my suggestion to have an opinion to fix the selector on one side (I posted an image of that in one of the other threads).
Also it would be OK if you had posted more images of the different views, but then I would still ask myself: why is that here?

lilbud · 5 Jun 2018, 00:48

@ectoone I guess I thought it belonged here on the grid view discussion. Disregard it

A12C4 · 6 Jun 2018, 22:36

@ruckage @lilbud @EctoOne I fixed a bug which caused the padding of the grid tile to be 2 times smaller than it should be. I wanted you to know it will be in next release in case you already started to build your theme.

The 2 other fixes (for horizontal grid position bug and enabling the grid crash) should also come soon.