[SOLVED] lr-px68k not build anymore

[hhromic]

@DarishZone I'm glad you got it working for now.
Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

[DarishZone]

@hhromic said in lr-px68k not build anymore:

@DarishZone I'm glad you got it working for now.
Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

Thanks man, i already reverted change now, will that make a difference? Im afraid to forget if i do later

[hhromic]

@mitu said in lr-px68k not build anymore:

@hhromic said in lr-px68k not build anymore:

I also was wondering the same thing but was confirmed to me that it's not public. You can get access to it in the Libretro Discord dev channel.

https://travis-ci.org/libretro/px68k-libretro - it looks like it's failing proper. Either removing the -Wl,--no-undefined or compiling with $(CXX) works.

ah good to know how to access their CI! In here a dev told me I needed Discord access. Thanks for the tip.

Regarding the candidate fixes, I chose to remove -Wl,--no-undefined (I was setting it in the scriptmodule) together with properly setting LDFLAGS and not rely on re-setting LD. They have been pushing these updates recently to many cores, i.e. standardising to set LD = $(CC) so there are high chances it can get reverted again. So that would be my advice.

Their makefile management is def not ideal ...

[hhromic]

@DarishZone said in lr-px68k not build anymore:

@hhromic said in lr-px68k not build anymore:

@DarishZone I'm glad you got it working for now.
Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

Thanks man, i already reverted change now, will that make a difference? Im afraid to forget if i do later

The only potential problem if you don't revert it will be when you later update the RetroPie-Setup script. You could get local change conflicts and you will have to resolve them manually, kind of nasty.

However after the fix is done, you don't really need to recompile the core again as the change doesn't touch the source code. So just revert it now and don't compile the core again until the fix is confirmed upstream.

[DarishZone]

@hhromic said in lr-px68k not build anymore:

@DarishZone said in lr-px68k not build anymore:

@hhromic said in lr-px68k not build anymore:

@DarishZone I'm glad you got it working for now.
Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

Thanks man, i already reverted change now, will that make a difference? Im afraid to forget if i do later

The only potential problem if you don't revert it will be when you later update the RetroPie-Setup script. You could get local change conflicts and you will have to resolve them manually, kind of nasty.

However after the fix is done, you don't really need to recompile the core again as the change doesn't touch the source code. So just revert it now and don't compile the core again until the fix is confirmed upstream.

Perfect, thanks man!

[hhromic]

@mitu the scummvm core is failing to build in Windows after the commit that made similar changes to this core (px6k). Again with linking problems. The issue is being investigated in upstream so maybe it is best to wait a bit for a conclusion of a proper fix for all platforms to that recent changeset.

I have the feeling that indeed properly setting LD to $(CXX) (as my initial guess) is the correct thing to do for mixed C/C++ projects, but we have to see how the Windows build gets fixed first. Will keep updated here too.

[mitu]

@hhromic Thank you for the heads up.
I'm not in a rush, since the build fails for Linux x86 for this core I suppose it's something that's been noted, but the win-build-additions that you mention could be a bigger fish to fry first.
Do you have an issue reference I can look-up for the investigation ?

[hhromic]

@mitu sometimes they don't notice build fails because the buildbot just keeps the latest working builds and report to a big stream of notifications. If maintainers aren't paying attention, these fails go unnoticed. The scummvm core wasn't building for a while for example until we noticed here.

For lr-scummvm, the situation can be followed since this comment in this issue: https://github.com/libretro/scummvm/issues/123#issuecomment-455203092

I'm pretty sure it is not a big issue TBH, just a mismatch in Makeifles due to the big mess libretro has with their handling across cores. The recent update seems to be just a copy-paste from another C-only libretro core.

I would help debug if I had an actual Windows build system in place, but unfortunately I don't at the moment. I'm sure upstream developers with one will sort it out quickly.

[hhromic]

Update

I went to investigate a bit better a suitable solution and indeed the right thing to do is to set LD = $(CXX) for the mixed C/C++ codebase. I already sent a PR upstream now to address the build issue. I tested building on Linux and Windows and is building fine with that fix.

The same approach solves the Windows build for the lr-scummvm core so I also sent a PR upstream to correctly restore LD to $(CXX) and properly solve the issue for Linux and Windows alike.

Once the lr-px68k PR is merged upstream, it will build fine again in RetroPie without any modifications of the scriptmodule.

[hhromic]

Update

So the upstream PR was accepted quite fast :) The build of lr-px68k is working fine now (just tested).

@DarishZone if you reverted the temporary fix to the RetroPie scriptmodule, you may try to recompile now and should work fine. If you are happy, you should mark the topic with [SOLVED] :)

Good Luck!

[DarishZone]

@hhromic said in lr-px68k not build anymore:

Update

So the upstream PR was accepted quite fast :) The build of lr-px68k is working fine now (just tested).

@DarishZone if you reverted the temporary fix to the RetroPie scriptmodule, you may try to recompile now and should work fine. If you are happy, you should mark the topic with [SOLVED] :)

Good Luck!

More than happy, thanks for all the help u provide to the community (and mitu of course)