Could not successfully build lr-caprice32 - Amstrad CPC emu

[Danno]

Retropie installation with a freshly-installed Linux Mint 19.1 computer is failing with the error in the subject line. I've tried for several days now, to try and rule out a temporary issue with the lr-caprice32 GIT server, but the error continues. Most of the preceding steps in the installation script are successful, but no menu shortcut for RPIE is created.

A few months ago, I ran the installation on a Linux Mint 18.3 computer without any issue. I'll attach the entire log file if I can determine how to do that in this forum, but here are some of the lines preceding the failure:

libretro/retro_strings.c:72:7: warning: implicit declaration of function ‘strncasecmp’; did you mean ‘strncmp’? [-Wimplicit-function-declaration]
   if(!strncasecmp(str, start, strlen(start)))
       ^~~~~~~~~~~
       strncmp
libretro/retro_strings.c: In function ‘strendswith’:
libretro/retro_strings.c:82:7: warning: implicit declaration of function ‘strcasecmp’; did you mean ‘strncmp’? [-Wimplicit-function-declaration]
   if(!strcasecmp((char*)&str[strlen(str)-strlen(end)], end))
       ^~~~~~~~~~
       strncmp
cc -c -o libretro/retro_files.o libretro/retro_files.c -O2 -march=native -pipe -std=c99 -O3 -DLOG_PERFORMANCE -DGIT_VERSION=\"" 0bbf84a"\" -fPIC -D__LIBRETRO__  -DINLINE="inline" -DHAVE_CONFIG_H -Wall  -I. -I./cap32 -I./cap32/libcpccat -I./libretro -I./libretro/nukleargui -I./libretro/nukleargui/nuklear -I./libretro/nukleargui/retro 
libretro/retro_files.c: In function ‘file_exists’:
libretro/retro_files.c:30:59: error: ‘S_IFDIR’ undeclared (first use in this function); did you mean ‘S_ISDIR’?
      (buf.st_mode & (S_IRUSR|S_IWUSR)) && !(buf.st_mode & S_IFDIR))
                                                           ^~~~~~~
                                                           S_ISDIR
libretro/retro_files.c:30:59: note: each undeclared identifier is reported only once for each function it appears in
Makefile:328: recipe for target 'libretro/retro_files.o' failed
make: *** [libretro/retro_files.o] Error 1
make: *** Waiting for unfinished jobs....
~/RetroPie-Setup
Could not successfully build lr-caprice32 - Amstrad CPC emu - Caprice32 port for libretro (/home/dan/RetroPie-Setup/tmp/build/lr-caprice32/cap32_libretro.so not found).
~/RetroPie-Setup/tmp/build/lr-fbalpha ~/RetroPie-Setup

[mitu]

The problem seems to be upstream, there have been some recent commit recently that added this error - there's nothing wrong with your installation.

[Danno]

That's a little comforting to hear. So, am I stuck waiting for a fix to be committed upstream before I can try again? I don't have any games on the Amstrad platform, but I can't seem to get the RPIE shortcut to be created with the error occurring.

[mitu]

@Danno I don't think this has anything to do with it. The desktop shortcut is added by the Emulationstation package installation - did you get any errors when installing that package ?

[Danno]

@mitu Well, the only error listed explicitly at the end of the script execution was the one involving Amstrad. I scanned through the entire log, searching on "EmulationStation", but don't see anything concerning:

Installing dependencies for 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
Installing dependencies for 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
~/RetroPie-Setup/tmp/build/emulationstation ~/RetroPie-Setup
Getting sources for 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
Getting sources for 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
git clone --recursive --depth 1 --branch stable "https://github.com/RetroPie/EmulationStation" "/home/dan/RetroPie-Setup/tmp/build/emulationstation"
git clone --recursive --depth 1 --branch stable "https://github.com/RetroPie/EmulationStation" "/home/dan/RetroPie-Setup/tmp/build/emulationstation"
Cloning into '/home/dan/RetroPie-Setup/tmp/build/emulationstation'...
Cloning into '/home/dan/RetroPie-Setup/tmp/build/emulationstation/external/pugixml'...
~/RetroPie-Setup/tmp/build/emulationstation ~/RetroPie-Setup
Building 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
Building 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
-- Build files have been written to: /home/dan/RetroPie-Setup/tmp/build/emulationstation
/home/dan/RetroPie-Setup/tmp/build/emulationstation/es-core/src/components/VideoVlcComponent.cpp: In member function ‘virtual void VideoVlcComponent::startVideo()’:
/home/dan/RetroPie-Setup/tmp/build/emulationstation/es-core/src/components/VideoVlcComponent.cpp:298:30: warning: ‘void libvlc_media_parse(libvlc_media_t*)’ is deprecated [-Wdeprecated-declarations]
                 from /home/dan/RetroPie-Setup/tmp/build/emulationstation/es-core/src/components/VideoVlcComponent.cpp:7:
Scanning dependencies of target emulationstation
[ 73%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/FileData.cpp.o
[ 73%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/FileSorts.cpp.o
[ 73%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/MameNameMap.cpp.o
[ 74%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/main.cpp.o
[ 75%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/MetaData.cpp.o
[ 76%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/PlatformId.cpp.o
[ 76%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/ScraperCmdLine.cpp.o
[ 77%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/SystemData.cpp.o
[ 78%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/VolumeControl.cpp.o
[ 78%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/Gamelist.cpp.o
[ 79%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/FileFilterIndex.cpp.o
[ 80%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/SystemScreenSaver.cpp.o
[ 80%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/CollectionSystemManager.cpp.o
[ 81%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/components/AsyncReqComponent.cpp.o
[ 82%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/components/RatingComponent.cpp.o
[ 82%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/components/ScraperSearchComponent.cpp.o
[ 83%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiFastSelect.cpp.o
[ 84%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiMetaDataEd.cpp.o
[ 84%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiGameScraper.cpp.o
[ 85%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiGamelistOptions.cpp.o
[ 86%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiScreensaverOptions.cpp.o
[ 86%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiGeneralScreensaverOptions.cpp.o
[ 87%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiVideoScreensaverOptions.cpp.o
[ 88%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiSlideshowScreensaverOptions.cpp.o
[ 88%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiMenu.cpp.o
[ 89%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiSettings.cpp.o
[ 90%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiScraperMulti.cpp.o
[ 90%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiScraperStart.cpp.o
[ 91%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiGamelistFilter.cpp.o
[ 92%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiCollectionSystemsOptions.cpp.o
[ 92%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/guis/GuiInfoPopup.cpp.o
[ 93%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/scrapers/Scraper.cpp.o
[ 94%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/scrapers/GamesDBScraper.cpp.o
[ 94%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/gamelist/BasicGameListView.cpp.o
[ 95%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/gamelist/DetailedGameListView.cpp.o
[ 96%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/gamelist/IGameListView.cpp.o
[ 96%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/gamelist/ISimpleGameListView.cpp.o
[ 97%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/gamelist/GridGameListView.cpp.o
[ 98%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/gamelist/VideoGameListView.cpp.o
[ 98%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/SystemView.cpp.o
[ 99%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/ViewController.cpp.o
[100%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/views/UIModeController.cpp.o
[100%] Linking CXX executable ../emulationstation
[100%] Built target emulationstation
~/RetroPie-Setup/tmp/build/emulationstation ~/RetroPie-Setup
Installing 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
Installing 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/CREDITS.md' -> '/opt/retropie/supplementary/emulationstation/CREDITS.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/CREDITS.md' -> '/opt/retropie/supplementary/emulationstation/CREDITS.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation' -> '/opt/retropie/supplementary/emulationstation/emulationstation'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation' -> '/opt/retropie/supplementary/emulationstation/emulationstation'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation' -> '/opt/retropie/supplementary/emulationstation/emulationstation'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation' -> '/opt/retropie/supplementary/emulationstation/emulationstation'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation.sh' -> '/opt/retropie/supplementary/emulationstation/emulationstation.sh'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation.sh' -> '/opt/retropie/supplementary/emulationstation/emulationstation.sh'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation.sh' -> '/opt/retropie/supplementary/emulationstation/emulationstation.sh'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/emulationstation.sh' -> '/opt/retropie/supplementary/emulationstation/emulationstation.sh'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/GAMELISTS.md' -> '/opt/retropie/supplementary/emulationstation/GAMELISTS.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/GAMELISTS.md' -> '/opt/retropie/supplementary/emulationstation/GAMELISTS.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/README.md' -> '/opt/retropie/supplementary/emulationstation/README.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/README.md' -> '/opt/retropie/supplementary/emulationstation/README.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/THEMES.md' -> '/opt/retropie/supplementary/emulationstation/THEMES.md'
'/home/dan/RetroPie-Setup/tmp/build/emulationstation/THEMES.md' -> '/opt/retropie/supplementary/emulationstation/THEMES.md'
/opt/retropie/supplementary/emulationstation ~/RetroPie-Setup
Configuring 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
Configuring 'emulationstation' : EmulationStation - Frontend used by RetroPie for launching emulators
Running action 'install_theme' for 'esthemes' : Install themes for Emulation Station
Installing dependencies for 'retropiemenu' : RetroPie configuration menu for EmulationStation
Installing 'retropiemenu' : RetroPie configuration menu for EmulationStation
Configuring 'retropiemenu' : RetroPie configuration menu for EmulationStation

My assumption was that the logic in the script which adds the "RPIE" entry in the menu didn't get a chance to run when the script aborted due to the Amstrad error. Is that not correct?

[mitu]

Emulationstation seems to have been installed without error, the desktop icon should have being installed - have you search for retropie in the list of applications ? You can run emulationstation from the terminal and see if it gets started.

[Danno]

EmulationStation did successfully launch from the command line. As a mini test, I copied over one (Nintendo 64) ROM and the game did launch successfully and gameplay seemed solid. However, when I went to re-scrape game information (from TheGamesDB), it failed with "No Games Found" each time. I don't want to veer off onto a different issue from the primary one I posted, but I never encountered a problem with the scrape function on my other (Mint 18) setup.

Is this unrelated to the setup script failure, do you think? Also, is there a non-manual way to add the normal entry in the Mint menu (category of "Games" was added, with an entry for "RPIE" with the proper icon)?

[Danno]

Mea Culpa on the missing menu entry - when I went to manually add an entry, I saw that the entry was already showing in the Menu editor. I then remembered that I had to reboot (log off / on again might have sufficed) in order for the new menu entry to appear for rpie.

But, I added a few more games (MAME ROMs this time), and I still can't get any of them to scrape successfully. So, my questions now are these:

1. Should I open a new issue for the Caprice32 bug at it's GitHub site (https://github.com/libretro/libretro-cap32)?
2. Should I start a new forum thread for the scraping issue? I haven't had a chance to search much yet on that one, but am wondering in case I don't find an existing issue reported already.

[Danno]

Sheesh...another Mea Culpa due from me. I see the somewhat-recent post you made for the scraping problem: https://retropie.org.uk/forum/topic/20613/emulationstation-internal-scraper-problems/2

I include it here in case it helps someone else landing in this thread.

[BuZz]

please try updating retropie-setup and rebuilding lr-caprice32 again.

[Danno]

Pulled latest Retropie-Setup from git, reran, and this time there were no errors showing afterward (i.e. the main menu for the script was showing as expected). I looked through the log file, especially the section involving lr-caprice32, and didn't see any fatal errors (just some compile warnings).

Thanks for the follow up.