ScummVM 2.1.0

[GeekOB]

Thanks @mitu, I stand corrected.
Are there any news on the decision of which branch(es) will be used for ScummVM @hhromic ?

[hhromic]

@GeekOB I'm working on it, please be patient and soon I will post updates :)

[hhromic]

@GeekOB can you please test the following PR on your side?
https://github.com/RetroPie/RetroPie-Setup/pull/2889

It applies the changes requested by Eugene from ScummVM, namely use the stable v2.1.0 tag for checking out the code and disabling the experimental engines.

Thanks!

[GeekOB]

@hhromic happy to, what do I need to do to test this?

[hhromic]

@GeekOB a simple way is to do this:

1. Go to your RetroPie-Setup directory. Make sure you don't have any pending changes or modifications.

2. Checkout a new branch for testing: git checkout -b scummvm-test

3. Apply the PR as a patch:

   git am < <(curl -sSL https://patch-diff.githubusercontent.com/raw/RetroPie/RetroPie-Setup/pull/2889.patch)
   

4. Re-build and install ScummVM from source as normal.

5. Test ScummVM.

6. To revert the patch, checkout back to master: git checkout master and delete the testing branch: git branch -D scummvm-test.

[GeekOB]

I can confirm that version 2.1.0 is working properly after building from the testing branch.
Let me know if I can help with any additional testing @hhromic
Thanks!

[hhromic]

@GeekOB thanks for confirming!
I'll green-light the PR then to be merged soon.

[GeekOB]

Thanks @hhromic !!
What branch will the build from source option use?
Are you planning to introduce any "bleeding edge" variants in the experimental packages section?

[GeekOB]

I have updated to 2.1.0 using the latest binary. Thanks @hhromic and @BuZz !
I also went ahead and tested the "Update from source" option and received the following error messages:

Log started at: Thu  7 Nov 08:41:35 EST 2019

RetroPie-Setup version: 4.5.2 (5941e53d)
System: Raspbian GNU/Linux 9.11 (stretch) - Linux retropie 4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l GNU/Linux

= = = = = = = = = = = = = = = = = = = = =
Installing dependencies for 'scummvm' : ScummVM
= = = = = = = = = = = = = = = = = = = = =

/home/pi/RetroPie-Setup/tmp/build/scummvm /home/pi

= = = = = = = = = = = = = = = = = = = = =
Getting sources for 'scummvm' : ScummVM
= = = = = = = = = = = = = = = = = = = = =

git clone --recursive --depth 1 --branch v2.1.0 "https://github.com/scummvm/scummvm.git" "/home/pi/RetroPie-Setup/tmp/build/scummvm"
Cloning into '/home/pi/RetroPie-Setup/tmp/build/scummvm'...
error: RPC failed; curl 56 GnuTLS recv error (-9): A TLS packet with unexpected length was received.
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
fatal: Cannot change to '/home/pi/RetroPie-Setup/tmp/build/scummvm': No such file or directory
fatal: Cannot change to '/home/pi/RetroPie-Setup/tmp/build/scummvm': No such file or directory
HEAD is now in branch '' at commit ''
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- a/configure
|+++ b/configure
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
/home/pi
Error running 'git clone --recursive --depth 1 --branch v2.1.0 https://github.com/scummvm/scummvm.git /home/pi/RetroPie-Setup/tmp/build/scummvm' - returned 128
scummvm patch /home/pi/RetroPie-Setup/scriptmodules/emulators/scummvm/01_rpi_enable_scalers.diff failed to apply

Log ended at: Thu  7 Nov 08:42:10 EST 2019
Total running time: 0 hours, 0 mins, 35 secs

I wanted to give you a heads up so you can fix it when you have a chance.
Thank you once again :)

[mitu]

@GeekOB said in ScummVM 2.1.0:

error: RPC failed; curl 56 GnuTLS recv error (-9): A TLS packet with unexpected length was received.

Looks like a connection problem on your end. Have you retried to do the source installation ?
Since the binaries are now following a stable branch and they've been recently build, you'll be installing the same version as the binary update.

[GeekOB]

Understood @mitu , thanks. I'll retest the source and let you know.
The version makes sense as it's very recent, not sure if the ScummVM team will be making major changes to that branch, we'll see.

[hhromic]

Hi @GeekOB ,

As @mitu mentions is highly likely a connection problem on your end.

Besides, we are now using the v2.1.0tag, not branch. Which means that is never going to change until they release a new stable version or hotfix. You always will get the same result (the current binary) no matter when you build from source.

The only difference that building from source can make is that when building from source you are using compiler optimisation for your particular RPI device. This optimisation may be very minimal anyway.

[liquidpolicenaut]

Sorry for the extreme late reply! In reference to my original issues, I got the controller issue fixed (Yay!) but my other problem remains in that I cant get Beavis and Butthead to load from the start. From my last post, I discovered that the game does in fact run properly IF I load a save file from it, however, I get booted back to the main EmulationStation screen if I try to start a game from the beginning. Here are the contents of my runcommand file:

Parameters:
Executing: bash /home/pi/RetroPie/roms/scummvm/+Start\ ScummVM.sh "bbvs-win"
Using joystick: SWITCH CO.,LTD. USB Gamepad
Virtual keyboard pack 'vkeybd_default' loaded successfully
WARNING: No hardware input were defined, using defaults!
User picked target 'bbvs-win' (gameid 'bbvs')...
Looking for a plugin supporting this gameid... MTV's Beavis and Butt-head in Virtual Stupidity
Starting 'Beavis and Butt-head in Virtual Stupidity'
Using joystick: SWITCH CO.,LTD. USB Gamepad
/home/pi/RetroPie/roms/scummvm/+Start ScummVM.sh: line 4: 1506 Aborted /opt/retropie/emulators/scummvm/bin/scummvm --fullscreen --joystick=0 --extrapath="/opt/retropie/emulators/scummvm/extra" $game

When I try and start a new game and get booted back to the main screen, this line of text briefly shows up...

*** Error in `/opt/retropie/emulators/scummvm/bin/scummvm': double free or corruption (out): 0x7ee9b2d0 ***

Any ideas, thoughts or help would be greatly appreciated!