Error compiling EmulationStation

sushisan

Error on cmake .

-- found libvlc, version 3.0.8
-- VLC library found
-- Found VLC: /usr/include/vlc
CMake Error: Error in cmake code at
/root/rpmbuild/SOURCES/EmulationStation-git/CMake/Packages/FindRapidJSON.cmake:1:
Parse error. Expected a command name, got unquoted argument with text "".
CMake Error at CMakeLists.txt:62 (find_package):
find_package Error reading CMake code from
"/root/rpmbuild/SOURCES/EmulationStation-git/CMake/Packages/FindRapidJSON.cmake".

-- Found ALSA: /usr/lib64/libasound.so (found version "1.1.8")
-- Configuring incomplete, errors occurred!
See also "/root/rpmbuild/SOURCES/EmulationStation-git/CMakeFiles/CMakeOutput.log".
See also "/root/rpmbuild/SOURCES/EmulationStation-git/CMakeFiles/CMakeError.log".

After convert to ascii works ok. All others files in CMake/Packages are ascii encoded

cmake version 2.8.12.2

sushisan

$ file -bi FindRapidJSON.cmake
text/plain; charset=utf-8

$ file -bi FindFreeImage.cmake
text/plain; charset=us-ascii

Corrected with:
cat FindRapidJSON.cmake | iconv -f utf-8 -t ascii//TRANSLIT > FindRapidJSON.cmake

mitu

cmake 2.8.x is a 9 years old release, I guess since then it learned to support UTF8 for the generators/modules. Can't reproduce with a recent cmake version.

sushisan

This is exact but CMakeLists.txt say cmake_minimum_required(VERSION 2.8)
New versions of cmake don't have this error.
Converting FindRapidJSON.cmake to ascii like FindFreeImage.cmake FindlibCEC.cmake FindOpenGLES.cmake FindSDL2.cmake FindVLC.cmake MacroEnsureVersion.cmake can maintain compatibility without problem

mitu

Interesting. The problem seems to be from the UTF-8 BOM header present in the file.
Seems a bug has been logged here for this error, being fixed in the 3.0 release of cmake.

sushisan

Exact.
I see two solutions: update cmake_minimum_required or convert FindRapidJSON.cmake to ascii
The second solution can maintain compatibility and is very simple

sushisan

I have compiled EmulationStation on Centos 7 without problem with the second solution

mitu

@sushisan said in Error compiling EmulationStation:

I see two solutions: update cmake_minimum_required or convert FindRapidJSON.cmake to ascii

Probably both, at some point.

I have compiled EmulationStation on Centos 7 without problem with the second solution

Well, Centos7 is hardly a gaming platform :), probably that's why nobody complained so far. Thanks for reporting.

VictimRLSH

@mitu I used to run CentOS around 5.0 a long time ago. VERY maintenance heavy, switched to Knoppix. Maintenance headaches vanished. :)

sushisan

I want to use a long term supported distro and don't like Debian and derivates.
Centos 7 is still very stable but I will port to Centos 8

https://github.com/hiperiondev/RetroArcade-CentOS

mitu

@sushisan How about ArchLinux ? Never tried it, but I heard good things about it.

sushisan

I have not experience in Arch but I work with RedHat distros from '98.

BuZz

@sushisan without wanting to sound harsh, we are focussed on RetroPie. We can't be expected to support a distro that old (even if it's still supported by the vendor), with a cmake from 2015.

If you want to submit a fix that won't affect anything else feel free but for me it's a wontfix.

sushisan

@BuZz Are you correct!
I this case there are two errors: ascii encode and cmake_minimum_required
If you maintain minimum version of cmake in 2.8 then you have an error in encoding.
If you require newer version, and correct cmake_minimum_required, then there are no errors.

But I agree with you if not support oldedr versions. Is reasonable

BuZz

@sushisan I do agree with that. The code that fails was added later and I guess wasn't tested on older cmake. We can bump the cmake version but I don't mind if someone wants to make it work on older cmake too so long as it's easily maintainable. Eg Not having to adjusting the JSON cmake files if we upgrade that component to keep compatibility. Easier just to require a newer cmake.