RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login
    Please do not post a support request without first reading and following the advice in https://retropie.org.uk/forum/topic/3/read-this-first

    Having an issue with high score saving lr mame 2003 plus

    Scheduled Pinned Locked Moved Help and Support
    high scores
    29 Posts 7 Posters 4.8k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • G
      grant2258 Banned
      last edited by grant2258

      This is an easy fix thankfully tested it and it works.

      here is the original code

      https://github.com/libretro/mame2003-plus-libretro/blob/master/src/drivers/mcr3.c#L428-L436

      notice this saves videoram instead of nvram as is described here https://github.com/libretro/mame2003-plus-libretro/blob/0134c428b75882aa474f78dbbf2c6ecde49b97b7/src/drivers/mcr3.c#L35-L39

      change the nvram handler to the code (linked above) to what paste below and it will work as expected. This is something i always meant to look into but never found the time.

      static NVRAM_HANDLER( mcr3 )
      {
      unsigned char *ram = memory_region(REGION_CPU1);
      
      	if (read_or_write)
      		mame_fwrite(file, &ram[0xe000], 0x800);
      	else if (file)
      		mame_fread(file, &ram[0xe000], 0x800);
      }
      

      Like i said before in this case the driver needs an update nothing more nothing less. The problem here is the nvram was pointing to the wrong place in the memory map.

      M 1 Reply Last reply Reply Quote 1
      • M
        mahoneyt944 @grant2258
        last edited by mahoneyt944

        @grant2258

        Thank you. Is this change official or do I need to edit manually?

        Could you link me the updated mame2003_plus_libretro.so to replace mine?

        My editor keeps crashing when I open it :(

        mituM 1 Reply Last reply Reply Quote 0
        • mituM
          mitu Global Moderator @mahoneyt944
          last edited by

          @mahoneyt944 said in Having an issue with high score saving lr mame 2003 plus:

          Could you link me the updated mame2003_plus_libretro.so to replace mine?

          You can't edit the mame2003_plus_libretro.so file directly, the source needs editing and then re-compiled to produce the new mame2003_plus_libretro.so.

          M 1 Reply Last reply Reply Quote 1
          • M
            mahoneyt944 @mitu
            last edited by

            @mitu

            Yeah I kind of figured so when I saw the jumbled mess inside the file lol. Is anyone willing to compile this update and post it?

            1 Reply Last reply Reply Quote 0
            • arcadez2003A
              arcadez2003
              last edited by

              https://github.com/libretro/mame2003-plus-libretro/pull/780

              Arcade Addict

              M 1 Reply Last reply Reply Quote 3
              • M
                mahoneyt944 @arcadez2003
                last edited by

                @arcadez2003

                Thank you, does anyone have it compiled so I can update my system manually? Getting ready to back up my pi but wanted to get this fix in there before I do.

                1 Reply Last reply Reply Quote 0
                • RiverstormR
                  Riverstorm
                  last edited by

                  @mahoneyt944 - You'll probably need to download from source from within the RetroPie Setup menu to get the latest commits. Basically where you installed the emulator, there should be two options, download from binary or download from source.

                  M 1 Reply Last reply Reply Quote 0
                  • M
                    mahoneyt944 @Riverstorm
                    last edited by mahoneyt944

                    @Riverstorm

                    The change made isn't official yet to update from source. That's why I was hoping someone could compile it

                    1 Reply Last reply Reply Quote 0
                    • G
                      grant2258 Banned
                      last edited by grant2258

                      Ill provide instructions for you to compile it im assuming you have a pi3 if not change the platform to rpi2.

                      There is things to keep in mind one you should have mame2003-plus installed via retropie so everything is setup. The code below will compile mame for you at the bash prompt via ssh or f4 depending on your preference.

                      git clone https://github.com/libretro/mame2003-plus-libretro.git
                      cd mame2003-plus-libretro/
                      wget https://github.com/libretro/mame2003-plus-libretro/pull/780.patch
                      git am 780.patch
                      make -j8 platform=rpi3
                      

                      copy the binary over that is made over the old one and be sure to delete the source directory when finished.

                      M 1 Reply Last reply Reply Quote 0
                      • M
                        mahoneyt944 @grant2258
                        last edited by mahoneyt944

                        @grant2258 thank you.

                        1 Reply Last reply Reply Quote 1
                        • RiverstormR
                          Riverstorm
                          last edited by

                          @mahoneyt944 - Sorry, I see there are a few pull requests pending. =/

                          arcadez2003A 1 Reply Last reply Reply Quote 0
                          • arcadez2003A
                            arcadez2003 @Riverstorm
                            last edited by

                            @Riverstorm said in Having an issue with high score saving lr mame 2003 plus:

                            @mahoneyt944 - Sorry, I see there are a few pull requests pending. =/

                            Yeah when i retired from active dev with regards to the MAME2003+ core i gave up my contributor status and my push and pull access
                            when i left the libretro organization, i just wanted to add the code as per a request from @grant2258 as a favour due to him helping
                            me out a fair times in that dept.

                            So will just need to be patient until such a time as someone does the merge.

                            Arcade Addict

                            1 Reply Last reply Reply Quote 0
                            • RiverstormR
                              Riverstorm
                              last edited by

                              @arcadez2003 - That's not an issue at all. I appreciate the past few years of hard work you put into the core and the little things you and grant keep adding. I got so used to the commits being pushed as fast as you and grant were banging them out. I didn't stop to think that it might not be merged when Mahoney had asked. No worries at all! ;)

                              1 Reply Last reply Reply Quote 0
                              • G
                                grant2258 Banned
                                last edited by

                                @arcadez2003 this isint quite working it must be shared memory needing mapped for it to work. It only worked because i had a previous nvram there is you delete the old one and create a fresh one it doesnt work will need to look into this driver more.

                                M 1 Reply Last reply Reply Quote 0
                                • M
                                  mahoneyt944 @grant2258
                                  last edited by

                                  @grant2258 Mine works but already had an old nvram file too.

                                  1 Reply Last reply Reply Quote 0
                                  • G
                                    grant2258 Banned
                                    last edited by

                                    Never ind me Its working fine i did a copy and paste error on my port is working fine here. If you have any issues let me know. test if you like move your nvram and try making a new one. Then move your old one back after testing.

                                    M 1 Reply Last reply Reply Quote 0
                                    • M
                                      mahoneyt944 @grant2258
                                      last edited by

                                      @grant2258

                                      Thanks

                                      1 Reply Last reply Reply Quote 0
                                      • M
                                        mahoneyt944
                                        last edited by mahoneyt944

                                        This post is deleted!
                                        1 Reply Last reply Reply Quote 0
                                        • First post
                                          Last post

                                        Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                        Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.