Is Yabasanshiro emulator coming on retropie?
-
@notthesame i would much rather see a pull request to the projects in question, personally. it doesn't have to be perfect - i am sure devyimax and co can help!
-
the issue is i had to edit the shaders file so it wont match with any other machines opengl shaders, it seems to be a issue with mesa but ill see what i can do to have it on git hub
another thing is a build this emulator under fkms, as i only support retropie, dont care for other os images.
ok ill see what i can do and upload it at the pull request projects.
thank you guys for letting me use retropie and soon we will see retropie have a saturn emulator to work properly on pi4. -
@dankcushions said in Is Yabasanshiro emulator coming on retropie?:
i am sure devyimax and co can help!
Well, good luck with that...
-
@notthesame Well, if you can share your binary for people to mess around with for now, that would be great too:)
-
@Darksavior Just to note - the license would require the source released too (with the changes) if a binary is released.
-
@BuZz said in Is Yabasanshiro emulator coming on retropie?:
Just to note - the license would require the source released too (with the changes) if a binary is released.
Fun fact (or not... it's actually one of the reasons why i don't want to be associated with that core anymore), devmiyax himself is releasing binaries without releasing the code...
-
Hey! The emulator looks really nice, is there any release date for it, or a way to play it.
-
@notthesame at the least i would update all your findings to https://github.com/devmiyax/yabause/issues/704 - i'm really surprised you're not choosing to involve devyimax in this. that's primarily the person who can help. at the least they are going to want to investigate the 0GLES3 issue. that needs debugging.
-
@dankcushions said in Is Yabasanshiro emulator coming on retropie?:
i'm really surprised you're not choosing to involve devyimax in this. that's primarily the person who can help
That's not the problem here, he tried to reach out devmiyax on discord a number of times, and never got any answer afaik. Tbh, that's expected, my personal experience with this project as a contributor has been horrible, pushing PR to add features or fixing stuff, waiting several weeks for the PR to be merged, without getting any heads up, then learning that the feature you implemented has been added to beta binaries for patreon backers & yabasanshiro pro (paid version on android) users.
-
@barbudreadmon that's crappy, sorry that happened :( i can only hope he is just being a bit ignorant rather than actively trying to rip you off.
for this issue, just for me, if nothing else it would focus where the information is stored. there's so many threads with info spread across github, rpi forums, here and now discord, but none collect it all. i do still value devyimax's input here, or anyone familiar with the core, GLSL, etc, but i'm not sure it's getting to those people.
-
Happy to give this a good test if you're able to fork it, or provide a binary (Or as BuZZ says, you'd probably need to do both).
-
@dankcushions said in Is Yabasanshiro emulator coming on retropie?:
@notthesame great work! let us know when you have a PR or if you need any help with that arranging that. we should try and do the fix also in the upstream devyimax project.
hey dankcushions
can you please help me out please, i wouldnt know how to setup this PR a help to setup for the emulator to be installed on retropie, where can i send you the source already to go? im just about confused about where can i upload it, i do have it on my dropbox, thanks as always -
If you like, I have github (and now khow to use it). You could post the link to the dropbox link here, and I'll fork it and then we can submit the PR.
(Or I'm sure dank can do the same - if you post the link, whoever does it first I guess!).
-
What also might be helpful, if you checked out the git repository, would be to git diff and pipe this to a file and include this link also.
git diff > diff.txt
Or to tell us what commit you are at currently:
git log -1
This would help with forking more accurately and potentially not undoing commits made after you checked out the code, although the project hasn't been committed to for 14 days, so it's likely not an issue.
-
@steeeb They already said they don't have a git repository, you'll have to be patient.
-
@mitu he's said he wouldn't know how to set up the pull request. And I'd advised him on how it can be achieved by firstly providing the link to dropbox he says he had, and if he got the code via github initially (which I'm assuming he did - since it's the only place the source exitst) how to get more specifics to allow it to be forked in the right place.
If that is impatience I'll instead just not comment those asking for help.
-
@dankcushions said in Is Yabasanshiro emulator coming on retropie?:
rather than actively trying to rip you off
tbh, i don't care if he makes money from this, GPL allows it, i'm only interested by the license being respected, especially after that shitty last year, and binaries can't be distributed without providing the sources under GPL.
-
Just to note, I did a quick hack to fix the colours on the RPI. I'm going to clean up the changes to send upstream for comment after doing some more work on it. My knowledge in this area is poor, but it seems rounding up the calcs in texelFetch resolves it. However I can't believe this is a bug in the Mesa VC shader compilation as I would have thought it would affect lots of stuff. But I really don't know.
I'll post a diff shortly for anyone who wants to test/comment but I'm keen to find the cause of the issue - I don't consider my changes a proper fix.
-
Here's a diff.
But as I said, I think this is a wrong fix even though it does correct the colour issues. Something else must be at play here.
http://malus.exotica.org.uk/~buzz/round.diff
I'll do a PR with a module for people to more easily test also. The patch may include unneeded changes also.
-
arm does not like unsigned (anything) with float and there is plenty of them in here.
https://stackoverflow.com/questions/4752315/coercing-float-into-unsigned-char-on-arm-vs-intel
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.