Is Yabasanshiro emulator coming on retropie?

notthesame

@BuZz said in Is Yabasanshiro emulator coming on retropie?:

Just to note, I did a quick hack to fix the colours on the RPI. I'm going to clean up the changes to send upstream for comment after doing some more work on it. My knowledge in this area is poor, but it seems rounding up the calcs in texelFetch resolves it. However I can't believe this is a bug in the Mesa VC shader compilation as I would have thought it would affect lots of stuff. But I really don't know.

I'll post a diff shortly for anyone who wants to test/comment but I'm keen to find the cause of the issue - I don't consider my changes a proper fix.

thanks , i dont think mine is a proper fix either, i dont know what is the issue but i thought it was on the mesa side as well, id go with a fix that is not finding a error by trail and error like i did and find out i missed something that wont help later on, the colors seem to be reversed, 0 is 1 and 1 is 0, this is all i can prove, 65280 color is 255 not sure what theses mean, but i needed to shift <<8 i had to ask a few people on this and it worked but i cant find anymore solution on fixing this anymore.

thank you for stepping in and hopefully we can get better work then mine.

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

arm does not like unsigned (anything) with float and there is plenty of them in here

shaders are compiled at runtime by gpus, i don't know if gpus can be defined as arm or x86, but anyway that can't be the problem here, yabasanshiro is written primarily for android and afaik doesn't suffer from this color issue on any board besides the pi4

mechafatnick

@barbudreadmon heh, if the Yabasanshiro guy is dodgy, do you reckon there's any hope of lr-Kronos being able to run on pi4?

grant2258

@barbudreadmon said in Is Yabasanshiro emulator coming on retropie?:

shaders are compiled at runtime by gpus, i don't know if gpus can be defined as arm or x86, but anyway that can't be the problem here, yabasanshiro is written primarily for android and afaik doesn't suffer from this color issue on any board besides the pi4

Well if that is the case why does the changes proposed fix it thats nothing to do with gpu compilation its data manipulation and what other platform is using the gles3 codepath on arm that is working ? It might be a good way to check whats changing where if its working on another device with the same codepath

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

It might be a good way to check whats changing where if its working on another device with the same codepath

As already mentioned, drivers, rpi4's are broken, it has been known since its release.

@mechafatnick said in Is Yabasanshiro emulator coming on retropie?:

@barbudreadmon heh, if the Yabasanshiro guy is dodgy, do you reckon there's any hope of lr-Kronos being able to run on pi4?

Kronos is an OpenGL emulator, it doesn't run on gles.

grant2258

Well the driver was never claimed to be completed. The least you can do is keep the driver up to date as well. https://github.com/Yours3lf/rpi-vk-driver

BuZz

@grant2258 not sure the point of your post? That vulkan driver is in early stages and is irrelevant.

If you're looking to start another argument I can assure you that isn't going to happen.

grant2258

argument ? Im posting links to a driver related to this not sure where your coming from? I thought this could be good to test on other pies apart from the 4 if your not interested fair enough

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

Well the driver was never claimed to be completed

Yes, that's exactly what i'm saying, it was released almost 11 months ago and its gpu drivers are still incomplete.

steeeb

@BuZz what build options are you using? Could you share your scriptmodule?

BuZz

@steeeb Sorry - I wanted to revisit and check some more things before posting . Here you go.

https://github.com/RetroPie/RetroPie-Setup/pull/3132

Darksavior

Briefly trying this. The fps is misleading since frameskip is enabled by default so in reality panzer is ~50-55fps. There's a bug with the distance being white. I really wanted to use the crt-pi shader but that drops it to ~45fps. Despite all of these fps drops, the audio does not skip like yabause.

Radiant Silvergun has severe glitches making it unplayable. Sometimes they go away.
Oc'd to 1900Mhz.

ash0904

@Darksavior Hey! i saw that you were able to get the emulator working. it wont show up on experimental. is there any way to fix this?

Darksavior

@ash0904 It won't show there because it's not done. I added it manually to try it out.

GeekOB

Would love to test this out when it's ready for experimental release @Darksavior.
Will it support CHD or other compressed formats?

Darksavior

@GeekOB All of my games are in chd and they seem to work. If you want to try it out, no one's stopping you. I downloaded the whole repo from https://github.com/joolswills/RetroPie-Setup and took out the installer script and folder with the patch and stuck them in my own RetroPie-Setup folder.

notthesame

@Darksavior thoses glitches are glitches I can't remove RSG it looked like a texture is backwords, hopefully this fix is better then mines on Castlevania near the start by the mermens it goes black. And minor glitches.
Also set your video settings in retroarch to
Vertical sync, off
hard gpu sync off,
max saw chains images 4
sycn to exact C.F off.

Darksavior

@notthesame No issues with the mermen, other than the black bar on top turning yellow. Attempting to save froze the whole game, though.

roslof

Good evening (morning),

Troubleshooting Requested:

I'm very interested in the effort here and completely realize this is incredibly early. I did jump in and attempt to run Yabasanshiro on my RPi4B (everything else in the world is running fine on it, BTW).

I had no trouble compiling/patching/installing with the lr-yabasanshiro module linked above. I copied relevant (and MD5 verified) BIOS files to a /yabasanshiro subfolder within BIOS, as directed by the module help.

Regardless of ROM (CD image) (.chd or cue/bin) I'm getting a black screen and hang. /dev/shm/runcommand.log tails with this:

[INFO] [GL]: VSync => off
[INFO] SET_GEOMETRY: 320x224, aspect: 1.333.
[INFO] [KMS]: New FB: 1920x1080 (stride: 7680).
[INFO] [RCHEEVOS]: Load task finished

There are no significant Errors, Fatals or missing files noted in the log. At this point, I have to kill -9 RetroArch.

These CD images work fine with lr-yabause, so I know the problem is somewhere else on my side. User error, so to speak... (ugh).

Are there any other special dependencies I might be missing? Driver change or upgrade?

GeekOB

Hi @Darksavior
Unfortunately I get the following error:

patching file yabause/src/yglshaderes.c
Hunk #1 FAILED at 297 (different line endings).
Hunk #2 FAILED at 319 (different line endings).
Hunk #3 FAILED at 408 (different line endings).
Hunk #4 FAILED at 467 (different line endings).
Hunk #5 FAILED at 553 (different line endings).
Hunk #6 FAILED at 1327 (different line endings).
Hunk #7 FAILED at 1392 (different line endings).
Hunk #8 FAILED at 1495 (different line endings).
Hunk #9 FAILED at 1605 (different line endings).
Hunk #10 FAILED at 1758 (different line endings).
Hunk #11 FAILED at 1818 (different line endings).
Hunk #12 FAILED at 1826 (different line endings).
Hunk #13 FAILED at 1944 (different line endings).
Hunk #14 FAILED at 1953 (different line endings).
Hunk #15 FAILED at 2072 (different line endings).
Hunk #16 FAILED at 2528 (different line endings).
patch unexpectedly ends in middle of line
Hunk #17 FAILED at 2634 (different line endings).
17 out of 17 hunks FAILED -- saving rejects to file yabause/src/yglshaderes.c.rej
/home/pi
lr-yabasanshiro patch /home/pi/RetroPie-Setup/scriptmodules/libretrocores/lr-yabasanshiro/01_shader_hack_rpi4.diff failed to apply

Any idea why this could happen? Did I miss a step?