mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support

bluestang

@barbudreadmon said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

https://github.com/libretro/mame2003-plus-libretro/issues/531

That one wouldn't help at all actually, it's x86_64 only.
Supposing someone would be interested in this, is old MAME code compatible with GPLv2 code ? If so there are several arm mips3 drc that might be reusable (mupen64, pcsx-rearmed, ...).

This is the only thing I could find on licensing for mame2003plus - https://raw.githubusercontent.com/libretro/mame2003-plus-libretro/master/LICENSE.md

As you stated this would probably be the best bet for the arm dynarec needed - https://github.com/pcercuei/lightrec

As for dev interest in this that’s something I can’t speak to. I am not a dev and I have very little exposure to coding.

Rion

@markwkidd @Riverstorm @grant2258 @arcadez2003 @barbudreadmon @pjft

After some talk back and fort with markwkidd & Wildstorm about games marked as Categorized in the old catver.ini and searching thru 728 drivers in src/drivers/ for games marked as "GAME_NOT_WORKING" the new and hopefully last update before the Pull requests is finished.

Update catver.ini with more complete information #829

Riverstorm

@Rion - I appreciate the work put into the file. Nicely done!

@arcadez2003 - Sorry, I talked to Grant and he was able to explain some things and the best way to handle them, everything looks fine. The new games should be correct when using the TAB menu to auto-generate the DAT.

I don't know if you're still paying attention to the issues on m3plus but I think I'm making more of mess than helping trying to update my fork and get the PR submitted correctly.

I also don't quite understand the hierarchy. Such as fork the repo and then use branches for the updates to keep the PR's separate, then merge them to my fork. Everytime I do a commit to my fork it's bundled with the first PR instead of separate PR's.

As of now they are all in one, including my fork update PR. Where I switched the head and base ~~master~~ around trying to pull the latest updates into my fork. You can't update your fork without making it PR request to the master repo? Basically I just wanted to resync my fork. I don't quite know what I'm doing or I would submit the updates.

Basically I don't want to tork off a bunch of folks that are running the m3plus core because of my lack of knowledge and excessive un-squashed/reverted commits. I tried to learn it but I'm still missing a few fundamental pieces to make it all go.

arcadez2003

@Riverstorm said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@Rion - I appreciate the work put into the file. Nicely done!

@arcadez2003 - Sorry, I talked to Grant and he was able to explain some things and the best way to handle them, everything looks fine. The new games should be correct when using the TAB menu to auto-generate the DAT.

I don't know if you're still paying attention to the issues on m3plus but I think I'm making more of mess than helping trying to update my fork and get the PR submitted correctly.

I also don't quite understand the hierarchy. Such as fork the repo and then use branches for the updates to keep the PR's separate, then merge them to my fork. Everytime I do a commit to my fork it's bundled with the first PR instead of separate PR's.

As of now they are all in one, including my fork update PR. Where I switched the head and base ~~master~~ around trying to pull the latest updates into my fork. You can't update your fork without making it PR request to the master repo? Basically I just wanted to resync my fork. I don't quite know what I'm doing or I would submit the updates.

Basically I don't want to tork off a bunch of folks that are running the m3plus core because of my lack of knowledge and excessive un-squashed/reverted commits. I tried to learn it but I'm still missing a few fundamental pieces to make it all go.

Your asking the wrong guy honestly, i dont know much about the in's and out's of the git TBH, i just edit a file one at a time in the main branch the git makes the change
in my fork then i push it to mainline it seems to work 99% of the time :)

Riverstorm

@arcadez2003 - lol...your honesty is refreshing so I don't look like a complete idiot as I'm sure for the guru's this is elementary stuff here! ;) I am struggling a bit but would like to help with the metadata once I figure out how it works. The DAT has to many changes/to large to do direct edits which I think I understand how to do those. The same for the catver.ini.

I did submit a clean PR on the catver.ini by directly editing the fork but all other new commits on the fork went to the same PR. I think that's where I went wrong. New branch for each PR. Not to mention updating the fork. I closed the first PR, trashed the fork and re-forked with the updates. I just wanted to sync my fork but no joy on how to do it from the website.

Anyway I honestly tried to understand the off line workflow and put in the time for sure trying. I think I am close but I jut have to take a break and regroup but I can't find the answers I need to understand.

I have to give props to Grant also, he banged out the list of commands with short explanations and said do that and it should work. I know he's tough but he does know his stuff.

I know folks don't want to sit around and have a school day explaining the in and outs but sometimes just letting it sink in really helps, we'll see.

Just to clarify, nothing was wrong with the DAT. Grant said don't use WinMerge due to how it compares or the algorithm is throwing things off. I used Notepad++ to view it straight up and things look exactly correct as they should with the new games you just added.

Rion

@arcadez2003

Same here.

I have no idea how to submit a Pull Request. But the catver.ini is finished and I apparently made a big bobo and uploaded an older version before so that's not good. Sorry to everyone that filtered your roms with the older version.

catver_Mame2003Plus_FINAL.ini

4920 Individual entries with non working games marked as Uncategorized.

Would someone be so kind to make a Pull Request so that this can be added to github?

Clyde

@Rion said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

Sorry to everyone that filtered your roms with the older version.

That would be me (I did it right before your first release and once again with @Riverstorm's version yesterday), but hey, that's what we retrogaming people do anyway when we get bored because our systems actually got "finished"™ so all that is left left would be to actually play the games. 😁

Thank you and the others here for your praiseworthy contributions!

Rion

@Clyde

Yea i know.. Sorry again.

Hopefully this will make it a little bit easier. In the same share as the catver.ini there is a folder example of how to set up you category's. 21 folders with 169 under folders for the receptive category.

arcadez2003

https://github.com/libretro/mame2003-plus-libretro/pull/833

arcadez2003

@Riverstorm said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 - lol...your honesty is refreshing so I don't look like a complete idiot as I'm sure for the guru's this is elementary stuff here! ;) I am struggling a bit but would like to help with the metadata once I figure out how it works. The DAT has to many changes/to large to do direct edits which I think I understand how to do those. The same for the catver.ini.

I did submit a clean PR on the catver.ini by directly editing the fork but all other new commits on the fork went to the same PR. I think that's where I went wrong. New branch for each PR. Not to mention updating the fork. I closed the first PR, trashed the fork and re-forked with the updates. I just wanted to sync my fork but no joy on how to do it from the website.

Anyway I honestly tried to understand the off line workflow and put in the time for sure trying. I think I am close but I jut have to take a break and regroup but I can't find the answers I need to understand.

I have to give props to Grant also, he banged out the list of commands with short explanations and said do that and it should work. I know he's tough but he does know his stuff.

I know folks don't want to sit around and have a school day explaining the in and outs but sometimes just letting it sink in really helps, we'll see.

Just to clarify, nothing was wrong with the DAT. Grant said don't use WinMerge due to how it compares or the algorithm is throwing things off. I used Notepad++ to view it straight up and things look exactly correct as they should with the new games you just added.

Yeah thats the problem the dat is too big to edit and push manually, if you try to do so it'll take so long as to make the github timeout while trying
upload the file, i lucked out and it worked once for me but it took many bites at the cherry, so im reluctant to try again less we end up without
a dat as the old one has to be removed firstly before adding a new one manually.

As i said we need someone who has the github setup on their PC then they simply upload it to the site using the special github tools
at the end of the day if the worst comes to the worst and we cant find anyone willing to do it if im sent an up to date dat i'll try it again the risky way :)

Riverstorm

@arcadez2003 - Ok I took another crack (another bite at the cherry) at updating the DAT. I appreciate your humor getting through things. It's just taking time to get used to how Github does its workflow. I created a branch from the fork I pulled down to Github Desktop. Created the commit, pushed it back and submitted a pull request based off the branch.

I know the last PR I did sat for 2 months and it was a real simple cleanup of the DAT which still has that same issue. If this goes through I will clean up that custom OST for the sake of uniformity with the other OST's if this one goes through.

@Rion - I sincerely apologize for all the issues and really appreciate all the work (and patience) you put into the catver.ini, big accomplishment. If I can get the hang of it I promise to be of better help in the future! ;)

Riverstorm

DAT Update:

https://github.com/libretro/mame2003-plus-libretro/pull/834

Rion

@arcadez2003 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

https://github.com/libretro/mame2003-plus-libretro/pull/833

Thank you!

@Riverstorm said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@Rion - I sincerely apologize for all the issues and really appreciate all the work (and patience) you put into the catver.ini, big accomplishment. If I can get the hang of it I promise to be of better help in the future! ;)

No worries mate. This was very tedious but fun at the same time. :)

arcadez2003

@Riverstorm said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

DAT Update:

https://github.com/libretro/mame2003-plus-libretro/pull/834

It's all fan dabby dozy :)

Rion

New catver.ini up based on latest dat.

Added

gulunpa=Puzzle / Drop
opaopan=Shooter / Flying Horizontal
slapshtr=Sports / Hockey
tetrisse=Puzzle / Drop
tnk3b=Shooter / Driving Vertical

Riverstorm

@Rion - Ok, the new updates are submitted. ;) My plan was to do your new catver.ini first but arcardez beat me to it so I did the DAT to test. Here's the PR:

https://github.com/libretro/mame2003-plus-libretro/pull/836

I know what you mean by tedious. I've been updating the resolution_db file for shaders. I think Udb posted one a while ago for fbeno .44 that I grabbed from that thread. It has 100's of missing resolutions for clones. I know it's out of date almost immediately but it's newer than the original one for fbalpha. Anyway it's a line by line update but like you I do a few minutes here and there which I don't mind.

TedMaul

@johnodon perfect - thank you!!

johnodon

outfxies was discussed earlier in this thread but just wondering if there is any update. Sound is still listed as preliminary...

<driver status="good" color="good" sound="preliminary" palettesize="8192"/>

Current MAME (not Libretro) plays without issue.

arcadez2003

MAME2003 would require two extra sound cores + a new M37710 CPU core to emulate the sound for Outfoxies and the rest of the Namco NB1 + NB2 games
the sound cores would not be too difficult however the CPU core is in no way compatible with our codebase, so it's a non starter otherwise i would have
hooked up the sound for these games already.

But of course nothing is impossible in this world, if someone with more talent than me were to come along and radically rework the M37710 so it would be
compatible with the MAME2003 codebase then you might one day have sound and music in Outfoxies, maybe a bounty might do the trick

These are the changes to the codebase which would be required........

0.100u1: R. Belmont fixed incorrect voices in the NB-1 games.
0.99u9: Added sndhrdw\namcoc7x.c/h. Major Namco sound improvements [R. Belmont]: Added emulated sound and music to all NB-1, NB-2 and System 11 games, using Prop Cycle's MCU BIOS (pr1data.8k) as a substitute until the original can be trojaned or otherwise obtained. Hooked it up for plain System 22 games as well, but they're not interested in passing down proper commands for some reason. Speed-cheated all instances of the M37710/C352 sound system so CPU requirements don't go up much. This also helped back off the requirements a hair for Prop Cycle and Time Crisis. C352 now sets output pitch correctly by input clock. Added M37710 (16128000 Hz) CPU2 and C352 (16128000 Hz) stereo sound.

bluestang

@barbudreadmon @arcadez2003 Can any of you explain how the sound driver works? ADSP2105?

A very weird development, but I was messing around with the aarch (64-bit RPiOS) version of RetroPie and accidentally disabled the sound for mame2003-plus. I loaded up Killer Instinct and it was getting up to 120 fps on what I presume are the "speed ups". This was also using the Vulkan driver.

So I'm wondering if the slowdowns are caused by the sound driver instead. Later versions of mame have better implementations of the ADSP21XX series...