Raspberry Pi 4B 4GB and the Sega Saturn

mxstar1 · 16 Oct 2020, 19:51

@BuZz Yeah thats what i figured, but i dont know how to edit the patch to work with the newly released emulator, hopefully whoever made the patch can re-release it for this updated emulator. I think it was written by joolswills.
@quicksilver maybe you might know?

BuZz · 17 Oct 2020, 01:54

That's me.

I'll check but it worked a few days ago. The performance issues are due to compiler optimiser changes most likely. Which also actually break virtua racer in game / map gfx.

The optimiser issues are really due to code with undefined behaviour in the source and the way c/c++ is mixed. I mentioned some problems in the other topic afair.

I am not confident of including a module yet until I have had time to address some more issues upstream.

But I'll check/fix up the patch if it's a quick fix.

BuZz · 17 Oct 2020, 02:14

@mxstar1 the patch failed due to a line ending cleanup upstream (which is great as the mixed endings was an issue).

I rebased the patch so it should work again.

The issue I mentioned with virtua racer may still be present. By the looks of code changes the optimiser flags were tweaked for another arm board due to issues, but really the fix is to identify the undefined behaviour/problematic code and fix it so it doesn't behave differently at different optimiser levels.

BuZz · 17 Oct 2020, 03:51

The virtua racer issue I had seen before when lowering optimisation levels. However it's not the cause now and changing them doesn't help unless I revert to an earlier version.

Bisecting is tricky due to the fork having submodules. I will need to bisect, re-adding submodules when hitting a commit from the upstream repo to find out which actual upstream commit (parent to the libretro branch) had the issue so it will take longer. Probably debugging the parent standalone version would work better.

In the meantime I am going to change my branch to use an older version again.

BuZz · 17 Oct 2020, 04:10

Sorry for topic spam. I have reset my branch back to how it was in may (probably shouldn't have squashed my changes as had to usegit reflog to roll back).

I force a version from Jul 11th now.

This was before some big merges were made from upstream. Probably improvements for some games but now my test game virtua racer is working again, and due to the issues I mentioned above it's better for now to lock to this version until I have some time to feed some useful reports upstream.

You will need to do a fresh checkout of my branch etc probably.

Libation · 17 Oct 2020, 05:59

@BuZz Just installed, working now. Thank you very much! I did have to to do a fresh checkout of your branch (for anyone else reading).

defixiones · 17 Oct 2020, 22:46

The patch still won't apply for me, using the latest version of the two files, pulling yabuse 73c67668.

AdamBeGood · 1 Dec 2020, 01:03

Hi all,

Just wondering if anyone has tried to update their Yabanshiro recently? I was thinking about giving it a go to see if there have been any improvements - I was trying to run ThunderForce V and it doesn't run very well on my Pi.

Then I see there have been some issues with more recent versions and wondered if I should leave my version as it is, and not mess around.

Thanks!
Adam

Darksavior · 1 Dec 2020, 01:03

@adambegood No change. Since Thunderforce 5 runs at around 35fps on my pi4 at 2Ghz/750Mhz, I don't expect to ever be playable.

AdamBeGood · 1 Dec 2020, 09:40

@darksavior said in Raspberry Pi 4B 4GB and the Sega Saturn:

@adambegood No change. Since Thunderforce 5 runs at around 35fps on my pi4 at 2Ghz/750Mhz, I don't expect to ever be playable.

I'll have a look at the PSX version then...

AdamBeGood · 1 Dec 2020, 14:59

@buzz said in Raspberry Pi 4B 4GB and the Sega Saturn:

Sorry for topic spam. I have reset my branch back to how it was in may (probably shouldn't have squashed my changes as had to usegit reflog to roll back).

I force a version from Jul 11th now.

This was before some big merges were made from upstream. Probably improvements for some games but now my test game virtua racer is working again, and due to the issues I mentioned above it's better for now to lock to this version until I have some time to feed some useful reports upstream.

You will need to do a fresh checkout of my branch etc probably.

Sorry for the ignorance but where do I locate your branch?

I've tried to update my Yabanshiro and it isn't working now, presumably because of me having the older patch.

Thanks for the help.

Firebird_WS6 · 1 Dec 2020, 19:04

@BuZz Just tried to compile and got the following error message:

/home/pi/RetroPie-Setup/scriptmodules/libretrocores/lr-yabasanshiro/01_shader_hack_rpi4.diff failed to apply.

It seemed from a few posts earlier that the diff failing to apply had been resolved? Is there something I need to change in the original method of installation to get this to work?

Edit: I think I found @BuZz branch and changed the source in lr-yabasanshiro.sh to

gitPullOrClone "$md_build" https://github.com/joolswills/yabause.git yabasanshiro

It looked like it was working and I didn't get the failed to apply diff error, but in the end I got this error message:

Could not successfully build lr-yabasanshiro - Saturn & ST-V emulator - Yabasanshiro port for libretro (/home/pi/RetroPie-Setup/tmp/build/lr-yabasanshiro/yabause/src/libretro/yabasanshiro_libretro.so not found).

Any ideas how to fix?

BuZz · 1 Dec 2020, 23:33

It builds ok here. You probably have an old checkout or didn't reset to my upstream code after I force pushed changes.

Do a clean checkout of my branch in a new location perhaps. I recently rolled back and there are still issues with some games I tested due to GCC optimization of code with undefined behaviour.

Id rather not this become something I'm asked to help with sorry - the current PR builds fine but it's not supported.

BuZz · 1 Dec 2020, 23:43

@firebird_ws6 also don't switch it to my fork. My PR doesn't use my fork of the main code.

Darksavior · 1 Dec 2020, 23:50

@firebird_ws6 I installed it yesterday without issues.

Firebird_WS6 · 2 Dec 2020, 00:03

@Darksavior @buzz I'm still learning with building packages. I'm not sure what needs to change in lr-yabasanshiro.sh to make it use your branch. Currently the default is as follows:

gitPullOrClone "$md_build" https://github.com/libretro/yabause.git yabasanshiro

What would I need to change in this?

BuZz · 2 Dec 2020, 00:34

@firebird_ws6 what do you mean default?

The code is not in RetroPie by default and that line has been changed in my branch some time ago.

Firebird_WS6 · 2 Dec 2020, 00:39

@buzz I meant the files that quicksilver posted earlier in this thread. I'm still learning with Github, I think I found your branch (as opposed to your fork), which it looks like was updated just now. I copied the code into the files on my Pi4 so I'll give it a go at building again. Thanks for your help.

Darksavior · 2 Dec 2020, 00:55

@firebird_ws6 I'm using the scripts from here: https://github.com/joolswills/RetroPie-Setup/tree/lr-yabasanshiro

BuZz · 2 Dec 2020, 01:20

@firebird_ws6 nothing changed in the branch. I just rebased it so it contains recent retropie changes from master branch. You need to checkout my branch and build from there.

You can do this in another location. Maybe Google how to clone a Pull Request on GitHub. I think GitHub provides info on this also on the Pull request.

eg. To grab a copy of this branch.

cd ~
mkdir temp
cd temp
git clone -b lr-yabasanshiro https://github.com/joolswills/RetroPie-Setup.git
cd RetroPie-Setup
sudo ./retropie_packages.sh lr-yabasanshiro

If I update or rebase you can remove and redo or do git fetch origin and git reset --hard origin/lr-yabasanshiro