RetroPie 4.7.1: Trouble getting custom_viewport_... settings to work

Alturis

I have been away for some time but recently upgraded my Pi 3 B+ to a Pi 4 and was in the process of migrating my RetroPie setup. Started with a fresh install of RetroPie as I had read on here that the differences in hardware require that.

I am seeing that my settings for custom_viewport_width/height/x/y are no longer functioning and wondering if this works differently now. Did a search in the forums for custom_viewport and not seeing anything that sounds like that would be the case.

Example:
/opt/retropie/configs/gba/retroarch.cfg

aspect_ratio_index = "22"
custom_viewport_width = "960"
custom_viewport_height = "640"
custom_viewport_x = "480"
custom_viewport_y = "220"

input_overlay = "/opt/retropie/emulators/retroarch/overlays/arcade-bezels/gba_udb-ovl.cfg"
input_overlay_enable = "true"
input_overlay_opacity = "0.900000"
input_overlay_scale = "1.000000"
input_remapping_directory = "/opt/retropie/configs/gba/"

video_shader_enable = "true"
video_shader = "~/.config/retroarch/shaders/zfast_lcd_standard.glslp"

input_a_btn = "4"
input_b_btn = "3"
input_x_btn = "0"
input_y_btn = "1"

#include "/opt/retropie/configs/all/retroarch.cfg"

Results in it just filling the whole screen top to bottom but cut off at the sides at its aspect ratio.

mitu

RetroArch's list of resolutions have switched the 'custom' aspect ration index to 23 - see https://retropie.org.uk/forum/topic/22553/retroarch-video-settings-not-working/6.

Alturis

@mitu Thank you!

Alturis

@mitu And now that I think about it I am pretty sure I ran into that previously when it was changed from 21 to 22 or whatever.
Had forgotten. Thanks again.

Alturis

Was thinking about this more and I think this kind of thing could be improved. Software that has unique indexes of an enumeration that are supposed to be referenced in data is a bad thing. What could help this is making aspect_ratio_index accept either indexes (for backward compatibility) or enumeration names.

If one could set

aspect_ratio_index = "custom"

Then no matter how many times new aspect ratio types are changed/added/removed everyone's configurations will continue to work fine. (as long as those configuration enum names have not been removed)

Alturis

And interestingly, with a fresh install of RetroPie 4.7.1 the comments in the main retroarch.cfg are not up to date

/opt/retropie/configs/all/retroarch.cfg

# Index of the aspect ratio selection in the menu.
# 19 = Config, 20 = 1:1 PAR, 21 = Core Provided, 22 = Custom Aspect Ratio
# aspect_ratio_index = 19

mitu

@alturis said in RetroPie 4.7.1: Trouble getting custom_viewport_... settings to work:

And interestingly, with a fresh install of RetroPie 4.7.1 the comments in the main retroarch.cfg are not up to date

The file is copied verbatim from RetroArch's source - https://github.com/libretro/RetroArch/blob/master/retroarch.cfg - and customized with RetroPie's defaults.

Alturis

@mitu Yeah it appears to be wrong there as well. Are you suggesting I fix that myself in the github project? Happy to but don't want to step on anyone's toes.

mitu

@alturis said in RetroPie 4.7.1: Trouble getting custom_viewport_... settings to work:

Are you suggesting I fix that myself in the github project?

The file is from the upstream Retroarch's repository - you can submit a PR there to have it fixed.