SOLVED: joy2key_sdl.py throwing error

johnodon

Pi Model or other hardware: HP Elitedesk 800 G1
Power Supply used: n/a
RetroPie Version Used : 4.7.15 (376ea035)
Built From: Ubuntu Server 20.04.2 x64
USB Devices connected: Keyboard and mouse
Controller used: Keyboard (for now)
Error messages received: /opt/retropie/supplementary/runcommand/joy2key_sdl.py:513: SyntaxWarning: "is not" with a literal. Did you mean "!="? wrapper_version = '.'.join(str(i) for i in version_info if i is not '')
Verbose log (if relevant): Didn't see any reference in the ES log. The above error is displayed in the gnome terminal window at rom launch.
Guide used: https://retropie.org.uk/docs/Debian/
File: n/a
Emulator: any
Attachment of config files:
How to replicate the problem: Install Ubuntu Server 20.04.2 and install RP per the instructions on the instructions.

Has there been a recent change to the joy2key_sdl.py script? I am now receiving the below error when launch a rom:

/opt/retropie/supplementary/runcommand/joy2key_sdl.py:513: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  wrapper_version = '.'.join(str(i) for i in version_info if i is not '')

John

mitu

@johnodon said in joy2key_sdl.py throwing error:

Has there been a recent change to the joy2key_sdl.py script? I am now receiving the below error when launch a rom:

Yes, this is a new script, that implements joy2key using SDL.

Error messages received: /opt/retropie/supplementary/runcommand/joy2key_sdl.py:513

that's strange, since this line is reached only when debugging is enabled for the script, which shouldn't be by default. I'll see if this pops up when no gamepad is connected.

johnodon

UPDATE: My workaround for the time being is to copy /etc/emulationstation/es_systems.cfg to /opt/retropie/configs/all/emulationstation and pipe runcommand.sh stderr to null:

<command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 _SYS_ arcade %ROM% 2> /dev/null</command>

johnodon

@mitu said in joy2key_sdl.py throwing error:

@johnodon said in joy2key_sdl.py throwing error:

Has there been a recent change to the joy2key_sdl.py script? I am now receiving the below error when launch a rom:

Yes, this is a new script, that implements joy2key using SDL.

Error messages received: /opt/retropie/supplementary/runcommand/joy2key_sdl.py:513

that's strange, since this line is reached only when debugging is enabled for the script, which shouldn't be by default. I'll see if this pops up when no gamepad is connected.

Thanks @mitu. I'm using only a USB KB and mouse right now...no controllers. This is my arcade cab so I will eventually move over to my iPAC4.

mitu

I can't seem to reproduce this - I don't see the warning message. Do you have the runcommand launch menu disabled ?
You can also opt to use the previous joy2key version (udev based) from the runcommand configuration menu.

EDIT: nevermind, I see it now. Some new warning in Python 3.8, which should be easy to fix.

johnodon

@mitu said in joy2key_sdl.py throwing error:

I can't seem to reproduce this - I don't see the warning message. Do you have the runcommand launch menu disabled ?
You can also opt to use the previous joy2key version (udev based) from the runcommand configuration menu.

EDIT: nevermind, I see it now. Some new warning in Python 3.8, which should be easy to fix.

Gracias. Need me to open a GH issue?

mitu

@johnodon said in joy2key_sdl.py throwing error:

Need me to open a GH issue?

Why ? A forum post with an error/warning message is just as good - the problem is understood and a fix is easily attainable.

johnodon

@mitu said in joy2key_sdl.py throwing error:

@johnodon said in joy2key_sdl.py throwing error:

Need me to open a GH issue?

Why ? A forum post with an error/warning message is just as good - the problem is understood and a fix is easily attainable.

OK. I was going to post the issue on GH but it said to post on the forums first. However, I see you already created the PR.

johnodon

Commit https://github.com/RetroPie/RetroPie-Setup/commit/ee74dbdf223f8dd99d5457c4563bd7f92e156ed8 has fixed the issue.

Thanks you @mitu