Skyscraper appends 'T000000' to <releasedate> tag with '--flags unattendskip'

sleve_mcdichael

@muldjord Every time I run Skyscraper in gamelist generation mode with unattendskip (to add new games while preserving custom edits to existing entries that don't port to -s esgamelist, like <sortname>), it appends T000000 to the <releasedate> tag of the existing gamelist entries. Even if it's already there, it gets added again so over time, it ends up like <releasedate>19970303T000000T000000T000000T000000</releasedate> or more, depending on how many times I've re-ran it since the game was first added.

This seems like a bug.

muldjord

@sleve_mcdichael Good catch, I'll look into it.

EDIT: This is now fixed, also works retroactively, so it will remove all but one instances of T000000 from the ES gamelist when regenerating them, including when using --flags unattendskip.

3.6.15 out now, please update and test, thanks!

sleve_mcdichael

@muldjord oh I thought it worked, but I guess only almost. It removes the extras and leaves exactly one T000000, but even if there's already another time stamp. So 19970303T123456 for example, becomes 19970303T123456T000000.

muldjord

@sleve_mcdichael Of course, I forgot the T000000 wasn't just an addition that always had to be there. I'll do it with a regular expression instead, and re-release. Just a sec...

muldjord

@sleve_mcdichael 3.6.15 re-released with a fix now based on regular expression. I've tested in in various ways and it seems to work now. If not, please excuse me, it's a bit late and I need sleep. :D

I can't remember if the RetroPie script allows you to update it if it's the same version, I can't remember. But I didn't want to bump the version again.

mitu

@muldjord said in Skyscraper appends 'T000000' to <releasedate> tag with '--flags unattendskip':

I can't remember if the RetroPie script allows you to update it if it's the same version

You can update/reinstall the same version, in this case a source installation would be required.

sleve_mcdichael

@muldjord said in Skyscraper appends 'T000000' to <releasedate> tag with '--flags unattendskip':

3.6.15 re-released with a fix now based on regular expression. I've tested in in various ways and it seems to work now.

Looks good. I can still break it if I try, by doing weird stuff like:

19970303T12 becomes 19970303T12T000000.

19970303T123456T000000T123456 becomes 19970303T123456T123456.

...but that's me trying to trick it on purpose. For regular use it looks to work fine: the multiple T000000's that got in there automatically, are now automatically removed, date codes with proper 6-digit time stamps are preserved, and ones without are given a single T000000 (which is then preserved.)