RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login
    Please do not post a support request without first reading and following the advice in https://retropie.org.uk/forum/topic/3/read-this-first

    splashscreen.sh "enable/disable" wording

    Scheduled Pinned Locked Moved Help and Support
    splashscreenenablewording
    15 Posts 3 Posters 1.2k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S
      sleve_mcdichael
      last edited by

      @mitu said in splashscreen.sh "enable/disable" wording:

      @sleve_mcdichael You change doesn't reflect the re-wording you had in mind.

      What do you mean?

      9F72751C-1524-4D96-B012-DF5626535CF7.jpeg

      mituM 1 Reply Last reply Reply Quote 0
      • mituM
        mitu Global Moderator @sleve_mcdichael
        last edited by mitu

        @sleve_mcdichael said in splashscreen.sh "enable/disable" wording:

        What do you mean?

        I thought it was missing Enable splashscreen on boot (disabled) when disabled, but it was already there.

        Seems to be ok, but I'd rather not repeat Enabled and use Show splashcreen.

        S 1 Reply Last reply Reply Quote 0
        • S
          sleve_mcdichael @mitu
          last edited by sleve_mcdichael

          @mitu yeah I'm good with "show splashscreen." How about for the randomizer? "Show randomizer" doesn't really fit; how about "toggle"? (Edit: or "use"?)

          mituM 1 Reply Last reply Reply Quote 0
          • mituM
            mitu Global Moderator @sleve_mcdichael
            last edited by

            @sleve_mcdichael said in splashscreen.sh "enable/disable" wording:

            "Show randomizer" doesn't really fit; how about "toggle"? (Edit: or "use"?)

            Randomize image order or Shuffle images ?

            S 1 Reply Last reply Reply Quote 0
            • S
              sleve_mcdichael @mitu
              last edited by sleve_mcdichael

              @mitu I had a few more ideas which turned out to be relatively easy to implement. What do you think of this:

              edit: https://github.com/s1eve-mcdichae1/RetroPie-Setup/commit/7620baa1dcd8226f2998f60c509284f2cb60e892

              mituM 1 Reply Last reply Reply Quote 0
              • mituM
                mitu Global Moderator @sleve_mcdichael
                last edited by

                @sleve_mcdichael said in splashscreen.sh "enable/disable" wording:

                What do you think of this:

                I'd rather have the UI code stay the gui_ function instead of splitting it into separate functions - the actions behind the menu options are simple enough to be added inline in the menu's case handler so that are easy to follow.

                S 1 Reply Last reply Reply Quote 0
                • S
                  sleve_mcdichael @mitu
                  last edited by sleve_mcdichael

                  @mitu said in splashscreen.sh "enable/disable" wording:

                  I'd rather have the UI code stay the gui_ function instead of splitting it into separate functions

                  The randomize_ code was already largely a separate function; I suppose that could all be rolled into gui_ as well, but in either case I feel it's more intuitive to have "disable randomizer" merely as one of the options instead of a separate action that's invoked automatically when it's enabled; for instance it makes changing the source easier, as you no longer have to disable first & then scroll back down & re-enable to change your selection, just enter the menu once and make a different choice.

                  I rolled the other UI stuff back into gui_ though:

                  https://github.com/RetroPie/RetroPie-Setup/compare/master...s1eve-mcdichae1:splashscreen-redux?expand=1

                  1 Reply Last reply Reply Quote 0
                  • mituM
                    mitu Global Moderator
                    last edited by

                    The randomizer change is ok, but the separate sub-menu for enable/disable is redundant - just clicking on the entry should toggle it, like most menus in RetroPie-Setup.

                    S 1 Reply Last reply Reply Quote 0
                    • S
                      sleve_mcdichael @mitu
                      last edited by

                      @mitu said in splashscreen.sh "enable/disable" wording:

                      The randomizer change is ok, but the separate sub-menu for enable/disable is redundant - just clicking on the entry should toggle it, like most menus in RetroPie-Setup.

                      Yeah okay. This had felt clunky to me as a toggle (which is why I changed it to a choice, initially), but I think that by adding "currently:" to the descriptor (á la runcommand configuration) it feels fine now, as a toggle still:

                      https://github.com/RetroPie/RetroPie-Setup/compare/master...s1eve-mcdichae1:splashscreen-three

                      mituM 1 Reply Last reply Reply Quote 1
                      • mituM
                        mitu Global Moderator @sleve_mcdichael
                        last edited by

                        @sleve_mcdichael Looks good !

                        1 Reply Last reply Reply Quote 0
                        • First post
                          Last post

                        Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                        Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.