Video View For All Themes

Nismo

@herb_fargus I can spend some time and update a few themes as well as default "carbon" theme.

But my problem is that I don't know if I'll have time to learn how github works...

I agree with @Zigurana on this:

For me at least, the hierarchy is clear, ES requires a certain xml-version for theme, and it's up to the user to install it.

herb_fargus

@Nismo this is the pending pull request for video view with carbon:

https://github.com/RetroPie/es-theme-carbon/pull/20

Perhaps if I get time after work I'll test out carbon and simple to see the implications of video view

backstander

@Zigurana
I think for users still using the old ES, we need 2 different themes repos. The original one that is non-video and a new one that is video only. We can leave the code the same for the old version of ES to point to the current theme's repo but in the new ES Themes install script we can see both theme repos. Now people using the old ES can install any theme they see (which will be non-video themes) and it won't break anything but people using the new ES will see both repos (video and non-video). If needed in the future, we could faze out the old theme repo.

This is if my understanding is correct that new themes brake old ES and old themes work in new ES.

I hope this make sense :)

Zigurana

@herb_fargus Sorry, but what do you mean?
(My language module is still on xmas break, so I might just be a bit slow.)

Are you suggesting getting rid of some of the tags?

Nismo

@herb_fargus i'll take a look at the pull request and comment here, but in first place i don't see marquees in the code so something is wrong...

Edit: i tested it and of course if you have marquees like me, it are displayed on top of gamelist overwriting the first game in the gamelist, system logos are not displayed in video view, video window it's not on the right place...

jdrassa

@Nismo I submitted the pull request. I purposely left out the marquees because I didn't want to get into adjusting the layout to make space for them. Since I don't have any, I didn't think about where it would place them for users that do. I will double back to hide them and to fix the missing system logos.

I will have to check on the positioning of the video. I tested it on my rpi, but it is possible I messed something up in copying the change back and forth.

Nismo

@jdrassa too late, here is a working fixed carbon theme.. only takes to me 5 min to get it working:

Carbon theme with video support: http://www.mediafire.com/file/f32kjrkeopykjra/carbon_with_video.zip

You need to select where to place marquees so don't overwrite anything else, just because marquees still displaying if they exist even if you don't include the code.

Also inside theme.xml for each system you need to use this to make the logos work:

<view name="basic, detailed, video">

Also the video window was bigger than should be, this is the correct size and place for video and marquees:

 	<view name="video">
 
 		<video name="md_video">
 			<pos>0.763 0.400</pos>
 			<origin>0.5 0.5</origin>
 			<size>0.366 0.436</size>
 			<delay>0.2</delay>
 			<default></default>
 			<showSnapshotNoVideo>true</showSnapshotNoVideo>
 			<showSnapshotDelay>false</showSnapshotDelay>
 		</video>
		
		<image name="md_marquee">
			<pos>0.6 0.035</pos>
			<origin>0 0</origin>
			<maxSize>0.2 0.1</maxSize>
		</image>
 
 	</view>

Unfortunatley I don't know how to add all these commits to github so please somebody do it for me, thx.

@jdrassa It's a nice try, but I think you need to test things a little bit before submit a pull request...
Enjoy.

Zigurana

@backstander I think that maintaining separate theme repos for older versions of ES is a maintenance burden that brings us nothing but hassle.
Why would we need to keep supporting old ES users? And more importantly, for how long? If we want to keep the momentum of ES development going, as small as it is, we should look forward, not backwards.
I agree that backwards compatibility is nice to have, but the current state of ES simply does not allow for much development. Future redesigns might change that, ie. make ES theming a bit more forgiving to the presence of certain tags or not, but we'll have to make breaking changes along the way to get there.

Let's put it differently, why would someone not want to upgrade their ES? If there are relevant issues, those should be adressed.

jdrassa

@Nismo Thanks. I realized right away my mistake with the system logos. I was so focused on testing the video that I hadn't noticed that they were missing. I have added these changes to the pull request.

Nismo

@jdrassa Thanks, I really need to know how to use github but sincerely it's not one of my prioritys.

@robertybob if you need help to add video support to your themes I can help you.

jdrassa

@Nismo it doesn't take long to learn the basics of using github. If you don't want to use the cli, they have a Github Desktop app that is pretty simple to use. If you want help figuring it out, just let me know.

herb_fargus

@Zigurana what I meant by culling is to remove any themes that aren't complete/don't have video view.

I agree the burden of maintenance is too much to maintain two versions of each theme. If it's possible to have backwards compatibility with old themes along with having video mode enabled that would be ideal but I haven't tested enough to know if/how it breaks stuff.

I agree in that the main goal should be looking forward. It may also be possible at some point that grid view is incorporated as well which we will have to go through this process all over again ;)

jdrassa

@herb_fargus looking through the code it looks like the theme will fail to parse when it hits the video element.

One way that we could try to address this would be to have the themes include 2 versions of their core xml file, one that supports video and one that does not. Using carbon as an example. Its root directory would contain carbon.xml which would be the current version and carbon-video.xml which would be the version that supports video.

Then there are a couple of options on how to enable video support. The user could be required to know to go in and swap the files to enable video support. Alternatively, the theme installation script could be updated to do it either automatically, prompt the user if they want to do it, or conditionally based on what version of emulationstation is installed.

herb_fargus

@jdrassa perhaps, it may also be possible to amend the install script to pull from a static commit prior to video mode updates. Might be good to get @BuZz input on what he thinks would be the best approach for it

I know themes are his favourite thing to talk about ;)

backstander

@Zigurana
I'm okay with that!! Personally I'd rather be like Apple and just force everyone to update ;-)

I was just worried about post on the forum from people with old ES doing an update of just Carbon or Pixel and now they got the dreaded "White Screen of Death"!

Nismo

@jdrassa @herb_fargus Having two version of core.xml of a theme it's not possible, just because all themes i've ported to support video need to modify individual theme.xml for each system, even in carbon theme, so you need not only the main.xml, you need as well a theme.xml with video support for each system inside the main theme.

vbs

Just for me to understand it: So latest ES is not compatible with non-video-themes and old ES is not compatible with video-enabled-themes?
Does it mean if I update now my ES to latest version (without updating themes) then it will break?

jdrassa

@Nismo From a backwards compatibility perspective there are 2 things in the theme xml that we have to be concerned about.

The first is the video element itself

<video name="md_video">...</video>

and the second is view elements that specify video in their name attribute

<view name="video">...</view>

I will need to test to verify, but looking through the code it looks like only the video element should be an issue.

You are correct though that this approach would not work for themes that need system specific placement of the video.

Zigurana

@herb_fargus said in Video View For All Themes:

It may also be possible at some point that grid view is incorporated as well which we will have to go through this process all over again ;)

My thoughts exactly.

Nismo

@jdrassa said in Video View For All Themes:

You are correct though that this approach would not work for themes that need system specific placement of the video.

Just like my theme... and you only speaking about video element but not marquee.

I didn't test new theme on old ES anyway...

@vbs Latest ES it's compatible with old themes and new video themes, but old ES isn't compatible with new video themes.