Help testing: Random Video Screensaver on Main Branch

Hex

@pjft is there a way to trigger screensaver or just wait patiently

Hex

On linux Audio starts. Video is a blank screen. and normal video snap is in incorrect position (probably only for testing)

pjft

@Hex you need to choose the random video screensaver option on the menu. If you then enable screensaver controls, you can trigger it by pressing select on the system view.

pjft

@Hex ok. It looks like I'll need to adjust VLC as a screensaver then as it might not be hardware accelerated. That's a shame as the text will look crappy :/ but it is what it is. Thanks for testing that.

What do you mean the video snap is out of place - can you share a screenshot? That would help - I may have certainly unknowingly reverted some code, since this was put together earlier in the year.

I take it it wasn't happening on the public 2.2.0 release?

Thank you very much!

Hex

@pjft said in Help testing: Random Video Screensaver on Main Branch:

@Hex ok. It looks like I'll need to adjust VLC as a screensaver then as it might not be hardware accelerated. That's a shame as the text will look crappy :/ but it is what it is. Thanks for testing that.

What do you mean the video snap is out of place - can you share a screenshot? That would help - I may have certainly unknowingly reverted some code, since this was put together earlier in the year.

I take it it wasn't happening on the public 2.2.0 release?

Thank you very much!

You will have to read the setting to determine which player is being used for videos and switch accordingly.

Imgur

pjft

@Hex oh my, that is messed up. Will look into that - likely some merge problem.

Thanks.

Hex

I works well in Retropie ES master branch so you can look at diffs and figure out

pjft

@Hex yeah, must have messed up something simple on the merge. Thanks!

It's past midnight here, will look into it tomorrow or during the weekend.

TMNTturtlguy

@pjft just an fyi - you do not use .git in @meleu script. for the repository enter:

https://github.com/pjft/EmulationStation

Branch Enter:

RetroPie-ScreenSaver-Merge

meleu

@TMNTturtlguy said in Help testing: Random Video Screensaver on Main Branch:

@pjft just an fyi - you do not use .git in @meleu script.

Hey bro, the script should be smart enough to deal with the trailing .git. I tested here and it works fine with that. Are you having problems?

TMNTturtlguy

@meleu yes I am. I went to add a new repository and typed it in with .git and it said that it was not a proper link to the branch and would not add it to the list. I then typed it in without the .git and it added it to my list. I went to the list, selected it and it started to download/compile.

TMNTturtlguy

@pjft - Tested on retropie and as expected it appears to be working 100% the way it should be. Nice work!

meleu

@TMNTturtlguy said in Help testing: Random Video Screensaver on Main Branch:

@meleu yes I am. I went to add a new repository and typed it in with .git and it said that it was not a proper link to the branch and would not add it to the list.

You are right! Sorry for looking like I'm doubting you. :-)

In my tests I edited es-repos.txt files directly... My bad.

Anyway, the script can deal with trailing .git now. Could you update and test it again, please? (remember: you can update using the script itself).

Thanks bro!

TMNTturtlguy

@meleu I am not on my pi now, but i will update and get back to you! Thanks for taking a second look into it. Really nice utility you build for us.

Hex

@pjft said in Help testing: Random Video Screensaver on Main Branch:

@Hex ok. It looks like I'll need to adjust VLC as a screensaver then as it might not be hardware accelerated. That's a shame as the text will look crappy :/ but it is what it is. Thanks for testing that.

What do you mean the video snap is out of place - can you share a screenshot? That would help - I may have certainly unknowingly reverted some code, since this was put together earlier in the year.

I take it it wasn't happening on the public 2.2.0 release?

Thank you very much!

I am testing on PC. It is still compiling on my PiZ :|

pjft

@Hex Thanks.

Just added some options for Screensaver quality on Linux, hopefully it helps. I wasn't able to test, but do let me know how it goes. It starts as lower quality, so if you use the game name text option, it'll look quite crappy.

As for the video position, you have me stumped - I was looking at the code and didn't see anything particularly different. Will have to look later.

Thanks!

pjft

Small update: VLC isn't yet rendering the screensaver on non Pi systems. I suspect it's related to the z-index changes, I'll need to investigate what needs to be done for that. Sorry.

As for the video location, that's weird. It renders well on the Pi with VLC, and nothing seems to have changed. Did you edit the theme per chance?

TMNTturtlguy

@meleu said in Help testing: Random Video Screensaver on Main Branch:

You are right! Sorry for looking like I'm doubting you. :-)

In my tests I edited es-repos.txt files directly... My bad.

Anyway, the script can deal with trailing .git now. Could you update and test it again, please? (remember: you can update using the script itself).

Thanks bro!

@meleu, I updated the script and this now works correctly. Thanks

Hex

@pjft No, actually the entire setup is the same. I am just running two binaries to compare

pjft

@Hex hm. I might need some help troubleshooting that one then, as it's not happening on the Pi on VLC so I'm a bit at a loss. Is your other binary the 2.2.0 one?

I'll take a look at it later today or during the weekend and see.

Thanks!