EmulationStation Updates and Guide

TMNTturtlguy

@rookervik said in EmulationStation Updates and Guide:

And I have found bugs already in the updates that I am not fond of. One such bug is the resizing of images. I believe it's related to an update that "fixes" proper location of images... while it does this, it does it slowly after the image is already drawn on screen. Making it look like your images are shrinking every time you change to another game. This is almost a game-breaker for me.

I second this, at first i thought it was maybe something with my wheelart, but I have noticed specifically with my wheel art that every time i scroll the next game, wheelart (<md_marquee>) will load and then flash and slightly change sizes and almost adjust location by 1 or 2 pixels. It is pretty annoying, I am not sure when this started, but it was recently.

pjft

@tmntturtlguy said in EmulationStation Updates and Guide:

@rookervik said in EmulationStation Updates and Guide:

And I have found bugs already in the updates that I am not fond of. One such bug is the resizing of images. I believe it's related to an update that "fixes" proper location of images... while it does this, it does it slowly after the image is already drawn on screen. Making it look like your images are shrinking every time you change to another game. This is almost a game-breaker for me.

I second this, at first i thought it was maybe something with my wheelart, but I have noticed specifically with my wheel art that every time i scroll the next game, wheelart (<md_marquee>) will load and then flash and slightly change sizes and almost adjust location by 1 or 2 pixels. It is pretty annoying, I am not sure when this started, but it was recently.

I can't comment on marquees as I don't use them, but the exact same thing has happened since almost forever to the image next to the video in your theme.

Since I had never seen it "not do" that, I just assumed it was a quirk with the image implementation, and didn't bother with it.

But would love to perhaps collate somewhere all the bugs or glitches people have been observing with those, especially when compared to the main branch as some of you are able to do so, so they're easier to track and tackle.

Thanks!

Hex

@Rookervik PR page is definitely the place to checkout the road map.

dankcushions

the image thing is definitely new (as in, sometime this year). i would bisect if had the time.

some summery would be good, and ideally more focused user testing/feedback. there's been a number of features added to es i don't really like (and a number i really do!) but there's so much development it's bit overwhelming to keep up with the threads, etc.

pjft

@dankcushions surely this year is a possibility. There was quite a bit done on that, I wouldn't rule that out.

I can try to bisect it in the coming weeks, if nobody does it before.

dankcushions

@pjft said in EmulationStation Updates and Guide:

@dankcushions surely this year is a possibility. There was quite a bit done on that, I wouldn't rule that out.

i didn't. in fact, i ruled it in :)

cyperghost

@ectoone said in EmulationStation Updates and Guide:

Same here, and for me that is actually a reason NOT to update every so often. I'm quite happy with my current setup and I have that since the themeable carousel was added.

Therefore I've created a collection of precompiled binaries. Sadly I started just this year and so not all versions of ES are included. It also lacks in support of Pi 1 and 0.
You can give it a try and just exchange binaries by downloading them from github

@herb_fargus said in EmulationStation Updates and Guide:

I haven't really been able to keep up with everything as of recent so I don't really even know what's possible at this point [....] I think its fine here as the request is essentially for documentation on how to make themes with the newest changes.

There is a fine tool for adding how-to and every developer can add pages here and descripe the branch. The moderators can add them later to the RP-wiki here

https://github.com/RetroPie/RetroPie-Setup/wiki

I agree for documentation of features and how to use them ....
The presentation that @pjft did for his favorites feature is a good example how it can be written down per wiki-system.

pjft

@cyperghost yeah, I have a backlog of documentation to put together. It's on my list.

TMNTturtlguy

I just want to add that all of your guys work is outstanding! Thanks for all the time and effort.

Rookervik

We also need to be careful when adding these changes to our themes. The new features are not backwards-compatible with previous versions of EmulationStation. Any of these new tricks I've added to my themes will not load on my RetroPie because I have not updated to the newest ES... and frankly, I'd rather not. Not until a couple of annoyances are ironed out. The md_image re-size tweak is quite distracting.

So keep a copy of your themes. Don't blindly update them with the newest features... fork your theme, or you risk cutting off a portion of your audience. Such as me. LOL.

Hex

@Rookervik You can always go back in time on your themes if they dont work. All themes are hosted on github.

so if you want to go back like 5 commits enter this command in your theme dir. Not the one where you are developing the theme

git reset --hart HEAD~5

And vola your theme has gone back in time.

pjft

@rookervik I'll explicitly add @jdrassa and @Zigurana here as I'm under the impression that the reason there are version tags in the theme is exactly so it doesn't break older versions.

That being said, it might certainly depend on "how old" your version is, but they've been around for at least a year if not longer, I believe.

Furthermore, they may have an idea of why or when that image behavior was introduced.

jdrassa

@rookervik said in EmulationStation Updates and Guide:

And I have found bugs already in the updates that I am not fond of.

Please elaborate (either here or in a new thread) on any additional bugs that you have found. We can't do anything to fix them if they are not being reported.

One such bug is the resizing of images. I believe it's related to an update that "fixes" proper location of images... while it does this, it does it slowly after the image is already drawn on screen. Making it look like your images are shrinking every time you change to another game. This is almost a game-breaker for me.

If you or anyone else can provide more detail on this it would be helpful. I just tested (with several themes) it out on my linux desktop and I am not seeing it at all.

But anyway, here is a link to the theme.md. It sure helped me.

Glad to hear you found it helpful. I have made it a point to make sure I update it whenever making a change that effects themes.

@rookervik said in EmulationStation Updates and Guide:

We also need to be careful when adding these changes to our themes. The new features are not backwards-compatible with previous versions of EmulationStation.

For many of the new theme features, there are ways to implement them in a However that is something that we need to do a better job of documenting.

jdrassa

@pjft The version tags in themes act more as a fail safe. For example, if you are running a verison of ES that supports themes up to version of 4, but try to load a theme with a version of 5, ES will immediately throw an error and won't even try to load the theme. In the case where we add a new theme element, but don't increase the version, ES will try to load the theme, but will eventually fail due to an unrecognized theme element. For the user, the end result is the same.

In the work I have done, I have only increased the version when adding variable support, because it felt like it was a bigger change that effected the structure of themes.

pjft

@jdrassa Sound good, wasn't aware of that. Thanks.

As for the image moving, I made a very shoddy video (apologies for the music, I had to remove all the sound from the video and it was easier just to add a song YouTube suggested...).

It is very subtle, but it's noticeable, especially if you put it at 720p, full screen, 0.25x speed. Even though my hand isn't fully stable (sorry), you can easily spot it in the two first images (the two 10 Yard Fight versions) as they're the same size, if you focus on the right edge of the image. It's a split second, but can get annoying.

My bets are that it's related to a rounding thing, or maxsize changes.

See if you can spot it, and if it would ring a bell.

I was also going to mention your disciplined work on Themes.md - it is definitely precious, otherwise this would be hard to keep track of!

I'll make sure to add the collections work to it as well.

Best.

EDIT: it's also easily noticeable in Carbon, if you force it to detailed view rather than automatic or video. It affects the element that corresponds to the image metadata, at least.

AndersHP

@pjft said in EmulationStation Updates and Guide:

Furthermore, I'm working on adding the possibility for users to create their own game collections (which are, in effect, system agnostic collections of games) from within EmulationStation.

Out of curiosity; how's this part of the project holding up? I'm not sleeping until this is incorporated, that's how excited I am :-)

pjft

@andershp it's holding up extremely well. In fact, it's running as well as the current public branch!

(I haven't really managed to start it yet, but I lack other positive ways to describe the lack of progress :) )

AndersHP

@pjft I just tried the ES update, and the favourites function in each system folders are spot on what I searched for. Awesome work!
Is there any way of making EmulationStation keep the "favourites=true" filter on after a reboot?

pjft

@andershp while you wouldn't have that ability, you have a "favorites" system that contains all your favorite games. You will need to enable it in the game collections menu, and you'll never from using a compatible theme.

You can also sort it by system if you'd rather have it instead of by name.

That use case you're aiming for will only be available if/when the kiosk/kids mode features are brought to the main branch, but hopefully these suit for the time being.

AndersHP

@pjft Allright, just wondering. I had a lot of fun yesterday running through roms to pick out my fave's. Still need to finish my scraping on some of my systems, I imagine this has to be done first, since the metadata otherwise will be overwritten, correct?

Anyways, thanks again. Keep up the good work!