Please Test: Creating Custom Collections

pjft

Thanks.

Updated the branch and the binary, so you can re-do the commands to get the latest version.

Fixed the crash you reported, as well as an instance whereby trying to select a random game in an empty collection would - as expected - not behave well :)

Thanks for testing!

HurricaneFan

@pjft Adding and removing works as expected now. Thanks!

On a side note, Can Custom Collections the system be sorted differently in the system view?

Right now, My setup shows Mega Drive, Custom Collections, Nintendo 64. What causes it to display between M and N?

pjft

@hurricanefan the actual name is "my collections", that's why. :)

HurricaneFan

@pjft Ohhhh, and the theme I'm using calls them Custom Collections. Gotcha.

TMNTturtlguy

@pjft Sorry to interject, but tying this into my earlier question about being able to modify the order of the systems......Since this is not in the es_systems.cfg how will this scenario work?

I have a custom es_system.cfg that i organize by game "brand" so i have the following order (not alphabetical)

Arcade
Capcom
NeoGeo
Atari 2600
Atari 7800
NES
SNES
N64
GB
GBC
GBA
NDS
Megadrive
Sega32x
SegaCD
Dreamcast
Gamegear
PSX
PSP
Turbografx
ZxSpectrum

Where would the my custom collections be inserted in this case?
Could we modify the name of the folder to zz my custom collections in order to have this be the last in the alphabetical order?

pjft

@hurricanefan what's the theme? This is very much in the beginning so we might ask the theme makers to change that - either one way or the other.

I agree it's not very consistent, my bad.

pjft

@tmntturtlguy there's two sorting orders. One will sort them all alphabetically with the systems. The other will keep all collections at the end, and won't change the order of the systems.

Edit: that's probably the one you want and the one I use.

HurricaneFan

@pjft I keep all my testing right now with the Art Book theme. I really like how clean that theme is and have been trying to get all my roms into it for testing.

cyperghost

@tmntturtlguy You could extend your es_systems.sh and copy your favourites around. You can also create a "Minimum" theme. You only add "My custom collections"

cyperghost

@pjft I catch still the little bug that the note announces

Your theme dies not support game collections.
Pleasae update your theme, or unsure that you use a theme that contains the folder:

I get the error if I press start > Game Collections and go back with B-button or via Back-menu.

pjft

@cyperghost what theme are you using, what options do you have set, what collections do you have enabled (actual names) and what folders does the theme have?

cyperghost

@pjft
I use IO theme but it also happened to MagazineMadness (and both got the items for all 4 systems)
I have all 3 auto systems enabeld (auto-favorites, auto-allgames, auto-lasplayed)
I have 2 custom collections (testsystem, Beat'em up)

Annother one:
The custom collections show "2 Games available" - I think you can change it via hardcoding to "% Collections available)

Folder are here
IO - https://github.com/mattrixk/es-theme-io
MagazineMadness - https://github.com/RetroHursty69/es-theme-magazinemadness

pjft

@cyperghost can you get me the exact names of the collections you're enabling (maybe from inside the es settings file), the folders in the themes you're using, and the options you have enabled? The reason for that is that the code logic for that warning contains pretty much mostly string comparisons between folder names, and something must be off but I just can't replicate it consistently here. Thank you.

I considered your suggestion on the collections caption, but that would be different to what ES currently does, as even if your system only has folders in the main root path, it still shows the number of games within its entire tree. This way it's showing how many games you have available inside there - and each sub collection has the number of games in the description.

cyperghost

<?xml version="1.0"?>
<bool name="BackgroundJoystickInput" value="false" />
<bool name="CaptionsCompatibility" value="true" />
<bool name="DrawFramerate" value="false" />
<bool name="EnableSounds" value="true" />
<bool name="MoveCarousel" value="true" />
<bool name="ParseGamelistOnly" value="false" />
<bool name="QuickSystemSelect" value="false" />
<bool name="SaveGamelistsOnExit" value="true" />
<bool name="ScrapeRatings" value="true" />
<bool name="ScreenSaverControls" value="true" />
<bool name="ScreenSaverOmxPlayer" value="true" />
<bool name="ShowHelpPrompts" value="true" />
<bool name="SortAllSystems" value="true" />
<bool name="StretchVideoOnScreenSaver" value="false" />
<bool name="UseCustomCollectionsSystem" value="true" />
<bool name="VideoAudio" value="true" />
<bool name="VideoOmxPlayer" value="false" />
<int name="MaxVRAM" value="100" />
<int name="ScraperResizeHeight" value="0" />
<int name="ScraperResizeWidth" value="400" />
<int name="ScreenSaverTime" value="60000" />
<string name="AudioDevice" value="PCM" />
<string name="CollectionSystemsAuto" value="all,favorites,recent" />
<string name="CollectionSystemsCustom" value="Beat â€™em up,testsystem" />
<string name="GamelistViewStyle" value="automatic" />
<string name="OMXAudioDev" value="both" />
<string name="PowerSaverMode" value="default" />
<string name="Scraper" value="TheGamesDB" />
<string name="ScreenSaverBehavior" value="dim" />
<string name="ScreenSaverGameInfo" value="never" />
<string name="ThemeSet" value="io" />
<string name="TransitionStyle" value="instant" />

Got it... it's the unicode value of Beat 'em up!

EDIT:
I renamed to "custom-Beatem up.cfg"
That's it!

Do you may to resolve? I think it does not make sense to load an extra UTF-8 bibliothec into ES if it is not nessecary.

cyperghost

@pjft
I tried to recreate and now it works. Even the entry Beat 'em up stands clear in XML! Don't know why? Where there any changes in code between 0.2 and 0.3 that could make that happen?

pjft

@cyperghost I don't think there were any particular changes. But had you not updated to the latest binary in the recent days? I had done something to tackle that bug, so if you were still on an old binary, that might have been fixed since.

Tell me something, though: does the content of that collection get saved and reloaded correctly? What's the filename in ~/.emulationstation/collections ? And what exactly shows in the settings file now?

I am removing off characters from collection names, so that files can be created without problems (so, no commas, no *, no /, etc). But I may be saving that in the settings file, though. So that's something I need to fix.

cyperghost

@pjft I thought it was solved by the Unicode name. But now it came up again.

EDIT:
Sorry I can't track it again!
Seems to be a random thing!

Seems to happen after fresh reboot. I downloaded from your source 0.3 a few days ago ... Don't know if it's the latest version now. Can you maybe add a version number/text in the Main Menu note?

lvl2: 	EmulationStation - v2.4.1rp, built Jul 27 2017 - 10:32:23

My game collections in folder /opt/retropie/configs/all/emulationstation/collections/ with my two files is:

custom-Beat 'em up.cfg
custom-testsystems.cfg

As you see in es_settings.cfg the unicode character is gone. My es_settings.cfg is:

<?xml version="1.0"?>
<bool name="BackgroundJoystickInput" value="false" />
<bool name="CaptionsCompatibility" value="true" />
<bool name="DrawFramerate" value="false" />
<bool name="EnableSounds" value="true" />
<bool name="MoveCarousel" value="true" />
<bool name="ParseGamelistOnly" value="false" />
<bool name="QuickSystemSelect" value="false" />
<bool name="SaveGamelistsOnExit" value="true" />
<bool name="ScrapeRatings" value="true" />
<bool name="ScreenSaverControls" value="true" />
<bool name="ScreenSaverOmxPlayer" value="true" />
<bool name="ShowHelpPrompts" value="true" />
<bool name="SortAllSystems" value="true" />
<bool name="StretchVideoOnScreenSaver" value="false" />
<bool name="UseCustomCollectionsSystem" value="true" />
<bool name="VideoAudio" value="true" />
<bool name="VideoOmxPlayer" value="false" />
<int name="MaxVRAM" value="100" />
<int name="ScraperResizeHeight" value="0" />
<int name="ScraperResizeWidth" value="400" />
<int name="ScreenSaverTime" value="60000" />
<string name="AudioDevice" value="PCM" />
<string name="CollectionSystemsAuto" value="all,favorites,recent" />
<string name="CollectionSystemsCustom" value="Beat 'em up,testsystem" />
<string name="GamelistViewStyle" value="automatic" />
<string name="OMXAudioDev" value="both" />
<string name="PowerSaverMode" value="default" />
<string name="Scraper" value="TheGamesDB" />
<string name="ScreenSaverBehavior" value="dim" />
<string name="ScreenSaverGameInfo" value="never" />
<string name="ThemeSet" value="io" />
<string name="TransitionStyle" value="instant" />

pjft

@cyperghost yeah, it's very hit and miss. I Sakai have ran into it but can't fully replicate. I might end up getting rid of it, as it seems to be quite annoying. Can you send me the file and folder list for the theme you're using - just ls -l at the theme root folder?

Also, I wonder: how is your collection named with a ' there? I thought I was filtering those characters out these days. Can you create a new one - say, shoot'em up - to test what the file name is, the text in ES, and in the settings?

Thanks. Have a good week.

cyperghost

root of theme

drwxr-xr-x 87 root root 4096 Jul 20 16:04 carbon
drwxr-xr-x 59 root root 4096 Aug 20  2016 eudora
drwxr-xr-x 89 root root 4096 Jul 25 18:17 io
drwxr-xr-x 84 root root 4096 Jul 30 12:45 magazinemadness
drwxr-xr-x 48 root root 4096 Jul 21 11:52 RecalBox
drwxr-xr-x 67 root root 4096 Jul 21 06:14 Retrorama
drwxr-xr-x 75 root root 4096 Jul 20 16:04 simple
drwxr-xr-x 87 root root 4096 Jul  1 09:18 steampunk

inside io
see ghostbin...

Other system I can create later. I created the name "Beat 'em up" through SSH

touch "/opt/retropie/configs/all/emulationstation/collections/custom-Shoot 'em up.cfg"

Inside /opt/retropie/configs/all/emulationstation/collections/ are

-rw-r--r-- 1 pi pi 194 Jul 30 14:01 custom-Beat 'em up.cfg
-rw-r--r-- 1 pi pi   0 Jul 31 05:04 custom-Shoot 'em up.cfg
-rw-r--r-- 1 pi pi  70 Jul 28 20:56 custom-testsystem.cfg

I added one game and made a restart to save to config.file

I have entries

<string name="CollectionSystemsCustom" value="Beat 'em up,Shoot 'em up,testsystem" />

and it seems to work.
I can not catch the bug again.

pjft

@cyperghost said in Please Test: Creating Custom Collections:

I created the name "Beat 'em up" through SSH

Got it.

So, first thing: I am not supporting systems people create via SSH, or manual modifications to the settings file. The reason is that you have added characters that you wouldn't have been able to use if creating the system via ES - in this case, the ' character would not have been created via ES - I was just trying it out and the code was explicitly removing it, so I was puzzled.

In this case, the sorting order of the systems in the config string is also a factor, so manually changing it can cause things like that.

It might be that at some point you made a change via ES and it saved a proper expected config file.

I'll look through the code again and see if there's anything amiss, but other than that for the sake of testing and normal usage, I'd rather stick to testing the use cases from inside ES - creating, naming, saving, etc.

Thanks!