Idea for experimental: Install Arbitrary ES-branch

[TMNTturtlguy]

@pjft said in Idea for experimental: Install Arbitrary ES-branch:

For anyone who wants to use this to help test the OMX integration into the main ES branch (as the more testers, the merrier)

I can test and leave feedback. Looks like this is just a standalone OMX player update, no screensaver?

[pjft]

@TMNTturtlguy correct. That will be stage 2, after this gets approved.

[TMNTturtlguy]

@pjft said in Idea for experimental: Install Arbitrary ES-branch:

For anyone who wants to use this to help test the OMX integration into the main ES branch (as the more testers, the merrier), do use my RetroPie-OMX-Player branch (with https://github.com/pjft/EmulationStationas repository) and leave feedback in the PR:

https://github.com/RetroPie/EmulationStation/pull/135

Thanks in advance for your time, and thanks for putting this together @meleu !

Currently testing this build and when i have screensaver set to black and OMX on, and the screensaver turns on, the video is still playing. The rest of the screen goes black, but the video is on full color and playing. When set to dim, the screen dims and the video stay bright and continues to play.

When the OMX player is turned off, and screensaver is set black, everything turns black and the video stops. When the screensaver is set to dim, everything dims and the video stops.

I am going to go back to your screen saver build and see if the same happens there. I just always have the screen saver video on, so I never looked before.

[pjft]

@TMNTturtlguy no, thanks, well spotted!

As I deliberately left out any code related to the screensaver, it might be that I missed something there - well done!

Let me look into that, no need to waste your time on testing the screensaver build with that. :)

Just to confirm: if it's on VLC, it works as intended, correct?

Thank you!

[TMNTturtlguy]

@pjft correct, VLC works as intended.

Edit: didn't spend time on it, but have the omx-screensaver build running now. The video previews stop and just go black in both dim and black screensaver settings in that build. So in your full screensaver build, it works properly for both vlc and omx.

[pjft]

@TMNTturtlguy Thanks.

Yeah, as I mentioned, the fact that I deliberately split the OMX and screensaver PRs means I missed a few things to make both work together :)

Just updated the branch - if you want to rebuild it, should be good (hopefully). Let me know how it goes.

Also, could you test whether the same texture flashing behavior on zoom happens in this build, though? I can't always replicate it, but wanted to check whether it wasn't happening before the zoom thing was introduced.

Thanks for checking!

[meleu]

@TMNTturtlguy look at the differences on raspi1 overclocked to High:

Enable subtitles while watching the video, I've added some descriptions.

[TMNTturtlguy]

@meleu hey melue, as an FYI i have been running @pjft OMX with screensaver as my build for about 3 months now. I only use the OMX player as it is awesome. I think your video was trying to show me the benefits of OMX? if so I have been on board for a long time! I have been testing a ton of @pjft work over the last few months and he has been incorporating some of my ideas and requests into his work as well. Since i know his build really well i was helping point out a few things that are inconsistent with his full build. He is splitting his build into individual modifications to try to get them to the main branch! Thanks

Edit: by the way this script is so cool i almost want excuses to run it! Type in two lines and hit enter a few times and it is off and running! @Zigurana have you had a chance to try this out yet? Great idea

[TMNTturtlguy]

@pjft said in Idea for experimental: Install Arbitrary ES-branch:

Just updated the branch - if you want to rebuild it, should be good (hopefully). Let me know how it goes.

Also, could you test whether the same texture flashing behavior on zoom happens in this build, though? I can't always replicate it, but wanted to check whether it wasn't happening before the zoom thing was introduced.

Just got back from a work meeting, will update now and try to test before i have to leave again!

EDIT: Ok, so i tested it and it works great now! The screen savers work perfectly in all scenarios and infact the dim setting now pauses the video and dims it! Improvement over the way your screensaver build works!

I also looked at the zoom. When in slide transition and exiting the rom. The screen goes completely black for maybe a half second, and then it zooms out. All of the MD_Data and images are clear and present during the entire zoom. I think that black screen pause allows ES to load the images before the zoom function takes place.

[Hex]

I havent tried it as yet but as an idea if you save the repo as USERNAME/REPO then you can compile it again and again with updates. This is much faster than make clean;make ie downloading and compiling a fresh copy. Only those files that were changed and their dependents are compiled again.

Is this the current behaviour of the script?

[meleu]

@Hex said in Idea for experimental: Install Arbitrary ES-branch:

as an idea if you save the repo as USERNAME/REPO then you can compile it again and again with updates. This is much faster than make clean;make ie downloading and compiling a fresh copy.

Some devs here have more than one branch in the same repo. In the current script you can save the repo url plus the branch.

I'll test your suggestion to avoid compiling everything, if it works as expected it'll be a must have when executing the script on a raspi1 (I compiled @pjft RetroPie-OMX-Player ES branch on my raspi1 and it took more than 4 hours to finish!).

[Hex]

@meleu I am very well aware of the time it takes to compile. Before starting on ES i was working on a bug in DOSBOX and the compile time killed me till I discovered this neat trick to skip make clean.

The bug was that DOSBOX mapper and only the mapper would turn blue

[meleu]

@Zigurana said in Idea for experimental: Install Arbitrary ES-branch:

I was thinking, with the developments for ES picking up speed, it would be nice to a facilitate the testing of development branches.

See if it's close to what you were thinking: https://retropie.org.uk/forum/topic/10626/es-devs-and-testers-this-tool-is-for-you

@TMNTturtlguy said in Idea for experimental: Install Arbitrary ES-branch:

I could have Kids, OMX, Z feature for Themeing and Standard ES all installed, select which one i want to run from the start menu and restart. This may be a dream, but wow how cool would this be.

This is not a dream, it's real! :-)

[TMNTturtlguy]

@meleu you are the best! I will test when I return from my trip!