[Merged] Power Saver feature

Sano

All of them :) (Mame/FBA/NES/SNES/SMS/Megadrive/Ports/Retropie)
I have to press a button (not only the down direction after some tests) for the number of games to appear.

Hex

System as in Pi1/2/3 Linux PC??

Sano

Sorry.
RPi3, retropie 4.2.8, 3A Aukru power supply.

cyperghost

@Hex Okay... That's a point :) So ScreenBurn might be an issue.

Other question. Can you help me out please? I wanted to melt your branch together with @pjft but I wasn't able to do this ... The issue is posted here

I've also uploaded the binary you've provided for RPI1/0 build to my github

https://github.com/crcerror/emulationstation-binary-archive

Hex

@Sano are you compiling the binary?

Sano

@Hex compiled via @meleu script, yes !

Hex

Need testers to update and build to verify all changes. Finally please report any bugs (undocumented behaviour)

Final changes are made:

PS enabled by default
Removed PS enable warning
Works nicely with all screensavers
Gameinfo is shown with PS enabled too
mVersion no longer shows PS state. Restored to default.

cyperghost

@Hex
I've uploaded binary to my github >> https://github.com/crcerror/emulationstation-binary-archive (only PI2/3)

This is an merged version with your and @pjft favorite branch!

sadly it's an older release but it works the same way as @sano got -- CPU load is only 0,3%. Thank you mate. I'm sure this will be implented it's better as my suggestion ... the Standard ES branch still got a CPU load of 3% if Screensaver is enabeld.

Hex

Testers please check if GameInfo (XX Games bar) is properly shown when PS is enabled and all screensavers (video,dim,blank) are properly triggered. Thanks

Sano

@Hex Compiled, tested. GameInfo display is back to normal.
Edit : and the screen just dimmed by itself after screensaver timeout.

cyperghost

@Sano Please set screensaver to 1 min and wait if Dimming, Video and Blank are working
EDIT: Thanks for testing dimming - what about BLANK and Video?

Sano

@cyperghost Black screen is ok too, but this minute is pretty long, I think the timer is buggy.
Currently I don't have any video to test video screensaver.

cyperghost

@Sano Thank you can you make further tests please? It's important to hunt down possible bugs before a merge to the main branch can be done.

Hex

@Sano The minute is correct. I have timed it. It is just counting after some delay which you dont know about. The delay is present to finish any remaining animations and delayed displays like game count extra.

meleu

@felleg said in Testers needed :: Power Saver features :: PR #172:

This is a problem if you want to avoid screen burn-in. I'd much rather have the screensaver be able to start automatically, although, don't get me wrong, being able to start it manually is great in its own right.

I think that playing a video is not a "power saving" action. But now I think I better understood what the @Hex 's change is about.

It seems to be a fix in the logic, and not an addition of a new optional feature.

@Hex am I right saying that?

Hex

@meleu said in Testers needed :: Power Saver features :: PR #172:

.

Yes, It was a logic problem but such things get overlooked quite often. As I said, Aloshi's work might not have been optimized for Pi but it can be.

I agree Video screensaver is not a power saving feature but it is not intended to be. It is for systems that have a constant source of power and hence not battery friendly. But that does not mean that the feature is useless. A lot of effort and time went into making it worthwhile. :)

The option to enable or disable is just for your satisfaction. The functionality is not compromised at all. It just got better at doing nothing :P

meleu

Once you fixed all those "issues" related with screensaver (video/dim/blank), then will it be enabled by default and with no option to toggle it?

Hex

@meleu All bugs are fixed. The option is still there. Do you think the option should not be present?

meleu

@Hex here's my reasoning:

your change does power saving (optimizes the logic).
dim/blank/video screensaver works fine no matter if the PS is enabled (by the way, you should update this info on OP).
there isn't any advantage in leaving PS disabled.

Then here's the big question: Why the heck would anyone leave this option disabled?

If there's no answer for that question, then the conclusion is "leave it always enabled and remove the option to disable it"

Hex

@meleu Okay let me remove the option.

EDIT : Why are you highlighting it?? I wrote a lengthy answer and deleted everything. In short the answer is to disable PS if it misbehaves and yet not be shackled by a broken feature. On the other hand we have lots of Options already so screw it :D