Please Test: Creating Custom Collections

[ruckage]

@pjft said in Please Test: Creating Custom Collections:

@jdrassa -- a bit of feedback there: maybe we should resize the text component depending on the title length, as it's quite common for the text to be appended "(...)" in the carousel as it's too long.

Unsure how to actually do that, but that would be ideal.

That would be ideal, sort of a maxSize setting for text.

[HurricaneFan]

@pjft Dumb question here, Once I'm done adding games to a collection, how do I turn off the Y button add to collection option?

Also, with an unthemed collection, Is there a way to show the collection name instead of "My Collection..." at the top of the screen? I'm using Carbon theme at the moment in my testing.

[pjft]

@hurricanefan Thanks for testing and for the feedback.

A few comments then:

Dumb question here, Once I'm done adding games to a collection, how do I turn off the Y button add to collection option?

That was part of the reason why I didn't want to elaborate on things. Let me just say that "there is a way to do it". Where did you expect to find it, and what did you do? Or, now that you know it's possible, let me know if you can find it.

Don't take this the wrong way - I want to understand what your thought process was, and where you expected to find that. I'm happy to give an answer, but the truth is that most users won't come to the forums, so I want to understand your thought process and see if there's anything I can take from it. :)

As for the collection names, well spotted. My bad. I'll fix it now - that should definitely be the case :) Thanks!

[HurricaneFan]

@pjft I liked the idea that after I created a new collection that I could go and add games to it. Hitting Y button was super easy. Then I was curious what would happen when I had 2 collections. That's when I noticed Y only adds to the latest collection you just created. That's fine in my mind, but at the end of adding games. I'd want to turn off the press Y to add to my last created collection.

I'd imagine I'd turn the setting off in the collections setup menu somehow. Not sure the how or what that looks like. But once my pi is setup with all of the collections I want, I don't want the press Y to add to latest collection enabled because its confusing if you created that collection days or weeks or months ago.

[pjft]

@hurricanefan Correct.

When in any custom collection's gamelist view, if you press select there'll be an option to "Add/Remove Games to This Collection", and (if you're already in the edit mode) an option to exit that mode.

I thought it'd be easier than having to travel back and forth to the Game Collections menu, especially as you may not necessarily complete your collection curation in a single session.

Thoughts?

[HurricaneFan]

@pjft Ahh, found the off setting for Press Y for Finish Editing collection in the SELECT options menu. That was not my first instinct at all to find that setting.

[HurricaneFan]

@pjft Now that I know its there, its easy to use. But all of the collection settings were on the other popup so thats where I kept thinking it should be.

[jdrassa]

@pjft said in Please Test: Creating Custom Collections:

@jdrassa -- a bit of feedback there: maybe we should resize the text component depending on the title length, as it's quite common for the text to be appended "(...)" in the carousel as it's too long.

Currently, when the text logo becomes selected, the font size is scaled up, but the size of the text component itself is not. I have a plan on how to address this. This should at least make it consistent in that if the whole name was shown when the system was unselected, it should still be shown when it is selected. However, depending on the length of the text, it could still be cut off. I am also going to add the ability to set the font size which should help some as well.

[pjft]

@jdrassa thanks. I was thinking of setting text size to (0,0) for the system view logos, and see if that sorted it out. But I imagine it won't be that simple.

Thanks!

[pjft]

Hi all.

This should now be feature complete - so, asides from fixing a few bugs that you found, any unthemed collections will now be grouped under the "My Collections" folder (theme folder: custom-collections), by default. There's an option to show them all the system level as well (you can disable it) should you prefer that. It will use the default theme, then, if present.

There's no option to decide on which individual collections are grouped under the "My Collections" or shown at system level, as that would just add unnecessary complexity. If there's a theme folder, it will be at system level. If not, it depends on whether you chose unthemed collections to be grouped or not. I don't plan on making this more complex.

I also fixed a long-standing bug whereby opening a subfolder wouldn't render the metadata (images, video) of the first item on the list, as it was critical for this to work well.

The binary for a Pi 2/3 can be found here.

You can also compile it from my Custom-Collections branch using @meleu's excellent es-tests tool.

@cyperghost , @mattrixk , @TMNTturtlguy , this should now be ready for your use cases.

Since it wasn't clear from the outset, after adding a new collection you'll be sent straight to that collection's "edit" mode (i.e. adding and removing roms to it), but you can always access it or exit it via the select menu from within the collection's gamelist.

Go forth and break things!

[pjft]

@TMNTturtlguy Apologies, might have missed this somewhere. I think I had posted it somewhere but can't find it.

Your theme folder is currently titled custom-collection, but it should be custom-collections. A small change if possible :)

Thanks!

[TMNTturtlguy]

@pjft The theme has been updated per your request.

[ohmycommodore]

@pjft What needs to be done to install and test this out? I download the binary above, then how to install it? Also, when this gets through beta and is rolled into the main release, will this beta version simply become the final release via updating?

[pjft]

@tmntturtlguy Thanks, it's perfect!

All: I updated the binary to address two small issues that you likely wouldn't experience, but that would misbehave nonetheless. If you had already downloaded the binary, please re-download if possible. They weren't in any way critical - just small edge cases that weren't fully covered.

@ohmycommodore This applies to you, please re-download the binary if you have the chance :)

To install it, you can do the following on your Pi's terminal. First, exit ES, then:

mkdir /home/pi/tmp-es
cd /home/pi/tmp-es
rm emulationstation
wget https://github.com/pjft/EmulationStation/releases/download/0.2/emulationstation
chmod +x emulationstation

At this stage, you can run it from here by typing ./emulationstationbut, as I mentioned earlier, keyboard inputs when running from the terminal may/will be sent to the terminal, so you likely won't be able to name your own collections.

If you'd want to replace your version of ES, continue with the following commands:

cd /opt/retropie/supplementary/emulationstation
sudo cp /home/pi/tmp-es/emulationstation /opt/retropie/supplementary/emulationstation

and then reboot.

If you want to revert to the main ES version, just install from binary, from RetroPie-Setup.

And yes, when this makes it into the main branch, updating ES from RetroPie-Setup will replace this version.

But for that to happen, we need a lot of people to test this to make sure it's all sound. :)

Also, remember to use a compatible theme for best performance - refer to this excellent thread maintained by @cyperghost .

Thanks!

[HurricaneFan]

@pjft In the new Custom Collections section that has a list of each collection, can that be themed? Right now I don't see much when testing it using the Art Book theme.

[TMNTturtlguy]

@hurricanefan see this post for a list of themes that have the custom-collections system theme as well as the default system theme. link

[pjft]

@hurricanefan That does seem to be the theme for that system/section.

Those folders aren't meant to have any metadata other than the name. The fact that those folders do not have metadata means they show up as empty elements - same as if you had a system with folders.

If you use another theme (try ComicBook, for instance) you'll see what I mean, for the time being.

[pjft]

I could try (no promises) to make them adopt the metadata of one of the games within. Perhaps the first on the list. Just so that's not as barebones.

EDIT: My concern is that then people ask why is it claiming to have the wrong genre/stars/player number/video/image/whatever to what they expect. Thoughts or comments? I could make it random each session, but the problem still holds.

I'm not sure whether this is something worth investing in at the moment, but open to feedback on any of these options.

[HurricaneFan]

@pjft Let me test with ComicBook to see the difference.

[pjft]

@hurricanefan or maximuspie, that's also a good one.