Please Test: Creating Custom Collections

pjft

@cyperghost can you send me a video from a phone or something?

cyperghost

@pjft
I think I can ... what is curious!
If I'm in the SNES/Custom-Collection thing move up I can select different games!
Even if there is only the system testsystemsis displayed.

X for random also works! So it's just a small issue I think! Wait one hour please, okay?

HurricaneFan

@cyperghost, @pjft I see the snes bug too. Super weird. If I am in gamelist view and go from Sega CD to SNES which is next system in my list, it triggers the Custom Collections view but I hear the video playing for the snes games, even though I don't see any of the details of snes game.

pjft

@hurricanefan @cyperghost got it. No need for video now.

This was not the bug I had ran into earlier :)

Thanks.

pjft

@cyperghost A question, though: what do you mean "it's even worse"?

cyperghost

@pjft Well in version 0.2 the SNESbug was 100% triggered to custom-collections so I could navigate through the collection.

In version 0.3 I can see the custom-collections only but I can select any SNES Rom blindly. Or press X for random selection :)

Just for fun!
New feature: This is real random you don't see the game you selected until it's loaded

HurricaneFan

@cyperghost @pjft I was able to blindly select an snes game in 0.2 and 0.3. That wasn't new to me.

pjft

@HurricaneFan Correct: 0.2 and 0.3 were when I added the "My Collections" bit.

@cyperghost and @HurricaneFan - ~~I think I've fixed it for good. Updated the same binary (my repository isn't updated yet, so don't try to compile).~~

~~There may be a few extra log messages on the terminal, which I used to troubleshoot this, but I'll remove them tomorrow when I tidy up the build, if you confirm it's sorted.~~

Nevermind. I fixed it partially, but at least now I know what's happening.

Thank you both!

Let me know if there's any other issue for the time being, and @HurricaneFan let me know if the Custom Collections metadata works for you.

I'll fix it tomorrow and report.

cyperghost

@HurricaneFan My investigation wasn't so deep :)
@pjft Sort If I use custom system and collections OFF
then the bug is gone - even on restart :)

I think it isn't a great bug.

Annother little misbehaviour:
ES tells me that my theme is still not ready for the 3 auto-system and the 1 custom-collections. I think that isn't as intended to work. Because I use IO theme and it shows all 4 systems as well.

@pjft My deepest respect for your hard work!

pjft

@cyperghost Yeah, it only happens if you sort things. I'll fix it tomorrow.

I also ran into the false warning, need to check why that happened.

Thanks both!

cyperghost

@pjft Thanks mate.
Do some testing with some new ICs now :)
I'm always ready to test your builds

HurricaneFan

@pjft The metadata for custom collections worked for me. Thanks!

HurricaneFan

@pjft What do you think about putting a game count at the end of the Collection name in the Custom Collections screen?

Mega Man (5)
Super Mario Bos (6)
etc

pjft

@hurricanefan I considered that briefly, but decided to add the info to the description. It's somewhat hacky to add the number to the name, I'm not thrilled on making that a standard. :/

What use case are you trying to solve?

pjft

Good morning/afternoon!

Updated the binary again - and the GitHub branch now - with the latest code then.

It should fix the SNES-thing you had picked up on, which I hadn't noticed earlier. Well spotted.

It should also fix a few minor things here and there, so functionally it should be close to final.

I'll leave it for you all to play with (I will as well), and after that I will likely try to clean up the code as I'm not that happy with it at the moment.

Thanks all.

HurricaneFan

@pjft I totally missed the description count you added when you brought over the game metadata to the custom collection section. Thats good enough for me. My logic was the Custom Collection looks like a game but technically its a list of games but to the user, the game list has a single game name like "Mega Man" but technically its a list of Mega Man games if they user clicks 'A' button. So having total game count next to Mega Man would help spell that out that they aren't selecting a game from that initial Collection list.

Tested the new binary this morning and the SNES bug is indeed gone. Thanks!

pjft

@hurricanefan I see.

That's probably more of a ES-wide question which is that folders aren't that distinguishable from files, perhaps? I thing those colours are themable - or at least slightly different though?

Either way, got it. Thanks.

I'm not going to change within the scope of this particular change, though. Hopefully the notion that those are collections (under "My Collections") will be reasonable and/or sufficient. :)

Let me know if you run into something more in the coming days, but otherwise I hope it's useful and helpful! Thanks for the feedback, as it certainly made this better than what would have otherwise been.

HurricaneFan

@pjft Thanks for all your hard work in this feature!

dmmarti

@pjft - updated to the latest binary ... so far its working great.

Thank you for all of your hard work on this. This is an awesome feature for sure!

pjft

@dmmarti @HurricaneFan Thanks all. As long as it's useful, that's all that matters.

I'll now spend a few days making the code more elegant before actually submitting the PR, but if any other bugs and such crop up, do let me know, and I'll gladly try to tackle them.

@dmmarti - may I add your nice video to the first post here? I wanted to create one as well, but spent most of my free time on the code :|

Thanks!