OpenBOR finally working fine on RETROPIE with ES

cyperghost

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@zanac said in OpenBOR finally working fine on RETROPIE with ES:

yes is that, the "engine" directory: https://github.com/DCurrent/openbor/tree/master/engine

Your zip file doesn't have the structure from the repository you linked - it's missing a lot of folders - and - at least - the README and LICENSE files are not the same. Did you use another revision/branch of the official repo ?

Edit

Read your edit ... Understood

mitu

@cyperghost No, I'm trying to find the originating repo in order to be able to produce a patch - if need to be. I mentioned the LICENCE file because it has the copyright years.

Official OpenBor has

Copyright (c) 2003, Roel van Mastbergen & Senile Team
Copyright (c) 2004 - 2018, OpenBOR Team

The source linked by @zanac has

Copyright (c) 2003, Roel van Mastbergen
Copyright (c) 2011,2012 rofl0r
All rights reserved.

From the looks of the archive, the source modified by @zanac looks to be based on https://github.com/rofl0r/openbor, which is exactly the version available now in RetroPie.

zanac

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@cyperghost No, I'm trying to find the originating repo in order to be able to produce a patch - if need to be. I mentioned the LICENCE file because it has the copyright years.

Official OpenBor has

Copyright (c) 2003, Roel van Mastbergen & Senile Team
Copyright (c) 2004 - 2018, OpenBOR Team

The source linked by @zanac has

Copyright (c) 2003, Roel van Mastbergen
Copyright (c) 2011,2012 rofl0r
All rights reserved.

From the looks of the archive, the source modified by @zanac looks to be based on https://github.com/rofl0r/openbor, which is exactly the version available now in RetroPie.

hei, you get the "old engine", you must get the "openbor-engine-gl.tar.gz"

cyperghost

@mitu no the LICENSE file inside dir engine-gl looks like the official

mitu

@cyperghost @zanac Eh, downloaded both, only unzipped the 1st one. Sorry for the confusion :).

zanac

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@cyperghost @zanac Eh, downloaded both, only unzipped the 1st one. Sorry for the confusion :).

never mind, sorry for the confusion of that repo, i have not time to make a good work :(
I trust that anyway now that i have shown how to make openbor compatible that will help official retropie ;)

cyperghost

@mitu no problem brother
I stay to my first opinion ... It is an unofficial port but seems maintainable

Edit
About the old 3600 port made by rofl0r ...
This is even better than the one we are using now
It has PAK support and the load and save feature is working.

But we should maintain 6k branch

@zanac Thanks for your efforts to let RetroPie run a more advanced OpenBOR engine
@BiZzAr721 thanks for testing

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@mitu no problem brother
I stay to my first opinion ... It is an unofficial port but seems maintainable

Edit
About the old 3600 port made by rofl0r ...
This is even better than the one we are using now
It has PAK support and the load and save feature is working.

But we should maintain 6k branch

@zanac Thanks for your efforts to let RetroPie run a more advanced OpenBOR engine
@BiZzAr721 thanks for testing

please note that in my "retropan" (that is a fork of retropie but for allwinner board), i choosed to have both version, the "old engine" and the "new engine", both are needed to support all games! Some games need old engine... this is the reason why in my git i put both!!!
I have a script that chose a binary or the other reading the version of the game put in the pak name.

Anyway this is not the first time that i contributed to retropie actually, i made also some patched for emulation station, if i find patch in retropan that can be useful for retropie i always prefer to merge in retropie :)

cyperghost

@zanac This is no problem!
In Retropie you can select preferred emulator
So we add both binaries and the user can choose working one.

Like here in my modified script module for open or line48
https://github.com/crcerror/RetroPie-OpenBOR-scripts/blob/master/openbor.sh

So you write openbor-3600 and launch 3600 binary
The openbor call vor newst engine looks like the one posted
So RetroPie is prepared

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@zanac This is no problem!
In Retropie you can select preferred emulator
So we add both binaries and the user can choose working one.

Like here in my modified script module for open or line48
https://github.com/crcerror/RetroPie-OpenBOR-scripts/blob/master/openbor.sh

So you write openbor-3600 and launch 3600 binary
The openbor call vor newst engine looks like the one posted
So RetroPie is prepared

retropan is not so much cool :)
I suggest you to clean the script now that both engine support pak ;)

cyperghost

@zanac yes that was one of the reasons I entered openbor. The use of runcommand script offers solid usage of all these emulators. Man I love it if my plans are working ;)

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@zanac yes that was one of the reasons I entered openbor. The use of runcommand script offers solid usage of all these emulators. Man I love it if my plans are working ;)
yes, you really do a cool work!

I see that sources point to https://github.com/darknior/openbor, i know that i have already said this, but please note that you will need two version of openbor, the "old engine" and the "new engine"....

Great games like "saint seiya" run only on old engine, openbor is not an emulator that will be proud of retro-compatibility, so in the future i think that we will have also more than two version :(

cyperghost

@zanac No line 48 and 49 sets preconfigured calls to a binary.

So we make following
At first we compile the two binaries
The old engine is named openbor-3600
The new engine is named just openbor

Now we write script module that compiles the two binaries and set up entries for openbor engine choice like this

# call for new engine rev 6250
addPort "$md_id" "openbor" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR %ROM%; popd"

# call for old engine rev 3600
addPort "$md_id-3600" "openbor" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR3600 %ROM%; popd"

Now the user can choose inside the runcommand configuration menu which pak file to load with specific openbor engine revision.

Got me now? I am writing from a tablet ;)

Edit: changed script module routine to add 2 systems in emulator.cfg

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@zanac No line 48 and 49 sets preconfigured calls to a binary.

So we make following
At first we compile the two binaries
The old engine is named openbor-3600
The new engine is named just openbor

Now we write script module that compiles the two binaries and set up entries for openbor engine choice like this
# call for new engine rev 6250
addPort "$md_id" "openbor" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR %ROM%; popd"

# call for old engine rev 3600
addPort "$md_id" "openbor-3600" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR3600 %ROM%; popd"
Now the user can choose inside the runcommand configuration menu which pak file to load with specific openbor engine revision.

Got me now? I am writing from a tablet ;)

Yes, that's all right.

BiZzAr721

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

Man I love it if my plans are working ;)

Yes they are!

darknior

@cyperghost Excellent i love the idea :)

You are right, use the old 3600 port made by @rofl0r with save support and add it my command line trick if you don't already do it.
And the last OpenBOR port to use the last excellent games :)
I can't dream better solution to finally use OpenBOR on Retropie :)

When do you will release a package to try this stuff ?
Or will you add it to the official Retropie SETUP script fo all the users ?

cyperghost

@darknior welcome back!
I can write that script module indeed but I am currently on holidays till the next week.
Maybe a more advanced user like @psyke83 can take action and write that module quickly. Before doing this we may tweak the video resolution in newest openbor.

But I indeed think we should use both binaries. Rofl0rs old one with pak and save support and the newest branch brewed by @zanac

His github resp is located here
https://github.com/zanac/OpenPB4/tree/master/openbor

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@darknior welcome back!
I can write that script module indeed but I am currently on holidays till the next week.
Maybe a more advanced user like @psyke83 can take action and write that module quickly. Before doing this we may tweak the video resolution in newest openbor.

But I indeed think we should use both binaries. Rofl0rs old one with pak and save support and the newest branch brewed by @zanac

His github resp is located here
https://github.com/zanac/OpenPB4/tree/master/openbor

in the new fork if you can try to investigate why it work only when i force a low resolution (actually i forced 384x224).... the clean way is to remove all "bad code" that i used to force lowres ;) As i said i don't own a rasbperry to try what happens... i used 384x224 'cause this is the resolution that is used in Pandora-Allwinner (the board that i use), but it's not the right thing in rasbperry ;)

Let me know if you discover this mistery, i'm very interested in for my knowledge :)

OpenBOR is missing a command line interface, a good program should implement something like....

--help
--width x
--height h
--pak /path/to/file.pak

if someone of you implement argc/argv command line in this way i think that it's the best solution to solve all problem for rasbperry but also for my crap allwinner, 'cause i can remove from my fork the 384x224 hack :)

cyperghost

@zanac see the hardcoding done in openbor.c
Maybe I can investigate

I found something.
If videomode declaration in pak file does not hit any default mode then debug video mode 255 will be used. This automatically calculates resolution. But I don't not know the source. SDL screen output maybe?

BiZzAr721

Hey @cyperghost We're all most grateful for your contributions - you go enjoy your ~~vacation~~ holiday and we'll look forward to your work on your return =p