OpenBOR finally working fine on RETROPIE with ES

zanac

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@zanac said in OpenBOR finally working fine on RETROPIE with ES:

This source tree is rather similar to the official

Which repository is that ?

is the "unofficial" retropie for allwinner, is not well organized... i "dump" in that git all stuff that work in allwinner board :)

mitu

@zanac said in OpenBOR finally working fine on RETROPIE with ES:

is the "unofficial" retropie for allwinner, is not well organized... i "dump" in that git all stuff that work in allwinner board :)

No, I mean the source tree you cloned and then applied your modifications. Doesn't look like the official OpenBOR repo at https://github.com/DCurrent/openbor.

zanac

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@zanac said in OpenBOR finally working fine on RETROPIE with ES:

is the "unofficial" retropie for allwinner, is not well organized... i "dump" in that git all stuff that work in allwinner board :)

No, I mean the source tree you cloned and then applied your modifications. Doesn't look like the official OpenBOR repo at https://github.com/DCurrent/openbor.

yes is that, the "engine" directory: https://github.com/DCurrent/openbor/tree/master/engine

mitu

@zanac said in OpenBOR finally working fine on RETROPIE with ES:

yes is that, the "engine" directory: https://github.com/DCurrent/openbor/tree/master/engine

Your zip file doesn't have the structure from the repository you linked - it's missing a lot of folders - and - at least - the README and LICENSE files are not the same. Did you use another revision/branch of the official repo ?

cyperghost

@zanac yes I see ... It is close to the official ones.
@mitu I understand your concerns but at my first look there are changes done in SDL directory. I think it can be related as a unofficial port that could be maintained. Or do you have other concerns? License issues?

cyperghost

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@zanac said in OpenBOR finally working fine on RETROPIE with ES:

yes is that, the "engine" directory: https://github.com/DCurrent/openbor/tree/master/engine

Your zip file doesn't have the structure from the repository you linked - it's missing a lot of folders - and - at least - the README and LICENSE files are not the same. Did you use another revision/branch of the official repo ?

Edit

Read your edit ... Understood

mitu

@cyperghost No, I'm trying to find the originating repo in order to be able to produce a patch - if need to be. I mentioned the LICENCE file because it has the copyright years.

Official OpenBor has

Copyright (c) 2003, Roel van Mastbergen & Senile Team
Copyright (c) 2004 - 2018, OpenBOR Team

The source linked by @zanac has

Copyright (c) 2003, Roel van Mastbergen
Copyright (c) 2011,2012 rofl0r
All rights reserved.

From the looks of the archive, the source modified by @zanac looks to be based on https://github.com/rofl0r/openbor, which is exactly the version available now in RetroPie.

zanac

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@cyperghost No, I'm trying to find the originating repo in order to be able to produce a patch - if need to be. I mentioned the LICENCE file because it has the copyright years.

Official OpenBor has

Copyright (c) 2003, Roel van Mastbergen & Senile Team
Copyright (c) 2004 - 2018, OpenBOR Team

The source linked by @zanac has

Copyright (c) 2003, Roel van Mastbergen
Copyright (c) 2011,2012 rofl0r
All rights reserved.

From the looks of the archive, the source modified by @zanac looks to be based on https://github.com/rofl0r/openbor, which is exactly the version available now in RetroPie.

hei, you get the "old engine", you must get the "openbor-engine-gl.tar.gz"

cyperghost

@mitu no the LICENSE file inside dir engine-gl looks like the official

mitu

@cyperghost @zanac Eh, downloaded both, only unzipped the 1st one. Sorry for the confusion :).

zanac

@mitu said in OpenBOR finally working fine on RETROPIE with ES:

@cyperghost @zanac Eh, downloaded both, only unzipped the 1st one. Sorry for the confusion :).

never mind, sorry for the confusion of that repo, i have not time to make a good work :(
I trust that anyway now that i have shown how to make openbor compatible that will help official retropie ;)

cyperghost

@mitu no problem brother
I stay to my first opinion ... It is an unofficial port but seems maintainable

Edit
About the old 3600 port made by rofl0r ...
This is even better than the one we are using now
It has PAK support and the load and save feature is working.

But we should maintain 6k branch

@zanac Thanks for your efforts to let RetroPie run a more advanced OpenBOR engine
@BiZzAr721 thanks for testing

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@mitu no problem brother
I stay to my first opinion ... It is an unofficial port but seems maintainable

Edit
About the old 3600 port made by rofl0r ...
This is even better than the one we are using now
It has PAK support and the load and save feature is working.

But we should maintain 6k branch

@zanac Thanks for your efforts to let RetroPie run a more advanced OpenBOR engine
@BiZzAr721 thanks for testing

please note that in my "retropan" (that is a fork of retropie but for allwinner board), i choosed to have both version, the "old engine" and the "new engine", both are needed to support all games! Some games need old engine... this is the reason why in my git i put both!!!
I have a script that chose a binary or the other reading the version of the game put in the pak name.

Anyway this is not the first time that i contributed to retropie actually, i made also some patched for emulation station, if i find patch in retropan that can be useful for retropie i always prefer to merge in retropie :)

cyperghost

@zanac This is no problem!
In Retropie you can select preferred emulator
So we add both binaries and the user can choose working one.

Like here in my modified script module for open or line48
https://github.com/crcerror/RetroPie-OpenBOR-scripts/blob/master/openbor.sh

So you write openbor-3600 and launch 3600 binary
The openbor call vor newst engine looks like the one posted
So RetroPie is prepared

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@zanac This is no problem!
In Retropie you can select preferred emulator
So we add both binaries and the user can choose working one.

Like here in my modified script module for open or line48
https://github.com/crcerror/RetroPie-OpenBOR-scripts/blob/master/openbor.sh

So you write openbor-3600 and launch 3600 binary
The openbor call vor newst engine looks like the one posted
So RetroPie is prepared

retropan is not so much cool :)
I suggest you to clean the script now that both engine support pak ;)

cyperghost

@zanac yes that was one of the reasons I entered openbor. The use of runcommand script offers solid usage of all these emulators. Man I love it if my plans are working ;)

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@zanac yes that was one of the reasons I entered openbor. The use of runcommand script offers solid usage of all these emulators. Man I love it if my plans are working ;)
yes, you really do a cool work!

I see that sources point to https://github.com/darknior/openbor, i know that i have already said this, but please note that you will need two version of openbor, the "old engine" and the "new engine"....

Great games like "saint seiya" run only on old engine, openbor is not an emulator that will be proud of retro-compatibility, so in the future i think that we will have also more than two version :(

cyperghost

@zanac No line 48 and 49 sets preconfigured calls to a binary.

So we make following
At first we compile the two binaries
The old engine is named openbor-3600
The new engine is named just openbor

Now we write script module that compiles the two binaries and set up entries for openbor engine choice like this

# call for new engine rev 6250
addPort "$md_id" "openbor" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR %ROM%; popd"

# call for old engine rev 3600
addPort "$md_id-3600" "openbor" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR3600 %ROM%; popd"

Now the user can choose inside the runcommand configuration menu which pak file to load with specific openbor engine revision.

Got me now? I am writing from a tablet ;)

Edit: changed script module routine to add 2 systems in emulator.cfg

zanac

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

@zanac No line 48 and 49 sets preconfigured calls to a binary.

So we make following
At first we compile the two binaries
The old engine is named openbor-3600
The new engine is named just openbor

Now we write script module that compiles the two binaries and set up entries for openbor engine choice like this
# call for new engine rev 6250
addPort "$md_id" "openbor" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR %ROM%; popd"

# call for old engine rev 3600
addPort "$md_id" "openbor-3600" "OpenBOR - Beats of Rage Engine" "pushd $md_inst; $md_inst/OpenBOR3600 %ROM%; popd"
Now the user can choose inside the runcommand configuration menu which pak file to load with specific openbor engine revision.

Got me now? I am writing from a tablet ;)

Yes, that's all right.

BiZzAr721

@cyperghost said in OpenBOR finally working fine on RETROPIE with ES:

Man I love it if my plans are working ;)

Yes they are!