Crash: Removing favourite

steeeb

I will hopefully be able to do this tomorrow :)

pjft

@steeeb thank you very much, and feel free to decline should it prove to be too time consuming. Sorry for the hassle.

Srdrgz

@pjft
I am having the exact same problem. I also have the latest version of retropie / emulation station ect.

pjft

@srdrgz Thanks.

Just to confirm, is it really only for the last item (i.e. when the list becomes empty)?

Can you confirm whether that happens whether you remove it from within the "Favorites" collection and from the original game system as well?

@steeeb I've seen reports of this also happening in 2.6.5, so it might be that those bisect instructions that I provided have a flawed assumption.

Srdrgz

@pjft
Yes, only when the last item is removed.
It crashes when the last favorite item is removed from the favorites folder, the last played folder, or the main game folder.

In addition to that, when emulation station crashes, the keyboard no longer works. Also, upon a hard reboot, the favorites folders repopulates the games previously removed.

mitu

@pjft So I took your advice and started bisecting, this is what the git bisect log shows

  git bisect start
  # bad: [f35769de6bebea0df03d6621967a03dd814f18e5] bump version to v2.7.3
  git bisect bad f35769de6bebea0df03d6621967a03dd814f18e5
  # good: [8e7ee6c93190bc8ca1879f3877184cffff530496] bump version to 2.6.3
  git bisect good 8e7ee6c93190bc8ca1879f3877184cffff530496
  # bad: [cfdc7c4b679ba4f785498ca83ec80bea03c4d732] Merge pull request #277 from tomaz82/headerGuards
  git bisect bad cfdc7c4b679ba4f785498ca83ec80bea03c4d732
  # bad: [f883a0b0f2cd5bc7c06da79fa06a93532c75791d] Merge pull request #267 from tomaz82/fixSwapInterval
  git bisect bad f883a0b0f2cd5bc7c06da79fa06a93532c75791d
  # good: [5f7aec71dc0ff194d07c6d63bd28b8fb7d7b1e01] Merge pull request #256 from jrassa/default-image
  git bisect good 5f7aec71dc0ff194d07c6d63bd28b8fb7d7b1e01
  # good: [3f515041df1eb53e71fdc16e7bde72761ac8e7a8] Merge pull request #259 from tomaz82/FreeImage
  git bisect good 3f515041df1eb53e71fdc16e7bde72761ac8e7a8
  # bad: [cd2f2ee42b911711db6bd6e0276bea494a389e88] Use local game art ( image, marquee and video ) from romfolder/images if the gamelist didn't specify a path
  git bisect bad cd2f2ee42b911711db6bd6e0276bea494a389e88
  # bad: [06d38db73b69c38a289ba426676dbe4df97a5855] Merge pull request #260 from zigurana/fixBuildWarnings
  git bisect bad 06d38db73b69c38a289ba426676dbe4df97a5855
  # bad: [fd40e84ba54a28e4749c653bca72880802ce04aa] Fix build warnings (mostly adding explicit type casting)
  git bisect bad fd40e84ba54a28e4749c653bca72880802ce04aa
  # first bad commit: [fd40e84ba54a28e4749c653bca72880802ce04aa] Fix build warnings (mostly adding explicit type casting)

It looks strange, since the - seemingly - offending commit only has small fixes and doesn't alter any core behaviour. If you could test this to confirm, that would be good. Currently I'm building the previous commit to see if the problem goes away.

Srdrgz

@pjft said in Crash: Removing favourite:

@steeeb I've seen reports of this also happening in 2.6.5, so it might be that those bisect instructions that I provided have a flawed assumption.

Did u happen to read what pjft posted regarding his bisect instructions...

pjft

@mitu thank you for taking the time and sorry for making you go through that!

I happened to take a look at it this afternoon and submitted a fix for it. It's been accepted in the development branch.

If you're curious about what happened, you can read here:

https://github.com/RetroPie/EmulationStation/pull/323

Sorry for the trouble. There's still a minor outstanding issue regarding ES not showing empty collections on startup, which cropped up in some recent changes, but I'm also looking through that.

In the meantime if per chance you have a collection that's empty and doesn't show after you add something to it, either restart ES or change the collections settings so it refreshes them.

Sorry about the inconvenience!

mitu

@pjft Great - thank you for the fix !

pjft

@mitu not a problem. If anyone wants to test that out though, by all means. It'd be nice to confirm it's fixed:)

Srdrgz

@pjft

I tested your fix and can confirm that it does work. ES no longer crashes when removing the last favorite game. It works in all situations ie: favorites menu, last played menu, emulator menu.

Thank you, much appreciated.

mitu

@pjft Yep, it works - compiled the latest from master and doesn't crash anymore.I can go back to getting beaten by Ghosts 'n Goblins now.

dylosaur

@mitu Sorry to be a bother, but I'm having this same problem and found your thread. I'm new to this so I wasn't exactly sure how I would go about fixing the problem? What's this about compiling from master? I updated from source today but it didn't fix the problem. Thanks in advance.

BuZz

@dylosaur it should be fixed in the latest binaries built earlier.

mitu

@buzz I updated ES from binary, but I still get the crash when removing the last favorite. Maybe the re-built is still from stable branch, where the fix might not be applied.

dylosaur

@buzz Yeah, I updated from the binaries and the crash is still occurring unfortunately.

BuZz

@mitu I think I may have forgotten to push the branch back to github. I am rebuilding binaries now (or try to build from source and see if that sorts it).

dylosaur

@buzz Just updated from source and can confirm that it worked. Thanks for the fix!