Runcommand launch images automatically chosen for ROM-specific emulatorchoices

meleu

compliments

Any One Piece fan here? :)

I would like to know if it works for what you want @AndersHP

Have a nice day fellows!

AndersHP

Hmm.. nothing shows, just the run command menu. Tried copying one of my launching images to the arcade config folder, and that showed fine.

Could it be because my roms are run from USB?

meleu

@andershp please, give me the output of these commands (paste on http://dumptext.com/):

ls -l /opt/retropie/configs/mame/launching.*
ls -l /opt/retropie/configs/fba/launching.*
ls -l /home/pi/RetroPie/roms/arcade/images/

And just for checking:

cat /opt/retropie/configs/all/runcommand-onstart.sh

AndersHP

There's no folder called "mame". It's either mame-advmame og mame-libretro.
Sorry, this is probably me not being specific enough. The 3 types in my arcade folder is fba, mame2003 and advmame.

the fba related line returns this:

-rw-r--r-- 1 pi pi 548406 Jan 11 20:24 /opt/retropie/configs/fba/launching.png

I have no images folder in the arcade folder. Should the three corresponding system images be placed in there?

When typing the last line I can confirm that your code is there. Do you want me to SSH into the pi and get the code, or I guess the above things are the reason for my issues..

meleu

@andershp hey, are you still interested in this stuff?

I've made some changes on the script, taking care of those different mame system folders, and maybe it can work now. Again: I didn't test it on an actual RetroPie.

If you wanna give this another try, Just remove from your runcommand-onstart.sh my previous code you added a few days ago (or delete the file if you had nothing there before).

And then try again the same steps I mentioned on a previous post:
https://retropie.org.uk/forum/post/126827

AndersHP

@meleu said in Runcommand launch images automatically chosen for ROM-specific emulatorchoices:

@andershp hey, are you still interested in this stuff?

What do you mean? Of course!

Cool, will try it again and post back here :)

AndersHP

@meleu I just tested, and nothing changed... Still not working.
The script is 3.750 kb, is this the new version?

AndersHP

@meleu ?

meleu

@andershp I'll be able to code and test my code on a real RetroPie system in a couple of days. I hope I find a definitive solution for this.

Wait a little.

meleu

@andershp hey bro! I fixed the script and tested. Seems to be working fine now.

Could you test it again?

By the way, the problem was just that I missed the -launching on the filenames. 😅

AndersHP

Sweet! I will test it tonight. Thanks! :)

AndersHP

Sorry, man. It's not working for me.. I'm starting to feel like something's wrong with me..

The new runcommand-onstart looks like this, correct?

I'm still not understanding that some of the lines contain "mame" - shouldn't it be either mame-advmame or mame-libretro? (see here)

So, just to be sure my setup is not wrong; my 3 launching images are placed here:
/opt/retropie/configs/mame-libretro/launching.png
/opt/retropie/configs/mame-advmame/launching.png
/opt/retropie/configs/fba/launching.png

meleu

@andershp said

The new runcommand-onstart looks like this, correct?

Nop. You're using the previous version. Delete the file and perform those commands again.

AndersHP

@meleu that's what I did.. Strange. Will do it again, but how can it wget an old version?

meleu

@andershp said in Runcommand launch images automatically chosen for ROM-specific emulatorchoices:

how can it wget an old version?

Another possible problem can be related to that cat command.

Well, if you can understand a github diff, look here the only line I changed to fix the code:
https://github.com/meleu/share/commit/c31f3f47ad2f790c2c5f7acb66b7db9100bd892e

And if you're still having problems to get the current version, maybe you can edit the file yourself.

AndersHP

@meleu Allright, I get the diff principle, so I'll alter it manually.
But again.... I still don't understand how the script gets to mame-libretro or mame-advmame. Looks like it only distinguishes between fba and mame..?

meleu

@andershp said in Runcommand launch images automatically chosen for ROM-specific emulatorchoices:

I still don't understand how the script gets to mame-libretro or mame-advmame. Looks like it only distinguishes between fba and mame..?

I've just noticed you're still using the very first version of my script. I already fixed the mame names. Look the diff:

https://github.com/meleu/share/commit/bf5f6d6c090dc63cfcfd8e4ed90a927e14b2062d#diff-8aa1e6dea1743cf6d899871b9e804436

I think I know what's happening. When you use wget and there's a file with the same name of the one you're trying to download, wget creates the newer with a trailing .1. Then when you use the cat trick you're not "installing" the new script.

My suggestion:

rm system_specific_arcade_launching_images*

sudo mv /opt/retropie/configs/all/runcommand-onstart.sh /opt/retropie/configs/all/runcommand-onstart.sh.bak

wget https://raw.githubusercontent.com/meleu/share/master/system_specific_arcade_launching_images.sh

cat system_specific_arcade_launching_images.sh >> /opt/retropie/configs/all/runcommand-onstart.sh

AndersHP

@meleu said in Runcommand launch images automatically chosen for ROM-specific emulatorchoices:

When you use wget and there's a file with the same name of the one you're trying to download, wget creates the newer with a trailing .1. Then when you use the cat trick you're not "installing" the new script.

Jesus! That's obvious! I feel like a complete tool! :-D

Well, impressive that you managed to improve the script several times with me just saying "first version didn't work" :-)

I will test properly again, tonight. Got a good feeling about it this time, hehe !

cyperghost

@meleu Just a suggestion.
I think it would be better to use runcommand-onxxxx.sh just as entrypoints for calling scripts. Therefore I would modify your installer to .... ;)

rm system_specific_arcade_launching_images*

sudo mv /opt/retropie/configs/all/runcommand-onstart.sh /opt/retropie/configs/all/runcommand-onstart.sh.bak

wget https://raw.githubusercontent.com/meleu/share/master/system_specific_arcade_launching_images.sh

mkdir /home/pi/RetroPie/scripts

mv system_specific_arcade_launching_images.sh /home/pi/RetroPie/scripts

chmod +x /home/pi/RetroPie/scripts/system_specific_arcade_launching_images.sh

echo '/home/pi/RetroPie/scripts/system_specific_arcade_launching_images.sh $1 $2 "$3"' >> /opt/retropie/configs/all/runcommand-onstart.sh

PS: I think it will also help lots of people if there would be a small "instruction" inside both runcommand-onxxxx.sh files!

# Example runcommand-onstart.sh
# --- BASENAMES ---
rom="$3"
es_system="$1"
emulator_used="$2"

# --- ROMname Manipulation ---
#rom_name="$(basename "$rom")"
#rom_path="$(dirname "$rom")"
#rom_no_ext="${rom_name%.*}"

# --- Configfile Playground ---
#config_dir="/opt/retropie/configs/$es_system"
#config_dir="/opt/retropie/configs/all"
#config_file="$config_dir/retroarch.cfg"

# --- YOUR SCRIPTS HERE ---
/home/pi/RetroPie/scripts/system_specific_arcade_launching_images.sh "$es_system" "$emulator_used" "$rom"

AndersHP

So, with this new runcommand-onstart file, I'm afraid, still no launch images shows :(

What can I do to help? Could it be because my games are run off USB?