OpenBOR 6xxx OpenBeta Testphase

mitu

@cyperghost said in OpenBOR 6xxx OpenBeta Testphase:

But I don't know if the module will be accepted in the code review ;)

Unless you submit it, you'll never find out :).

cyperghost

@mitu Well you're right! I already asked for reference. The challange is that the description name of the script module is responsible for all pathes.
As the function are all called by local I should strip pathes. I think it's better to set all OpenBOR versions in one directory.

# $1 string, $2 length
function strip () {
echo "${1:0:$2}"
}

md_id="openbor-6xxxx`
md_id="$(strip $md_id -5}"

This would be my solution to strip away -6xxx
;)

dishins

@bizzar721 Thanks, as @cyperghost said, i already tried that. Turns out that i managed to configure my gamepad with a keyboard inside the game thanks to @cyperghost .

All games that i tried worked great with 6xx version, nice!

Is there any way to setup like a global config to my gamepad so i dont have to setup each game controls one by one?

BiZzAr721

@dishins Using in game setting, save settings as system config (I believe that's what it's called). All future games will default to that. Mods with configs saved, you could just load that system config, or SSH into the config/ports/openbor/saves directory and copy a config from a mod that's config'd how you like and rename it to`gamename.cfg.

cyperghost

@dishins A small workaround I use is to edit runcommand-onstart with
nano /opt/retropie/configs/all/runcommand-onstart.sh

and add following line

[[ $2 == openbor ]] && filename=$(basename "$3") && cp "/opt/retropie/ports/openbor/Saves/master.cfg" "/opt/retropie/ports/openbor/Saves/${filename%.*}.cfg"

I setted one game ready and renamed it's config just master.cfg now if the emulator with name openbor starts, it will copy this masterfile to current loaded module file.

So if I start TMNT Shell Shocked.pak then the copy command is cp master.cfg "TMNT Shell Shocked.cfg" you may change pathes and emulator name after $2 depending on your setup. You see emulator name in gray box

Now launching GAMETITLE (EMULATOR) ...
Press a button to configure
Errors are logged to /dev/shm/runcommand.log

dishins

@cyperghost nice! i'll definitely use this, thank you!

darknior

Question @cyperghost ...
Will you try to update the source code with a better version ?

We use the 6312 ... but on the 6325

fixed a heavy bug on malloc structure

v6330

fix for segmentation fault on runtime (Linux)
added joystick rumble mode for all SDL ports configurable by options (Wii port is now configurable too).
http://www.chronocrash.com/forum/index.php?topic=3947.0

...

v6412

Added my first function to openbor. We already had loadmodel to load a cached model into memory but now I have added unload_model to remove a model from memory.

Some interesting improvements from our version ...

cyperghost

@darknior I'm trying to setup the scriptmodule....
But I think it will end in 2 setups ... I do not have the time to do this are to full understand the packages.sh ... need some help some moderator to set this up.

I tried a script posted here but it won't install like ..
Therefore it's easier to let rp_module_id="openbor-3400" and then install two version of OpenBOR with 2 setups :(
Maybe annother one can solve this.

Goal: To install more instances of OpenBOR and to select the version out of runcommand menu like you want.

cyperghost

@mitu @darknior
Good news... Finally I managed a way to do the installation.
So we have three version of OpenBOR in RetroPie-Setup scriptmodule

openbor - Original scriptmodule
This is the untouched original version that comes with RetroPie (v3400 unsupported)
This port creates one bash file to just call OpenBOR binary

openbor-3400
This is a unsupported and deprecated version. It is based on openbor from former dev members. This version offers PAK file support therefore I patched this with CLI support (v3400 unsupported)
This port creates bash file with just calls OpenBOR binary if left empty. Emulators.cfg will be configurated for CLI support.

openbor-6xxx
This is @zanac and @cyperghost port of OpenBOR with CLI support (v6510-dev from Oct. 2018 official)
This port creates two bash files. One just calls OpenBOR binary. Emulators.cfg will be configurated for CLI support.
The second script file OpenBOR - Module Select Script lets you choose PAK files and load via CLI support.

ScriptModule for RetroPie

Just for testing purposes!

You can have insights of code here
To install make following:

Enter SSH terminal and type follwing text to choose following versions:
1.1 To restore original OpenBOR script: wget http://raw.githubusercontent.com/crcerror/OpenBOR-63xx-RetroPie-openbeta/master/scriptmodules/openbor.sh -O /home/pi/RetroPie-Setup/scriptmodules/ports/openbor.sh
1.2 For version 3400 with CLI support: wget http://raw.githubusercontent.com/crcerror/OpenBOR-63xx-RetroPie-openbeta/master/scriptmodules/openbor-3400.sh -O /home/pi/RetroPie-Setup/scriptmodules/ports/openbor-3400.sh
1.3 For newest branch 6xxx: wget https://raw.githubusercontent.com/crcerror/OpenBOR-63xx-RetroPie-openbeta/master/scriptmodules/openbor-6xxx-RPi3/openbor-v6510-RPi3.sh -O- | tr -d '\r' > /home/pi/RetroPie-Setup/scriptmodules/ports/openbor-6xxx-4rpi3.sh
1.3 For newest branch 6xxx: wget http://raw.githubusercontent.com/crcerror/OpenBOR-63xx-RetroPie-openbeta/master/scriptmodules/openbor-6xxx.sh -O /home/pi/RetroPie-Setup/scriptmodules/ports/openbor-6xxx.sh
Go to ES and select Configuration (the RetroJoy), select RetroPie Setup or just type sudo ~/RetroPie-Setup/retropie_setup.sh
On blue dialog, navigate to P Manage packages
Select exp Manage experimental packages
Run down the list, there select the fitting opbenbor (it's is a number around 300+)
Select S Install from source
Restart ES!!
Now go to ports menu and start the OpenBOR-script!

Enjoy

Sidenote: It works, but the way how it is done should be reviewed. But this is the way how we can manage different versions leading to one settings folder and PakFiles ;)

BiZzAr721

@cyperghost Nice! When we previously talked about the "old 3400" and not breaking peoples setup, I was totally forgetting the original had no CLI support! To me @darknior 's version was the original. haha

Unfortunately, one thing I have been thinking of is that I can see it being difficult to keep up with a compatability list, since everytime source changes mods may break. I think that' s one major flaw with OpenBOR. Maybe we could keep binaries of any milestone builds on git as well.

Should we still use LIBGL_FB3 variable on stretch?

cyperghost

@bizzar721 Well you know what to do with the 3400 binary ;) Then you have PAK support and you need just one configuration. You can also use my JOYPAD scripts, but it needs some tuning for pathes and PAK support (I've done already but not released yet)

About the LIBGL commands.... later the GL wrapper will be also build by compiling on own mashine. Then I won't patch this and then we need commands in which GL mode the wrapper should work, we need error supression and maybe the framebuffer command. But this will be done via the scriptmodul and it's installation path.

It took me some days to elaborate an "easy" working solution with different scriptmodules. Now the path structure is (or can be depending of how many scriptmodules you've installed)

|--opt/retropie/ports
|                 |
|                 - openbor
|                 - openbor-3600
|                 - openbor-6xxx
|
|--opt/retropie/configs/ports
|                          |
|                          -openbor
|                                  |
|                                  - Paks (symlink to ~/RetroPie/roms/ports/openbor)
|                                  - Logs
|                                  - Saves
|                                  - ScreenShots

So all installations of openbor are pointing with symlinks to /opt/retropie/configs/openbor

For 6xxx and 3400 from darknior the Logs points to volatile part /dev/shm
So far it's a possible way to go.

Maybe we could keep binaries of any milestone builds on git as well.

No binaries are not a good solution. You see the stretch version does not work with jessie for example. So it might be better to hold source code and the patches so we can compile on new mashines.
The only reliable source for binaries for RetroPie is the server from BuZz and if he agrees to host binaries... then no problem. But I'm not sure if the way I've set the scriptmodules are correct. The 6xxx version is pure patchwork and needs some rewrite. The 3400 version could withstand some code reviews as it is just a bit modified from the original.

BiZzAr721

@cyperghost said in OpenBOR 6xxx OpenBeta Testphase:

You see the stretch version does not work with jessie for example.

Thanks for clearing that up. I was thinking it worked for both Jesse and Stretch, with Jesse not being able to take advantage of GL4ES. I am using stretch. I removed OpenBOR I had working with LIBGL command to be able to test scripts, and continue testing.

When I test your scripts hopefully tonight, am I still able to edit in LIBGL parameter to take advantage of enhancements (like faster loading!).

cyperghost

@BiZzAr721 You can always edit some parameters if you use nano /opt/retropie/configs/ports/openbor/emulator.cfg
But to be true I noticed never any speedup with various parameter settings. But maybe you find a good combination. You can try to remove the wrapper (just rename the file) then you see that animations and video slow down extreme.

BiZzAr721

@darknior Opening BorLog in dev/shm, build # is blank. Using Cyperghost's install script it shows version 6512.

@cyperghost I was doing a lot of moving/renaming of the binaries when I first used LIBGL_FB=3 command - maybe coincidence or maybe just a placebo. Did some comparisons and your right, I see no noticeable difference.

I installed all from your scripts. Everything worked as it should except darknior's 3400. I copied 2 .bor folders to paks, ran script and got booted back to ES. Here is log:

Parameters: 
Executing: pushd /opt/retropie/ports/openbor-3400; /opt/retropie/ports/openbor-3400/OpenBOR ""; popd
/opt/retropie/ports/openbor-3400 ~
/opt/retropie/supplementary/runcommand/runcommand.sh: line 1008:   781 Segmentation fault      /opt/retropie/ports/openbor-3400/OpenBOR ""
~

Runcommand Line 1008 is eval $COMMAND </dev/tty &>>"$LOG"

A note for another time.......I was trying to make a script within linux that will scan PAKS directory for .bor & .pak, then create a script for each mod to individually load mods. I managed to make the script work for windows a while back, but linux is a bust for me. I must give up. Maybe you can make it a feature in your OpenBOR loader using your talent of the scripts! Maybe it could be a button "create individual mod launchers" which would scan the PAKS folder and create the scripts gamename.sh.

#!/bin/bash
"/opt/retropie/supplementary/runcommand/runcommand.sh" 0 _PORT_ openbor "/home/pi/RetroPie/roms/ports/openbor/TMNT - Shell Shocked.pak"

cyperghost

@bizzar721 Oh 3400 runs fine for me. About version number it's 6315! I changed it in scriptmodules. Maybe you have configs from 6xxx and 3400 together?

About your idea of using single bash scripts..... Consider that every call to openbor uses default "emulator" so if you set openbor-3400 as default your bash files would use this. So the usage would be that openbor-6xxx should be default and some PAKs that won't work are setted to 3400 branch.

BiZzAr721

The 3400 with pak support runs great, but I use it within same OpenBOR folder as 6xxx.. I only tested what you have available going through your scripts and without manually editing anything. I have used single loading scripts with more than one binary, switching between versions with runcommand.

I was under the impression that the emulator.cfg would do the same even if binary is in another folder.

As for possible conflicting configs, let me know if you want me to do a clean image and try again. I have an SD card I've been using just for testing purposes. I'll do what's necessary to give you the feedback you require. I wish there was more I could do to help shorten your workload.

cyperghost

@bizzar721 My workload is okay but it is essential to test on other build. I really appreciate your solid feedback for hunting down some bugs ;) - Thank you very much.

I changed the scriptmodul for v3400 it offers PAK support now. I think at least for rpi1/0 this is needed. I removed the hate speech out of the resporitory so it should not hurt anyone - consider the 3400 PAK port as unofficial!!!
But I believe that it is usefull for other paltforms. I was able to compile it on an ODroid XU4 ... there are some issues with graphics driver but it runs. So more advanced coders can do their jobs ;)

Maybe other platforms (ODROID!) can use this, too.

cyperghost

@darknior

v6412

Added my first function to openbor. We already had loadmodel to load a cached model into memory but now I have added unload_model to remove a model from memory.

Some interesting improvements from our version ...

I think next week I try to compile newest branch. If this will work I will write better scriptmodule. But as I said ... next week. Lack of time ;)

darknior

@cyperghost Excellent if you can do it :)

Like i write on my list this version is the minimum for one game : Fighter's History Revenge [Light v2][v3.0 build 6412]
And permit to make some games smaller in memory :)
Maybe it will for pi to use it, but i must learn how to code (modify) an OpenBOR game before :p

cyperghost

@darknior Man ... the first images full of illegal stuff are out.
Also included the OpenBOR Beta candidates - I'm shocked!