Goodbye fbalpha, welcome fbneo

barbudreadmon

mitu

@barbudreadmon I noticed that after running NES game with lr-fbneo, a fbneo sub-folder appears in the ROMs folder - empty right now. For the arcade system, I see it's storing the hiscore data (the .hi files), but for NES I don't know if this is used - maybe it can be disabled for this subsystem if it's not used ?

barbudreadmon

@mitu It's the save folder for fbneo, some fds/nes games will use it. Imho, the real issue is that savefile_directory is never set in fbneo's config, so the creation of this subfolder fallbacks in each folders hosting fbneo roms, instead of being centralized in retroarch's savefile_directory.

mitu

@barbudreadmon said in Goodbye fbalpha, welcome fbneo:

the real issue is that savefile_directory is never set in fbneo's config

I thought the frontent/libretro should know/set where the savefile_directory is set ?
I see Nestopia queries RETRO_ENVIRONMENT_GET_SAVE_DIRECTORY and so does FCEumm.

grant2258

@mitu said in Goodbye fbalpha, welcome fbneo:

I thought the frontent/libretro should know/set where the savefile_directory is set ?
I see Nestopia queries RETRO_ENVIRONMENT_GET_SAVE_DIRECTORY and so does FCEumm.

The save path is set I checked the code.

https://github.com/libretro/FBNeo/blob/71cf627f2cb5f4c003cbfa535e8cf5950b561f10/src/burner/libretro/libretro.cpp#L1133-L1170

if it saving to contentdir/fbneo its working properly i dont have any nes games for the pie to test

barbudreadmon

@mitu What i mean is that, in retropie, savefile_directory appears to be set to the rom folder by default, which doesn't seem a good practice imho. In a standard retroarch setup, savefile_directory would be defined to the same path for every cores, so i create a fbneo subfolder inside it to avoid having the savefiles at the root of this folder (where other cores might store files under the same name, causing potential issues).

grant2258

There some issues with the input system. Lets show you an example you start fbneo and want to set a lightgun up so you goto quick menu->controllers=>port 2 controls->device type and choose lightgun close the core load it up again you'll see its set right so you think great that cores set up lets play some nes games.

load any nes game with FCEUMM go to quick menu->controllers=>port 2 controls-> look at the device type it says unknown so after scratching your head as to why you set it too zapper close the core load it again all is well. So you thinking no biggie i just had to set it.

nope load fbneo again and look at port2 whats it say now? unknown why oh why are cores saving this in the global config when ever you set one you knock another one out.

Ive been working on my personal 2003+ build and am making some good progress. I will be changing the controller options to be set in the core options until this issue is resolved.

It wont be any issue to anyone that only uses retropads. Just to let the guys using arcade panels or genesis type controllers that that set custom ports on other cores youll probably have to do a core override because this is saved in retroarch.cfg.

barbudreadmon

@grant2258 said in Goodbye fbalpha, welcome fbneo:

I will be changing the controller options to be set in the core options until this issue is resolved.

Afaik, having input settings in core option is not recommended for netplay support, but maybe that's not an issue for the mame cores anyway.

grant2258

@barbudreadmon said in Goodbye fbalpha, welcome fbneo:

Afaik, having input settings in core option is not recommended for netplay support, but maybe that's not an issue for the mame cores anyway.

Well to be honest I hear what your saying but considering anything that uses this option will knock another ones settings off id say thats a bigger issue than netplay not working. It all about perspective of usability

barbudreadmon

@grant2258 said in Goodbye fbalpha, welcome fbneo:

thats a bigger issue than netplay not working. It all about perspective of usability

I wouldn't call it a bigger issue, since it can be fixed through overrides, i would even say it's working as intended, but yeah i guess it's really annoying if you have an habit of not using the default device type, especially if you don't care about netplay in the first place.

grant2258

Well its not about not caring about netplay its about your controls not working right in the first place. Netplay isint going to matter if your controller isint setup right just making users aware of potential problems.

I think i might have a way round this for myself at least you can still use the
RETRO_API void retro_set_controller_port_device(unsigned port, unsigned device); with the variables set in your core options this will stop other cores over riding them or conflicting with them it is avoidable

dankcushions

@grant2258 said in Goodbye fbalpha, welcome fbneo:

There some issues with the input system. Lets show you an example you start fbneo and want to set a lightgun up so you goto quick menu->controllers=>port 2 controls->device type and choose lightgun close the core load it up again you'll see its set right so you think great that cores set up lets play some nes games.

load any nes game with FCEUMM go to quick menu->controllers=>port 2 controls-> look at the device type it says unknown so after scratching your head as to why you set it too zapper close the core load it again all is well. So you thinking no biggie i just had to set it.

nope load fbneo again and look at port2 whats it say now? unknown why oh why are cores saving this in the global config when ever you set one you knock another one out.

not a problem in retropie. we don't save to the global config by default (save on exit is turned off), and our supported way of saving core remapping overrides is this: https://github.com/RetroPie/RetroPie-Setup/wiki/RetroArch-Configuration#core-input-remapping

i just tested it with your scenario and it works fine... fceumm = zapper, fbn = retropad (default).

barbudreadmon

@grant2258 said in Goodbye fbalpha, welcome fbneo:

Well its not about not caring about netplay its about your controls not working right in the first place

Well, idk if it's like this for lots of other cores, but FBNeo will use default mapping if it doesn't recognize the provided device type, so it shouldn't be a major issue here.

grant2258

@dankcushions said in Goodbye fbalpha, welcome fbneo:

not a problem in retropie.

Well that because you guys made some sane choices. Unfortunately will be problematic if turned on is something worth keeping in mind if users have these issues in the future!

the values are save a input_libretro_device_px where x is the number for helping with issues in the future.

grant2258

@barbudreadmon said in Goodbye fbalpha, welcome fbneo:

Well, idk if it's like this for lots of other cores, but FBNeo will use default mapping if it doesn't recognize the provided device type, so it shouldn't be a major issue here.

Its not something thats ideal its is annoying and not obvious how to fix without clarity. Cores will need handle it per core basis when saving the global config is on is all maybe. I would say it more of an RA issue unless its intended to be core wide. I dont think remaps should be going in to controller devices in the first place.

Riverstorm

@dankcushions said in Goodbye fbalpha, welcome fbneo:

not a problem in retropie. we don't save to the global config by default (save on exit is turned off), and our supported way of saving core remapping overrides is this: https://github.com/RetroPie/RetroPie-Setup/wiki/RetroArch-Configuration#core-input-remapping

Probably not worth a new topic but a quick note. The "Retroarch Controls Cheat-Sheet" looks very useful but it's entirely to small to read the fine print in the flow chart boxes (white on blue).

The image does look nice and neat staying in the narrow margins, conforming to the page layout, but as far as practicality it's a bit small running Chrome at 1920x1200. You have to scale up to 125-150% to make it readable. If it could be clicked to make it full size it would be very helpful. The rest of the controller diagrams are a fantastic size and quite readable.

IanDaemon

@Riverstorm Depending on browser, you may be able to right click and "open in new tab" or something similar. Then it's up to the browser how it defaults to showing you a large image. In Chrome I get a magnifying glass that I can zoom in and out.

https://github.com/RetroPie/RetroPie-Setup/wiki/RetroArch-Configuration#core-input-remapping

Riverstorm

@IanDaemon - Thanks for the tips. I do have to zoom in a bit to get a good read on that cheat sheet. I suppose the lion's share of the demographic here is more than likely middle age and older so these ol' peepers can use all the help they can get! ;)

grant2258

Found another thing in the control system I loaded after burner and went to the dpad to map the analog axis there. its saying up/down + and up/ down - instead of up or down.

Would I be right in assuming that libretro only lets you set one label in the retro_input_descriptor and adds a + or - to it?

{ INDEX, RETRO_DEVICE_ANALOG, RETRO_DEVICE_INDEX_ANALOG_LEFT,   RETRO_DEVICE_ID_ANALOG_X,   "Left Analog X"},

barbudreadmon

@grant2258 said in Goodbye fbalpha, welcome fbneo:

Would I be right in assuming that libretro only lets you set one label in the retro_input_descriptor and adds a + or - to it?

Yes, you map one axis in code then the remapping system will split it into 2 entries by adding +/- to the label.