[mame2003/-plus] Removing individual per-game bindings via Tab menu

grant2258

@Riverstorm @Clyde I did look into this myself and I checked whats going on. My issue never was the tab menu it was whats wrong with the game.

I would have fixed the game to work both ways.

When I looked at it and the code i seen the problem right away the driver simply added a hack that shouldn't be there for single player control in the first place.

The problem is they have added a dual joystick and a normal joystick and they both mapped to the dpad in our mame input codes.

after looking into the problem myself just. I was going to add the lstick like i did the rstick and that way these games could work both ways by default but the thread continually ran on about the tab menu and side tracked the issue on the game.

So ill leave it up to mark about the tab menu. I was just interested in fixing the real issue we had that was causing this so we didnt run into it again or have to set keys to none. As for the tab menu i really dont care this issue can be fixed without that feature.

grant2258

normal controls

https://github.com/libretro/mame2003-plus-libretro/blob/240ef74756167e9d6bfc5821b10391f05f5eaded/src/drivers/namcos2.c#L1334-L1370

hack for single joystick
https://github.com/libretro/mame2003-plus-libretro/blob/240ef74756167e9d6bfc5821b10391f05f5eaded/src/drivers/namcos2.c#L1372-L1378

the hack cause the issue we can remove the single joystick hack if you like and it will work. Again not my choice alone i would have discussed this with mark and arcadez my gut feeling would be to just keep the original arcade controls and remove the hack

Riverstorm

You completely lost me. I thought the issue was the TAB menu AND the game. You said you're waiting feedback on an example and then feedback comes.

Now you're not going to fix it because the discussion was about the TAB menu and we did not discuss the games dual stick binding issue with you? An issue in the code we had no idea about.

Yes, the TAB menu is in the game, since they coincide (occur at or during the same time) they kind of go in tandem.

Sooo...you need another example is what you're saying?

grant2258

no ill fix the game that what im interested in doing all i wanted was the your setups you two never gave me them. I just looked it all up myselfs.

Ive already posted the code for set to none that issue is for you and mark to decide if it goes in or not.

Ill discuss with mark and arcadez what we will do fix this game we have a few options. This is regardless of teh tab menu

Riverstorm

So you've washed your hands of the issue entirely or you're saying you coded it and it's waiting to be pulled? Is your vote to implement the change or lobbying against? Every vote counts! ;)

Well, it was worth another shot to try and get it fixed. If I come across any other games I'll post them here. Thanks and heading out now to get a few hours of sleep.

grant2258

https://github.com/libretro/mame2003-plus-libretro/issues/464

@Riverstorm not washing my hands of anything following due process the problems been identified and a soloution will be worked out

grant2258

@Riverstorm
https://github.com/libretro/mame2003-plus-libretro/issues/451

the code has been ready to set the key to none for long time mark can add it any time if he chooses too.

if you guys just said you need to null out p1 up down left right for dual controls to work this would have worked a different way.

grant2258

fwiw @Riverstorm i dont really care what way tab menu is done. I wont loose any sleep either way I rarely use the damn thing unless i have to map over devices

Riverstorm

@grant2258 said in [mame2003/-plus] Removing individual per-game bindings via Tab menu:

if you guys just said you need to null out p1 up down left right for dual controls to work this would have worked a different way.

That's all we had to say? Just asking would have avoided all this conversation.

We need to null P1 dual controls, please! It didn't work to ask! ;) I'm just having a bit of fun with it because I know there's ZERO chance you'll fix it. I will post games as I come across them but I'm not going to hunt them down because that would be futile.

If those directions are hacks you can also nul them to get all controls working properly as an alternate workaround, that's what we are doing now to get clean them up.

Vindicators has the same issue.

Also a side note if you map the buttons on a controller it adds both the button and right stick name to the Input field but the right stick adds only the right stick name.

I'll post here in case the issue was missed but I updated it twice on Github. Sometimes notices seem to be getting caught in the spam filter. Robotron, Joust and Atari's Food Fight have bootstrap issues. Atari's Food Fight I can't even create a new .nvram file to get it to boot, so it's unplayable right now.

grant2258

@Riverstorm issue that caused this is fixed with no user intervention when the pull request is done if it is.
Im trying to be civil here. The pull Request is in for this fix for this game. Your attitude really needs a little work

grant2258

https://github.com/libretro/mame2003-plus-libretro/pull/465

please speak to mark about the tab menu. Thats up to you and him

Riverstorm

@grant2258 said in [mame2003/-plus] Removing individual per-game bindings via Tab menu:

Your attitude really needs a little work

I'm trying to be civil also. I suspect taking some of your own advice wouldn't hurt either but that seems to last only few days, maybe a week before you start picking at the issues I post. I am honestly posting them to improve the core too believe it or not. Lately I've been hunting down bugs and to make it my final core instead of maintaining both 2003 cores but also I post them through normal play because I like when my favorite games work too. I am just trying to get this core the best it can be too. If we work together in a bi-partisan way it may be just that!

If you would close the Github issue on the TAB menu I would appreciate it as further discussion on the subject isn't needed. Thanks Grant.

grant2258

no problems on closing the github issue. Ill just make sure @Clyde is happy enough with it. If anyone else has this issue on another version oh mame turn your cheats off.

Riverstorm

I believe Clyde made his last attempt at delivering an organized laid out real case scenario pertaining to the issue 2 days ago. I think he's done but he might reply and be happy enough with the outcome. Anyway I guess give it time and see.

grant2258

well the issue causing the problem is fixed but the main theme of wanting it added isint. Thats a job for someone else the code is there to do it.

Ive deal with the part i was focused on just giving the thread its conclusion so everyone get there say

grant2258

dealt

Riverstorm

Right, correct. I didn't mean to speak for @Clyde and he may return to the thread and post a thought or two on the conclusion but I honestly think he was done. I guess we'll wait and see.

grant2258

will just close after a few days mr @Riverstorm if we get no reply ill assume he is ok with the way it is.

Clyde

Hi, just stepping in in the ~~few moments~~ one hour I have today between coming home and going to bed. I don't have much free time on weekdays for profound internet discussions, that's the main reason I didn't answer here since sunday.

Another reason is that I'm quite lost at what @grant2258's code is actually doing. Does it set a binding to none with a single or double Esc with or without Enter before? I don't know what the "magic key" is in the first post of https://github.com/libretro/mame2003-plus-libretro/issues/451. I would be grateful if anyone would explain it to me.

As for the fix for Assault, I don't think that fixing single games is a sufficient solution for the lack of a none binding in Input (this game). Neither would be a code change that removes the possibility to reset a binding to the default value.

So I'm left to suggesting my preferred solution – changing mame2003/plus to the behaviour of current MAME and AdvMAME: That a single Esc after Enter will change …

a custom binding to none,
none to default, and
default to none. Rinse and repeat.

edit: Additionally, a single Del without Enter before should set a binding to none.

That way, we would …

get the option to remove a binding completely,
avoid dummy bindings that may be triggered accidentally,
retain the option to set a binding to the default, and
offer anyone who is used to current MAME and/or AdvMAME a consistent user interface.

I don't think it is conductive to focus on single examples, as the advantage of nullifying single bindings at will without the crutch of a dummy binding for either testing or fixing any number of unwanted controls should be obvious, regardless of whether they are problematic or just not preferred.

And just to be on the safe side, I am talking about MAME's Tab menu and nothing else, as I did from the beginning of this thread.

grant2258

just post on the issue page if mark wants to update the legacy gui. To advancemame and current mame standards im sure you can work it out together ill leave it with you two .

As for the coding change you wanted to set it to none that what the code does no magic key left left ect will clear it to none instead of default to none of defaults nothing more.

Mark does know where the code is to work on this he is approachable.

as for the fix its not game specific.

you wont have these issues on other mames if you disable cheats. its explained in the github issue whats happening with this game and a few others .

sorry if i wasnt clear the fix is none user intervention the code posted where to set the key to none is something else.