FBNeo high score saving trouble

sirhenrythe5th

@barbudreadmon i did not test it with MAME, i will do this as soon as i am on my pi again ;)
If it is meant this way it would be useless to enter any initials for the highscores.
The shown highscore during gameplay/demomode shows the naked score only, not the initials :/

barbudreadmon

@sirhenrythe5th fwiw, i see a few taito f3 games having notes like this in hiscore.dat :

;** you must wait until the hiscore table has displayed in attract mode before **
;** starting a game, for the save to work **

There is no note for space invaders 95 specifically, but maybe it was simply overlooked. That kind of behavior where hiscore table needs to be displayed once is actually quite common.

WeirdH

@barbudreadmon One more: karatblz

barbudreadmon

@WeirdH added

sirhenrythe5th

another one got retroachievements-support recently and does not save scores: "turtship" / Turtle Ship by PHILKO ;)

barbudreadmon

@sirhenrythe5th said in FBNeo high score saving trouble:

another one got retroachievements-support recently and does not save scores: "turtship" / Turtle Ship by PHILKO ;)

Hiscores are properly hooked for this one, maybe its hiscore.dat entry is wrong ? Does it save hiscores in (current) MAME ?

sirhenrythe5th

@barbudreadmon thanks for having a look barbudreadmon!
I will have another look at this game later, maybe i have overseen the entrys.

WeirdH

@barbudreadmon Found another one: tubep

sirhenrythe5th

Me too: Shanghai 3 (sunsoft).
Got to the 4th level last evening and after a restart the highscores were gone.
(I feel it....will be the same as with my 1st place in DoDonPachi III. I will never get this score again :D)

barbudreadmon

added !

barbudreadmon

Btw, i'll also mention this here, it is now possible to use hiscore with runahead in FBNeo, however it requires an up-to-date version of retroarch.

WeirdH

@barbudreadmon Two more: ryujin and explbrkr

EDIT: and pirates as well.

barbudreadmon

@WeirdH said in FBNeo high score saving trouble:

ryujin

Support was already implemented for this one, but this entry in hiscore.dat is wrong and only meant for the original ryujin romset which became ryujina when a more recent version of the pcb was discovered.

It's trying to locate hiscores in the 68k cpu ram at 0x100000-0x103fff but the newer pcb has that ram at 0x400000-0x403fff, the original ryujin (now ryujina clone) indeed used 0x100000-0x103fff.

If you feel like testing, assuming the hiscores are stored at the same offset of the same ram, ryujin hiscores might work if you replaced

ryujin:
ryujina:
@:maincpu,program,103e3c,63,54,01
@:maincpu,program,103f20,4,00,00

by

ryujin:
@:maincpu,program,403e3c,63,54,01
@:maincpu,program,403f20,4,00,00

ryujina:
@:maincpu,program,103e3c,63,54,01
@:maincpu,program,103f20,4,00,00

in hiscore.dat

I added support for the 2 other games

mitu

I was playing The King of Dragons (kod) recently and noticed the hiscore is not saved.
The game has a hiscore.dat entry and I - briefly - checked the driver and it looks to have hiscore enabled, but there's no .hi file created. I checked with Mame (245) and it seems to behave similarly - no hiscores file is created.

barbudreadmon

@mitu the entry in hiscore.dat is probably wrong, imho kod is mistakenly grouped with kodr1 while it should be grouped with kodj. It's probably the same situation than ryujin, where original kod became kodr1 at some point.

mitu

@barbudreadmon said in FBNeo high score saving trouble:

It's probably the same situation than ryujin, where original kod became kodr1 at some point.

OK, I'll give it a shot with the kodj hiscore values.

EDIT: yes, you were right, moving the kod: entry next to kodj: saves the hiscore on exit.

WeirdH

@barbudreadmon Found another one: matchit2

EDIT: both aforementioned ryujin and kod fixes worked for me as well, thanks!

barbudreadmon

@WeirdH said in FBNeo high score saving trouble:

matchit2

I'd really prefer those requests to be limited to games existing in hiscore.dat and/or games whose hiscores were confirmed as persistent in current MAME, as i won't be able to do much about their hiscores otherwise.

This one doesn't exist in hiscore.dat, does it save hiscores somehow in current MAME ?

WeirdH

@barbudreadmon said in FBNeo high score saving trouble:

I'd really prefer those requests to be limited to games existing in hiscore.dat and/or games whose hiscores were confirmed as persistent in current MAME, as i won't be able to do much about their hiscores otherwise.

That's cool, I assumed you'd want to know about any game that didn't work, but I'll check them first from now on.

This one doesn't exist in hiscore.dat, does it save hiscores somehow in current MAME ?

Tested with Mame2003-Plus and it does not. It's also not present in the hiscore.dat, so I guess that checks out.

barbudreadmon

@WeirdH said in FBNeo high score saving trouble:

Tested with Mame2003-Plus and it does not. It's also not present in the hiscore.dat, so I guess that checks out.

I'd really recommend testing on current MAME, since MAME2003-Plus is less likely to be using the same dump (cf. ryujin or kod), but i suppose knowing hiscores worked sometime in the past can be helpful too.

On that note, following your request on shangon some time ago, i confirm the shangon2 entry in hiscore.dat is not meant for a modern shangon2 romset, it's actually meant for old bootlegs that were renamed long ago and that we don't even emulate in FBNeo (MAME2003-Plus is still using one of those bootlegs as shangon2). The good news is that i finally figured out how to save shangon's hiscores through nvram so we don't need the hiscore.dat entry anymore