Input needed: ES theming improvements

Nismo

@Zigurana Has this fork video support?

Zigurana

@Nismo This was rebased dec 15th, with the RetroPie Master, so video is in.

But please note, this is not meant to be used in your 'production' setup, I supply this solely for testing.
I do not think this new feature impacts anything on the video snaps side, as it acts only on the systemView objects, not the gameListViews.

Once testing and straightening out of the code has taken place, I will create a PR, and once it is accepted into RetroPie/master, people will be able to use it proper.

Nismo

@Zigurana Thanks a lot, it's a nice commit, i'll try to find some time to test and comment here, I'm a little busy lately because the christmas.

Rookervik

@Zigurana Ok this version works. I will test it out some when I have a little more time.

Rookervik

I do not think video preview is working in this build of ES. I tried setting it up for 3 days and couldn't get it to work. I downloaded fieldofcow's ES and it worked right away.

I will test the carousel bar next.

Zigurana

@Rookervik / anyone else :
Did you manage to try out the theming of the carousel bar?
If there are no open bugs, I'll prepare a PR for this.

jdrassa

@Zigurana

I haven't had a chance to test your changes, but I did look over your code and had a couple of suggestions.

Make element names camel case. This would make it consistent with how the other elements are named.
Merge logosizex and logosizey into a single logoSize element. This is how size is specified everywhere else in the theme.

Here is an example of the theme with these changes.

 <systemcarousel name = "carousel">
    <yPos>0.80</yPos>
    <height>0.1</height>
    <color>f0f0f000</color>
    <infobarColor>90909060</infobarColor>
    <infobarFontPath>./art/font.ttf</infobarFontPath>
    <infobarFontSize>0.033</infobarFontSize>
    <infobarFontColor>ffffffff</infobarFontColor>
    <logoScale>1.2</logoscale>
    <logoSize>0.22 0.24</logoSize>
    <maxLogoCount>5</maxLogoCount>
</systemcarousel>

Also, I believe that you mentioned that you fixed the default sizes, but it doesn't look like that change made it into your branch on github.

It is all nitpicky, but I figured I would mention it. Great job though. Can't wait to see this change land.

Nismo

@Zigurana I like a lot the commit you did, and it's very nice to theming carousel bar, it was something that I always thinking that must be themable, i'm glad with you for this commit, but unfortunately i need to compile it for windows to test it, because I don't have money to buy a Rpi, and I'm very busy with other things, I don't have time to do tests or try to compile it for windows.

Anyway I'm here for helping the forum and contribute with everything I can, so if I can help you on anything else, please tell me, I'll be glad to help you.

I hope you understand me welll, sorry for my poor english.

Regards mate.

mattrixk

@Nismo there is a pre-compiled version here (you can find it a bit further up this thread). I haven't had the chance to test it yet as I'm on mobile, but Rook said it works.

Rookervik

I only just got the ES with themable carousel to work. The logos are still extremely small, and the right hand logo loads slowly. I will try theming the bar now. ES also crashes on exit. So it doesn't seem terribly stable.

Getting a lot of "lvl1: OptionListComponent too narrow!" Errors in debug.

And in trying to get the carousel themed, I had no luck. With the download mattrixk provided in the comment above.

mattrixk

@Rookervik My bad, I must have misread what you said. Too lazy to go up and check.

Rookervik

@mattrixk No bad on your part. I just couldn't get the carousel to theme. Not your fault in any way.

ben0bi

@Zigurana Is it done? I really could use it for my carbon based special theme here: http://github.com/ben0bi/esLIEB

Need to adjust y position.

Regards
ben0bi

ben0bi

@Zigurana Cool. Did not see it, sorry for the other reply.

EctoOne

wow, i think i need to try to build this on my pi so that i can get from this
before
to this
after .

Awesome Job!

mattrixk

I like the look of that theme @EctoOne. I'm curious to see the rest of it.

lilbud

@EctoOne 0_1485219232472_upload-22f36353-e98d-4425-8d26-ef9e40d92ccc

EctoOne

@mattrixk It's basically a Mix of NBBA and your Systemlogos from the Io theme. I just removed the dynamic graphics from NBBA, googled for a dark wallpaper and a different font (for the carousel mod, I actually had to add an invisible font as well to completely hide the 'XX Games available' text).
I was looking for a theme that had the same look as the Quartz theme I use on Kodi. And NBBA was almost perfect in terms of layout, although I'm kinda missing the description text but it would look bad with my square Mix Images from the Universal XML Scraper.
Maybe I can upload a screenshot of the basic and detailed view later when I'm back home.

mattrixk

@EctoOne That sounds good. If you have the time I'd like to see it. Is it a work in progress? Are you planning to release it to the world?

I'm surprised anyone knows of Io. I made it mainly to practice using <include>.

Sorry to hijack the thread. I'll be giving this build a test today during my lunch break.

EctoOne

@mattrixk Io was the first theme that caught my attention when I got my Pi a few months ago because it was dark and simple. Then I found DarkAde but since then I kept the black and white Systemlogos from Io.
But I don't think I will release it, because I'm not sure about all those copyright things. Maybe we can make a new thread about custom modded themes and use pastebin and some instructions to get around that, I don't know. In my case people just have to get their on wallpaper and font, download Io and paste my main theme.xml over yours (should work I guess).

Edit: Here are Images of Basic and Detailed View