Development of module-script generator for lr-mess, lr-mame and mame standalone

Folly

Would you like to help more, in improving the scripts ?

Folly

I found the answers to improve the front-end script !
As I told before I now use comma separate value's within the array's.
This worked from the beginning, but there was a problem with speed.
Al the things I used before were very slow for the 38000 entry's of mame.
I couldn't use cut that's why it took so long to find a better solution.
Now I use sed to convert the lines into csv and I use IFS to cut on delimiter and get the correct value's.
I also implemented a way of re-using the data of mame within the different menu choices. So it will read all in one time for 20 sec. and re-use this data which takes 4 sec.

It now works, only the generator_script part is still old.
For that i also have to fix some things, but those are not that difficult I think.

I worked from what I could accomplish, I hope it will match the direction of our ideas.

Here are some pictures :

DTEAM

@folly
This is very nice!!! good work !

Folly

@dteam

I didn't put it on github yet, there are a still a few little things to do and to check.
But I hope soon.
It's really quite amazing !

Folly

@DTEAM
@RussellB
@valerino

I moved to 2 versions of the generate-script, replacing 1v8 and 2v0:

generate-systems-lr-mess_mame-2v1.sh generates in ~/RetroPie-Setup
generate-systems-lr-mess_mame-2v1-ext.sh generates in ~/RetroPie-Setup/ext/RetroPie-Share

Example to generate in ~/RetroPie-Setup :

curl "https://raw.githubusercontent.com/FollyMaddy/RetroPie-Share/main/00-scripts-00/generate-systems-lr-mess_mame-2v1.sh" | bash -s coleco

Example to generate in ~/RetroPie-Setup/ext/RetroPie-Share :

curl "https://raw.githubusercontent.com/FollyMaddy/RetroPie-Share/main/00-scripts-00/generate-systems-lr-mess_mame-2v1-ext.sh" | bash -s coleco

Only the ext string is different, this defines if the files should be written in the normal directory or in the ext directory !
--> see_this_commit <--
Both files can now be pasted in as a function in add-mamedev-systems.sh front-end module-script

Edit :
With the add-mamedev-systems-test6.sh I did the same :

add-mamedev-systems-test6.sh generates in ~/RetroPie-Setup/
add-mamedev-systems-test6-ext.sh generates in ~/RetroPie-Setup/ext/RetroPie-Share

Get the script (in ~/RetroPie-Setup ) to generate in ~/RetroPie-Setup :

wget -q -nv -O /home/$(ls /home)/RetroPie-Setup/scriptmodules/supplementary/add-mamedev-systems.sh https://raw.githubusercontent.com/FollyMaddy/RetroPie-Share/main/00-workdir-00/add-mamedev-systems-test6.sh

Get the script (in ~/RetroPie-Setup ) to generate in ~/RetroPie-Setup/ext/RetroPie-Share :

wget -q -nv -O /home/$(ls /home)/RetroPie-Setup/scriptmodules/supplementary/add-mamedev-systems.sh https://raw.githubusercontent.com/FollyMaddy/RetroPie-Share/main/00-workdir-00/add-mamedev-systems-test6-ext.sh

or(only 1 version here)
You can also update the RetroPie-Share through the add-ext-repos.sh module-script.
(gets it in ~/RetroPie-Setup/ext/RetroPie-Share and generates in ~/RetroPie-Setup/ext/RetroPie-Share !)

Happy testing !

Folly

@DTEAM
I came across the first issue :
Sorting the descriptions is based on the system names because they are linked in one cel in the array.
That's why they are not perfectly on alphabetical order.
No solution right now, I have to think about it.

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

That's why they are not perfectly on alphabetical order.
No solution right now, I have to think about it.

I understand what you mean. The numerical order go in front of alphabetical order. You are not far to the end of the project !! Have you think about a way to separate MESS systems from global MAME list? Bye the way, It's awsome!

Folly

@dteam said in Development of module-script generator for lr-mess and mame standalone:

@folly said in Development of module-script generator for lr-mess and mame standalone:

That's why they are not perfectly on alphabetical order.
No solution right now, I have to think about it.

I understand what you mean. The numerical order go in front of alphabetical order.

Well, it's not exactly that.
But you are in the right direction.

You are not far to the end of the project !!

Indeed it progressing nicely !

Have you think about a way to separate MESS systems from global MAME list?

Yes I have been thinking about that.
I was looking at the mame source, arcade drivers are in a different place than the machine drivers.
But, for now, I have no idea on how to accomplish that.
Within minutes the structure can be quite difficult to understand.
And I have to take speed into account too.
That make this quite hard.

I was also thinking of making entry's by platform.
I think that can easier be done, just like the A,B,C story.

If I have some spirit I will look at those issues.

Bye the way, It's awsome!

Thanks for the compliment !
It is ! Really unbelievable ;-)

RussellB

@folly I'd love to.

Here's a question, probably for a new thread. I installed a PixelCade LED marquee in my bartop arcade build which requires a customized EmulationStation that calls web services on the local machine which has a listener to interact with the marquee. I didn't like having to specifically modify ES for this purpose so I implemented three new events: game-select, system-select, screensaver-game-select, and moved the logic to bash scripts. I've seen other threads that discuss wanting this capability. Is that something users would like?

Folly

@russellb said in Development of module-script generator for lr-mess and mame standalone:

@folly I'd love to.

Great !

Folly

@russellb said in Development of module-script generator for lr-mess and mame standalone:

Here's a question, probably for a new thread. I installed a PixelCade LED marquee in my bartop arcade build which requires a customized EmulationStation that calls web services on the local machine which has a listener to interact with the marquee. I didn't like having to specifically modify ES for this purpose so I implemented three new events: game-select, system-select, screensaver-game-select, and moved the logic to bash scripts. I've seen other threads that discuss wanting this capability. Is that something users would like?

Looking something like this ?

Schermafbeelding 2021-05-11 om 08.53.08.png

I have never used a PixelCade LED marquee, but I would definitly want one, if I had a bartop arcade build.
Perhaps something for the future.

Just reading your story, I think you have something good.
Just use the regular ES and add your bash script are really good arguments to make it simple.
So this sounds good to me, you should make a thread for that !

Perhaps we can even add it to our front-end, you never know.

RussellB

@folly I'll start a new thread. I really like the functionality that was in there so I just leveraged it. I like general solutions that can be reused.

So:

game-select receives system name, rom name, game name
screensaver-game-select receives system name, rom name, game name
system-select receives system name, type-of-change ("start","input")

While I'm in there are there any other events that could be useful to intercept?

RussellB

Folly

@russellb

Well, at the moment I don't have any idea about that, because I know too little about this subject.
You should explain the process in your thread thoroughly, perhaps then I can get a better idea on what should be in there and what should be added.

Name me in your thread and I will follow it.

RussellB

@folly Will do!

Folly

@DTEAM @RussellB

I found multiple issues with the front-end module-script.
I installed it all from scratch on a x86-64 computer.

I made these commits :

Folly

@DTEAM

I added the choice to download the images and videos for the gamelists.
So after the download the images and videos are displayed in Emulationstation.

It worked quite good again.
But sometimes, with the downloading, the download script said [Exists].
It could be an issue with the gdrivedl.py script.
Or perhaps there are double files on your google drive.
Can you check that ?

Also found something that could improve the gamelists.
In the gamelists I found this directory :
/home/pi/.emulationstation/downloaded_images/
This is a link to :
/opt/retropie/configs/all/emulationstation/downloaded_images
So we can better use the opt directory, I think.
That way other users of RetroPie, that aren't called "pi", can also use the gamelists.

This is the commit :
https://github.com/FollyMaddy/RetroPie-Share/commit/0671df1a855a67a3b42fcf969c8df8aabf92f5f5

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

Also found something that could improve the gamelists.
In the gamelists I found this directory :
/home/pi/.emulationstation/downloaded_images/
This is a link to :
/opt/retropie/configs/all/emulationstation/downloaded_images
So we can better use the opt directory, I think.
That way other users of RetroPie, that aren't called "pi", can also use the gamelists.

Another option could be to put the gamelist.xml and the medias in the rom/system folders.

All my new "scrapes" are in my roms folders

Or perhaps there are double files on your google drive.
Can you check that ?

Yes, I'll do

Folly

@dteam

I have done some extra research on the gamelists regarding a user independent approach.
I did try some things but it seems not working using ~/ for all the entry's.
Don't know why.
I get back to you, when i found something better.

DTEAM

@folly
I'll do It next week, but It will look like this

<?xml version="1.0"?>
<gameList>
	<game id="41424" source="ScreenScraper">
		<path>/home/pi/RetroPie/roms/all_in1/bittboy.7z</path>
		<name>BittBoy Mini FC 300 in 1</name>
		<desc>nes_vt369_vtunknown.cpp
</desc>
		<image>./media/bittboy.png</image>
		<marquee />
		<video />
		<thumbnail />
		<rating>0.8</rating>
		<releasedate>20170101T000000</releasedate>
		<developer>BittBoy</developer>
		<publisher>BittBoy</publisher>
		<genre>All in one Handheld console</genre>
		<players>1</players>
	</game>

The gamelist.xml must be in the system room folder like this e.g./home/pi/RetroPie/roms/all_in1/gamelist.xml and all medias (videos, marquees and images) will be in a media folder inside the rom system folder like this : /home/pi/RetroPie/roms/all_in1/media

I'll not separate videos, marquees and images in individual folders. It's to much work for nothing.

the path is for a .7z file. Did you do something to include .zip. I don't remember.

Some themes use <thumbnail> instead of <marquee>. The user will need to make an adjustment if this is the case.

Are you agree with that?

Folly

@dteam

I have found that changing this :

<path>/home/pi/RetroPie/roms/all_in1/bittboy.7z</path>

into this :

<path>./bittboy.7z</path>

Will also work and then it's user independent.
We should change that too

About the media part :
Why do you want it in ./media ?
I have some doubts about placing the media into the rom directory's.
~~That way users will always see the directory media in EmulationStation.~~
As an alternative we can also link to some directory's for those who want that.
Linking them to ./media if they want or not.

Edit : I tested your approach, seems better than I expected.
Indeed, the media directory isn't seen in emulationstation.
Downloading can be a possible problem with the structure still on google drive.
What do you think are the benefits from your perspective ?
The ones I can think of are (do you have the same reasons ?):

backup all in on go (roms,media and gamelist)
quick and easy to find in the rom directory for easy access and changing
not mixing with gamelists in /opt/retropie/configs/all/emulationstation/gamelists

Btw.
It should be quite easy using sed in a cmd line to change them in minutes.