Development of module-script generator for lr-mess, lr-mame and mame standalone

Folly

Ok, beats me, I have no clue why it isn't working.

Was your retroach.cfg accidentally saved when you where in the retroarch UI ?
Or did you perhaps create a game options file accidentally ?
( edit : I created a game option file, it's a core option file in /home/pi/.config/retroarch/config/MAME/.opt . It seems not the problem )*

mame_cheats_enable = "disabled"

This should be on enabled if you installed one of the install-system-cmd module scripts.

My On-Screen Overlay setting looks like this.

How is yours when you run a game ?

If you do :

ls -l /home/pi/RetroPie/overlays/konamih

Are your permissions like this ? :

-rw-r--r-- 1 pi pi

Folly

@dteam

Maybe we have to leave it for now.
Perhaps we will find the solution by accident.

Folly

If we want, it is possible to test the artwork download with this code again :
https://retropie.org.uk/forum/topic/29682/development-of-module-script-generator-for-lr-mess-and-mame-standalone/37

Matt has changed his program with my suggestions, accordingly :
https://github.com/matthuisman/gdrivedl/issues/12

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

If we want, it is possible to test the artwork download with this code again :
https://retropie.org.uk/forum/topic/29682/development-of-module-script-generator-for-lr-mess-and-mame-standalone/37

Are you talking about the first version :

#gets the artwork, about 42 files and puts in in the correct path (perhaps a bit more)
#not ok, it has to get 162 files
wget -nv -O /tmp/gdrivedl.py https://raw.githubusercontent.com/matthuisman/gdrivedl/master/gdrivedl.py
python /tmp/gdrivedl.py https://drive.google.com/drive/folders/1sm6gdOcaaQaNUtQ9tZ5Q5WQ6m1OD2QY3 -P $HOME/RetroPie/roms/mame/artwork
rm /tmp/gdrivedl.py

Folly

@dteam

Indeed, I will have a look at it now.

Running it now, looks good !

Successful !
All 158 files in 28 minutes.

Now we have 2 possibility's for downloading.

Folly

@dteam

I added the download lines in the get-cheats-artwork-overlays.sh script.
What it does :

download cheats for MAME standalone/lr-mess
download artwork for MAME standalone (@DTEAM handhelds)
create custom configs for retroarch overlays and extract backgrounds for running with lr-mess (@DTEAM handhelds)

You can run it directly without even downloading it as a file, with this command :

curl https://raw.githubusercontent.com/FollyMaddy/RetroPie-Share/main/00-scripts-00/get-cheats-artwork-overlays.sh | bash

I used the gdrivedl.py for the artwork in above script to make it look really simple and it outputs just one line per file.

My own google download code with curl is a bit more sophisticated, I have another idea with this.

DTEAM

@folly said in Development of module-script generator for lr-mess and mame standalone:

I added the download lines in the get-cheats-artwork-overlays.sh script.
What it does :

download cheats for MAME standalone/lr-mess
download artwork for MAME standalone (@DTEAM handhelds)
create custom configs for retroarch overlays and extract backgrounds for running with lr-mess (@DTEAM handhelds)

It works !!

Folly

@dteam

Damn, that's nice.

Tonight I had the idea to only let the the retroarch-overlays create when there is a Background.png available.
Then we don't get configs we can't use.
This way I can keep all game names in the array's
And then I don't have to remove the ones that don't use backgrounds.
Btw. we can also use it now for checking on which games we have to work on.

How does that sound ?

Edit :
I just added an if function in my script, and it's working.
(I do not have the possibility right now to add it on github, I will do that later)

DTEAM

@folly
For overlays, it's frustrating on my end for Lr-mess-cmd. It always points to / opt / retropie / configs / all / retroarch / overlay and not to your directories. I have to do it manually. I am looking to see if I missed something during the installation.

I'll re-install the all thing properly.

Folly

@dteam

Indeed, I that is really frustrating.
Really, I have no idea what is causing this.

Have a look at /home/pi/.config/retroarch/retroarch.cfg
I remember I had some trouble adding options in the retroarch.cfg in /opt/retropie/configs/all.
So I did it in /home/pi/.config/retroarch/retroarch.cfg .
Perhaps you have options in there that's causing it.
You could rename it, to see what happens.
You can alway's rename it back.

I could also change the script, so all background files come in that directory.
Would that be a solution ?

DTEAM

@folly

I could change the script, so all background files come in that directory.

It could be good, because like that, you will use the default Retroarch overlay folder for Retropie.

Have a look at /home/pi/.config/retroarch/retroarch.cfg

I remember I had some trouble adding options in the retroarch.cfg in /opt/retropie/configs/all.

So I did it in /home/pi/.config/retroarch/retroarch.cfg .

Perhaps you have options in there that's causing it.

You could rename it, to see what happens.

You can alway's rename it back.

I'm gonna try that

Folly

@dteam said in Development of module-script generator for lr-mess and mame standalone:

@folly

I could change the script, so all background files come in that directory.

It could be good, because like that, you will use the default Retroarch overlay folder for Retropie.

Ok, I will make a commit when I can.
Then I will remove the subdirectory's also.
All overlays are saved in /opt/retropie/configs/all/retroarch/overlay
Basically it will look like the artwork directory but then containing .cfg and .png.

I was able to do a commit on github.
I did the change without testing, but should work. (did test : OK)
If you comment part 2 and 3 in the script it will not download all again.
I think you know how to do that.

You have to manually remove /home/pi/RetroPie/overlays.

Folly

@dteam

I have rewritten the readme on the github page :
https://github.com/FollyMaddy/RetroPie-Share/blob/main/00-scripts-00/readme.md
I also reorganized the whole repository to get a better oversight.

Improved ?

DTEAM

I reinstalled everything and now all overlays working fine with retroarch. Great job.

@folly said in Development of module-script generator for lr-mess and mame standalone:

I have rewritten the readme on the github page :
https://github.com/FollyMaddy/RetroPie-Share/blob/main/00-scripts-00/readme.md
I also reorganized the whole repository to get a better oversight.
Improved ?

Good "readme" on github. Everythings are easy to understand. It's fu%?$ng nice!

Folly

@dteam

That is really great to hear.

We have done an incredible job here !!!

I still have some ideas of implementing downloads into the module-scripts.
So if we want, we can try that part in the future. :-)

DTEAM

@folly

Just a reminder
for :

bash $version ablmini # creates cmd script for all_in1 # bootable 
bash $version alnattck # creates cmd script for classich # bootable
bash $version gnw_ball # creates cmd script for gameandwatch # bootable 
bash $version jak_batm # creates cmd script for jakks # bootable
bash $version kgradius # creates cmd script for konamih # bootable
bash $version taddams # creates cmd script for tigerh # bootable
bash $version rzbatfor # creates cmd script for tigerrz # bootable

and more ...

you can get gamelist.xml files here
and images, marquees and videos for those gamelist.xml files , here

Folly

@dteam

If I have some time, I can try to add it in the get...script.

Folly

@dteam

I had a quick look at the gamelist files.

It's quite simple now to download them all in the correct place with these commands ( this can be added to the get script ) :

wget -nv -O /tmp/gdrivedl.py https://raw.githubusercontent.com/matthuisman/gdrivedl/master/gdrivedl.py
python /tmp/gdrivedl.py https://drive.google.com/drive/folders/1f_jXMG0XMBdyOOBpz8CHM6AFj9vC1R6m -P /opt/retropie/configs/all/emulationstation/gamelists
rm /tmp/gdrivedl.py

This will not only download the handhelds but also the others.
Is this a problem ?

One problem I have is, I have .zip files.
Gamelist files that only have .7z files in them, will not work for someone who has .zip files.

Could you add them on the googles drive ?

You can add them simply by using these commands once (!) on a gamelist and then putting them on google drive again.
( make a backup of the file before you use this ! )
Go to the directory of the specific gamelist and do :
(tested and should work)

sed -i 's/..gameList.//g' gamelist.xml 
cat gamelist.xml | grep -v ?xml | grep -v gameList | sed 's/\.7z/\.zip/' >> gamelist.xml
echo "</gameList>" >> gamelist.xml

Explanation :

sed removes the last line because otherwise we have "</gameList>" end halfway after adding the ".zip" files
cat shows (pipes it now to the next commands) the file in the terminal, except the lines containing ?xml and gameList using grep
sed looks for ".7z" entry's and replaces them with ".zip
">> gamelist.xml" will write and add all lines, that went trough sed and grep, to the same gamelist file
so all game entry's double, keeping the originals and adding the ones for ".zip"
echo makes sure the file gets the last line "</gameList>" end again

Make sure you do this only once to the file, otherwise the game entry's will triple etc...

ps.
You can also do this with gamelist that only have ".zip" files, adding ".7z" :

sed -i 's/..gameList.//g' gamelist.xml 
cat gamelist.xml | grep -v ?xml | grep -v gameList | sed 's/\.zip/\.7z/' >> gamelist.xml
echo "</gameList>" >> gamelist.xml

DTEAM

@folly

This will not only download the handhelds but also the others.
Is this a problem ?

No problem, but most gamelist.xml files are made for mess/mame romset (excepted pockstat and svmu). It doesn't work if people use No Intro or TOSEC romsets.
I'll do the modification for 7z/zip this week.
Regards

DTEAM

@dteam
sed fonction only works in Linux. Doesn't work in PowerShell or as a .bat

so all game entry's double, keeping the originals and adding the ones for ".zip"

Show me an example of that and I'll do It manually with the basic search and replace tool.

Starting example :

<path>/home/pi/RetroPie/roms/tigerh/taddams.7z</path>

new edit

I'll do it directly on the Pi