mupen64plus-gles2ricemain packages

[sleve_mcdichael]

After updating mupen64plus, I have an odd entry in my emulators.cfg:

mupen64plus-GLideN64 = "/opt/retropie/emulators/mupen64plus/bin/mupen64plus.sh mupen64plus-video-GLideN64 %ROM% %XRES%x%YRES% 0 --set Video-GLideN64[UseNativeResolutionFactor]\=1"
mupen64plus-GLideN64-highres = "/opt/retropie/emulators/mupen64plus/bin/mupen64plus.sh mupen64plus-video-GLideN64 %ROM% %XRES%x%YRES% 0 --set Video-GLideN64[UseNativeResolutionFactor]\=2"
mupen64plus-gles2n64 = "/opt/retropie/emulators/mupen64plus/bin/mupen64plus.sh mupen64plus-video-n64 %ROM%"
mupen64plus-gles2rice = "/opt/retropie/emulators/mupen64plus/bin/mupen64plus.sh mupen64plus-video-rice %ROM% %XRES%x%YRES%"
lr-mupen64plus-next = "/opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-mupen64plus-next/mupen64plus_next_libretro.so --config /opt/retropie/configs/n64/retroarch.cfg %ROM%"
default = "lr-mupen64plus-next"
lr-mupen64plus = "/opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-mupen64plus/mupen64plus_libretro.so --config /opt/retropie/configs/n64/retroarch.cfg %ROM%"
mupen64plus-gles2ricemain packages = "/opt/retropie/emulators/mupen64plus/bin/mupen64plus.sh mupen64plus-video-rice %ROM% %XRES%x%YRES%"

That last line, mupen64plus-gles2ricemain packages, that's not right, right? I'm on Pi 4 using RetroPie v4.7.20.

I deleted the line and installed mupen64plus again, and the line returned.

I guess it's probably getting added in the configure function, here: https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/emulators/mupen64plus.sh#L269

It looks like at that point in the script, a local $name variable hasn't been set yet, so it's inheriting it from admin/setup.sh, here: https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/admin/setup.sh#L380

There is a mupen64plus-gles2rice entry from the initial install (4.7.1 official image) but if I remove that line & reinstall mupen it doesn't return. I assume this is what the plug-in should be called. It does have the same command as the buggy mupen64plus-gles2ricemain packages that gets added by the script.

Should I just remove the $name var as in https://github.com/s1eve-mcdichae1/RetroPie-Setup/commit/03530048506cffdd5aa28e8237f457921066ac8a or is this one supposed to have a -highres option too like the section immediately following?

[BuZz]

@sleve_mcdichael yeah that's a bug from when some stuff got moved about a bit. Will sort it.

[quicksilver]

@sleve_mcdichael I noticed this as well but forgot to say something about it. Good catch!