Need Help with OpenBor & Retropie-Extra (Exarkuniv)

sleve_mcdichael

@mitu said in Need Help with OpenBor & Retropie-Extra (Exarkuniv):

Maybe we can relax this check and get the modification date of the file, if git doesn't find the last modification of the file.

And this quick change to the Extras install will preserve the modules' timestamps when they are copied, so that can be accurately assessed.

https://github.com/Exarkuniv/RetroPie-Extra/pull/147/files

mitu

@sleve_mcdichael said in Need Help with OpenBor & Retropie-Extra (Exarkuniv):

And this quick change to the Extras install will preserve the modules' timestamps when they are copied, so that can be accurately assessed.

That's ok, but I think it will only work after this change is added to RetroPie.

BuZz

@mitu btw I've not merged yet as I want to test but I think I may implement this differently.

sleve_mcdichael

@mitu did I do something wrong?

$ ls -l ext/RetroPie-Extra/scriptmodules/ports/prototype.sh 
-rw-r--r-- 1 pi pi 1377 Jul 21  2022 ext/RetroPie-Extra/scriptmodules/ports/prototype.sh
$ cat /opt/retropie/ports/prototype/retropie.pkg 
pkg_origin="source"
pkg_date="2023-02-21T21:42:33-08:00"
pkg_repo_type="git"
pkg_repo_url="https://github.com/ptitSeb/prototype.git"
pkg_repo_branch="master"
pkg_repo_commit="12d2de8639982db12091ca37eeee9036b54f3fa7"
pkg_repo_date="2020-12-20T17:42:33+01:00"
pkg_repo_extra=""
$ git status
On branch update-package
Your branch is up to date with 'cmitu/update-package'.

nothing to commit, working tree clean
$ sudo ./retropie_setup.sh

mitu

@mitu did I do something wrong?

No, but did you read my previous reply ?

EDIT: Ah, I see you're used by PR to test. Seems it's not working correctly then.

EDIT2: Seems the update trigger is also influenced by the commit hash from source repo declaration - without it works fine. Either remove the commit (keeping the branch) or add the full commit hash - see if it works afterwards.

sleve_mcdichael

This post is deleted!

sleve_mcdichael

@mitu said in Need Help with OpenBor & Retropie-Extra (Exarkuniv):

EDIT2: Seems the update trigger is also influenced by the commit hash from source repo declaration - without it works fine. Either remove the commit (keeping the branch) or add the full commit hash - see if it works afterwards.

Indeed, with the full commit sha, or none, it works:

So I wonder, then, how do the "native" RetroPie modules manage to still work it using the truncated sha?

https://github.com/RetroPie/RetroPie-Setup/blob/1cf5cb6f327f3166dfc62e3fe83411c9dc7d78cf/scriptmodules/emulators/scummvm.sh#L16

rp_module_repo="git https://github.com/scummvm/scummvm.git master a9418f8f"

mitu

@sleve_mcdichael said in Need Help with OpenBor & Retropie-Extra (Exarkuniv):

So I wonder, then, how do the "native" RetroPie modules manage to still work it using the truncated sha?

https://github.com/RetroPie/RetroPie-Setup/blob/1cf5cb6f327f3166dfc62e3fe83411c9dc7d78cf/scriptmodules/packages.sh#L604-L605

sleve_mcdichael

@mitu oh, so if it's exactly 8 characters, then...?

Huzzah!

EDIT: I've been using seven just because that's what GitHub likes to show me:

Is this good? https://github.com/s1eve-mcdichae1/RetroPie-Setup/commit/802ddfd0ed7ec31d483e3468d76fb8dd4896276a

Seems to work on quick test. Does it break anything else?

What's the smallest a commit sha can be and still work? Any reason not to just make it -gt 0?