es_systems.cfg systems file extensions and rom filenames

2Play

@mitu Tried the favorite trick and works as you both advised.

Now ill check the es dev again

2Play

@mitu
Tested below:

I have applied the 2.12.0.rp binary of ES
In roms/ags there are 2 exe files as per image
In roms/ags applied below test gamelist.xml

<?xml version="1.0"?>
<gameList>
	<game>
		<path>./Apprentice 1 Deluxe/App.exe</path>
		<name>App</name>
		<favorite>true</favorite>
	</game>
</gameList>

es_systems.cfg has only .exe

<system>
    <name>ags</name>
    <fullname>Adventure Game Studio</fullname>
    <path>/home/pi/RetroPie/roms/ags</path>
    <extension>.exe</extension>
    <command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 _SYS_ ags %ROM%</command>
    <platform>ags</platform>
    <theme>ags</theme>
  </system>

Result in ES
ES Version and the 2 games show behind on above test.

Should I recompile? Shouldnt with xml the file with capitals .EXE to be omitted from being displayed with the bug fix?

mitu

@2Play said in es_systems.cfg systems file extensions and rom filenames:

Should I recompile? Shouldnt with xml the file with capitals .EXE to be omitted from being displayed with the bug fix?

No, and I'm confused why you'd think it would.

2Play

@mitu
My understanding was that what the bug fix would do.
"Gamelist bugfix: don't show un-registered extensions"

I thought that on the dev binary it would do this. Or the fix expects to see both in the xml and then exclude what is not in es_systems.cfg

For Reference
In the past, on pi3,4 if you wanted to hide a rom file from showing in the ES gamelist, you just removed the extension and these were not displayed any more

Its a practice many used the past years by changing the extension to CAPITAL letters and then remove from the es_systems.cfg

I ll try to dig up an older binary for pi4 that I used in same way and provide you the version

mitu

@2Play said in es_systems.cfg systems file extensions and rom filenames:

I thought that on the dev binary it would do this. Or the fix expects to see both in the xml and then exclude what is not in es_systems.cfg

It does that, but - as I explained later on - extension search is case-insensitive so if you add .exe, then .EXE is also matched even if not listed.

I ll try to dig up an older binary for pi4 that I used in same way and provide you the version

Sure, let me know the version and I'll check.

2Play

@mitu found it!
2.9.3RP has this feature. Seems changed from 2.10 onwards?

NOTE: 2.9.6rp had the bug with the video screensaver not starting a rom any more which I see it got fixed in current version

To our discussion:
I have in ags, exactly as I wrote in https://retropie.org.uk/forum/post/291385 2h ago

es_systems only .exe extension
ags/subfolder game/.exe .EXE the files

if i rename both to .exe they both show. once I rename the unwanted winsetup with .EXE it hides
(no gamelist.xml whatsoever used)

mitu

@2Play said in es_systems.cfg systems file extensions and rom filenames:

Seems changed from 2.10 onwards?

Seems to have been introduced with this change in 2.10.0 indeed.

EDIT: I'll prepare a patch for -dev, will let you know when it's ready.

2Play

@mitu much appreciated.
Will give you feedback when ready.

mitu

Ok, a patch has been added to the ES repo, it should be available if you install from source the emulationstation-dev package.

2Play

@mitu reverting

2Play

@mitu First of all thank you for taking the time to check and make a patch.
Glad i managed to point you to the right info

I want to confirm that your patch on latest dev (2.12.0RP-DEV) is working as supposed to and did in the past.

I ve tested 2 systems, the AGS and PC98 for similar setup (upper case extensions and deleted from es_systems.cfg)
Both show ONLY what is in lower case extension and hides the upper case ones (deletd from cfg)

My kind regards and thank you again!