Configuring <CODE_NOT> Control Mapping in lr-MAME2003?

dankcushions

@caver01 nice job! sounds like my theory earlier was right.

Does anyone know about a way to BLOCK the Virtual RetroPad inputs for one emulator core? That would be preferred approach.

my plan before was to block the raw keyboard inputs IF they match the RetroPad inputs. i need to break through the code i linked to earlier to see if that's viable.. maybe this could be logged as an issue against lr-mame2003?

caver01

@dankcushions Yes. That would do the trick! Sorry, I completely missed your reply, but your interpretation is proving to be correct. And, because two inputs are detected, the double-taps are ignored--each attempt looks like two buttons pressed simultaneously.

Would you like me to try to post the issue against lr-mame2003? I've never done that.

dankcushions

@caver01 please do! it's https://github.com/libretro/mame2003-libretro/issues - you could link to this thread if you don't want to repeat your findings there. i'll have a play over the weekend hopefully

caver01

In the mean time, I can't really tell if the current state is having an affect on gameplay. I suspect it creates unnecessary overhead--with every input generated the emulator process simultaneous inputs--but I don't get a sense that there is a timing issue or delay.But now that I know what is happening, I tried a workaround on a single ROM using a per-rom config vindictr.zip.cfg where I force-bind every input represented configs/all/retroarch.cfg to "nul". This, temporarily, at least, lets me build single joystick "tank stick" configurations with the <CODE_NOT> key maps described in the original post. Lo and behold. . .I can play Vindicators with lr-mame2003 in all of its CRT-PI shader glory!

I consider this workaround temporary, as it will become unnecessary if double-inputs gets resolved the way you describe.

caver01

@dankcushions Issue added.

Riverstorm

@caver01 @dankcushions

It looks like the same here. I have an IPAC 2 and my global retroarch.cfg configured exactly as you do which looks like the MAME defaults using the A&B swap?

input_player1_a = alt
input_player1_b = ctrl
input_player1_y = shift
input_player1_x = space
input_player1_start = num1
input_player1_select = num5
input_player1_l = z
input_player1_r = x
input_player1_left = left
input_player1_right = right
input_player1_up = up
input_player1_down = down

Input lr-mame2003 (Keyboard):
"Up Arrow - Right Arrow - Right Arrow"

Output:
UP Retropad1 Up RIGHT RetroPad1 Right RIGHT RetroPad1 Right

Input lr-mame2003 (IPAC 2):
"Up Arrow - Right Arrow - Right Arrow"

Output:
UP Retropad1 Up RIGHT RetroPad1 Right RIGHT RetroPad1 Right

Input lr-mame2003 (XBOX 360 Joystick):
"Up Arrow - Right Arrow - Right Arrow"

Output:
RetroPad3 Up not RetroPad3 Right

If you break it down it looks like it's not recording the NOT but sees it as 6 keys pressed when in actuality only 3 were used whereas the joystick combines them as a NOT.

Is there two issues here? One being the double output (RAW and virtual) and other being not combining NOT statements?

Keyboard & IPAC:

UP
Retropad1 Up
RIGHT
RetroPad1 Right
RIGHT
RetroPad1 Right

Joystick:

RetroPad3 Up
not RetroPad3 Right

caver01

@Riverstorm said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

Input lr-mame2003 (Keyboard):
"Up Arrow - Right Arrow - Right Arrow"

Output:
UP Retropad1 Up RIGHT RetroPad1 Right RIGHT RetroPad1 Right

If you break it down it looks like it's not recording the NOT but see it as 3 key-presses for that one action whereas the joystick combines them as a NOT.

I would contend that it's actually seeing six (6) keypresses not three (3):

UP (raw)
RetroPad1 Up (virtual)
RIGHT (raw)
RetroPad1 Right (virtual)
RIGHT (raw)
RetroPad1 Right (virtual)

which are all <AND>ed together. Also, because they come in pairs (raw+virtual at the same time) it prevents <CODE_NOT> from working--already seeing two different inputs not the same one in succession.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

I would contend that it's actually seeing six (6) keypresses not three (3):

You beat me to it! ;) I revised my post after reading the issue.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

which are all <AND>ed together. Also, because they come in pairs (raw+virtual at the same time) it prevents <CODE_NOT> from working--already seeing two different inputs not the same one in succession.

Right, would it be considered two issues going on or do you think correcting one will fix both? It also exhibits the same behavior when pressing buttons too such as CTRL, ALT, etc.

caver01

@Riverstorm I think this is a single problem with the core implementation.

The fact that we can block the RetroPad inputs with "nul" bindings allowing MAME to just receive raw double keypresses that it correctly interprets as <CODE_NOT>, combined with the fact that non-keyboard inputs (RetroPads defined by joypads/handheld controllers) are also able to generate <CODE_NOT> mapping makes me think that MAME is behaving exactly like it should. It's the Libretro implementation of inputs that seems to be the problem. It's uniquely affecting KEYBOARD input since that is the only way a RAW input gets to the emulator outside of the RetroPads.

The most desirable fix would be the one @dankcushions suggests--filter out the RAW inputs if they match an existing key mapped in RetroArch. I hope the most practical way to fix it isn't an "all or nothing" proposition. In other words, I'd hate shut off RAW inputs completely, as we would lose the ability to press tab and bring up the MAME GUI (which is needed to define <CODE_NOT> in the first place!).

I'd like to check other LR-emulators to see if they behave the same way. For instance, I haven't checked, but I wonder if lr-mame2010 does the same thing.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

makes me think that MAME is behaving exactly like it should. It's the Libretro implementation of inputs that seems to be the problem. It's uniquely affecting KEYBOARD input since that is the only way a RAW input gets to the emulator outside of the RetroPads.

I don't know if it helps but I did test mame4all-pi and it does work as it should with both keyboard and joystick so that does make sense that it's the Libretro core.

caver01

@Riverstorm Yeah, I think we are only dealing with a RetroArch/Libretro core issue here.

I tested lr-mame2010 and I could create <CODE_NOT> mappings in the MAME GUI whether I have P1 controls mapped in retroarch.cfg or bound to "nul". It works both ways. However, I cannot map ANYTHING in 2010 besides Player1 inputs (in both cases). I don't know if that's an issue with 2010 or what (I don't use it), but I could not setup coins, start, or any joystick/buttons from other player locations on my control panel.

Still, there may be something to learn from how inputs are captured in lr-mame2010. I don't see double entries like I do in 2003. Instead, a key mapped in the GUI to Player 1 left, for example, shows up as Kbd P1 JoyL
I am not sure what the logic is there, but it doesn't read like two inputs captured, and it does pickup the AND, OR and NOT mapping just fine, so something inside there is working like it should.

caver01

An interesting observation worth mentioning here is that while it took a complete set of "nul" bindings in lr-mame2003 to setup Vindicators (using <CODE_NOT> mappings for RAW keyboard inputs), once MAME has the inputs mapped for the game, you can remove the custom retroarch.cfg (vindictr.zip.cfg). It was only needed to do the mapping. The game plays fine because it is configured to only watch for the RAW inputs. When the regular RetroArch bindings are restored, the game still works. This is further evidence that the keyboard inputs are sending both RAW and RetroPad to MAME.

dankcushions

i've been going through this and i'm not sure i can think of a nice way to resolve it. the problem is, mame is reading from the abstracted retropad and retrokeyboard. it doesn't know that they are the same key, because they are already abstracted at that point. i don't believe there's a point where you can do a comparison to see if they're the same key.

this seems like something that's best solved through configuration - if you want to avoid the double presses you should change the default binding of (for example) LEFT ARROW from RetroPad1 Left, or change it to 'null'.

caver01

@dankcushions I can appreciate that, but it seems lr-mame2010 has it figured out. Maybe apples and oranges, but the double keys aren't showing up there.

dankcushions

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

@dankcushions I can appreciate that, but it seems lr-mame2010 has it figured out. Maybe apples and oranges, but the double keys aren't showing up there.

i think 2010 gets around it by making mame think a connected gamepad is a keyboard, so it never actually detects gamepads as gamepads, but as the virtual keyboard (i think in the tab menu it will always show up as "Kbd PX...". player 2 SHOULD work (the code is there.. possibly bugged), but player 3 and up won't work i believe, because it only maps 2 virtual keyboards. so this isn't a good solution, but a hack that happens to help in this specific situation.

that's my theory from the code, but i can't test it because i can't connect pads to my mac and can't be bothered to compile it on the pi :)

interestingly, i just found out that mame2010 runs killer instinct 2... at least on my mac.