lr-mame2010 - editing and compiling the source code to disable the nag screens

Expello

Hi folks,

I have following instructions found to compile mame without the nag screens.

edit mame sourcecode to disable nag screens

After these instructions I edited the ui.c.

Edit line 284 insert line
from this:

to this:

show_gameinfo = show_warnings = show_mandatory_fileman = FALSE;

Edit line 399-402 (as comment)
from this:

	if (osd_ticks() < popup_text_end)
		ui_draw_text_box(container, messagebox_text, JUSTIFY_CENTER, 0.5f, 0.9f, messagebox_backcolor);
	else
		popup_text_end = 0;

to this:

  /*if (osd_ticks() < popup_text_end)
		ui_draw_text_box(container, messagebox_text, JUSTIFY_CENTER, 0.5f, 0.9f, messagebox_backcolor);
	else
		popup_text_end = 0;*/

Edit line 1116: (as comment)
from this:

ui_draw_text_box(container, messagebox_text, JUSTIFY_LEFT, 0.5f, 0.5f, messagebox_backcolor);

to this:

/*ui_draw_text_box(container, messagebox_text, JUSTIFY_LEFT, 0.5f, 0.5f, messagebox_backcolor); */

Then I have used the original script (lr-mame2010.sh over retropie_setup.sh) to compile.
The original script use this make settings:

make VRENDER=soft ARM_ENABLED=1 ARCHOPTS=-O2 -mcpu=cortex-a53 -mfpu=neon-fp-armv8 -mfloat-abi=hard -pipe

But I get the following error message (just before the compilation process is completed):

Makefile:838: recipe for target 'obj/retro/emu/ui.o' failed
make: *** [obj/retro/emu/ui.o] Error 1
make: *** Waiting for unfinished jobs....
/home/pi/RetroPie-Setup
/home/pi/RetroPie-Setup/tmp/build/lr-mame2010 /home/pi/RetroPie-Setup

Can anyone help to correct this?

Thanks a lot

Pi 3 / retropie 3.6

sorry for my shabby english

UPDATE / FILES

Here ist the complete logfile and the modified ui.c source.
source and log

BuZz

That isn't a complete log and doesn't show the actual error - I can only assume your changes are incorrect but I cannot advise without more information. Please use markdown for formatting text in posts http://commonmark.org/help/ (eg using code block), and use pastebin.com or a similar site for posting larger logs.

Expello

thx for your reply BuZz.

All updates are in the first thread.

BuZz

The error is

src/emu/ui.c: In function ‘int ui_display_startup_screens(running_machine*, int, int)’:
src/emu/ui.c:284:41: error: ‘show_mandatory_fileman’ was not declared in this scope
         show_gameinfo = show_warnings = show_mandatory_fileman = FALSE;
                                         ^

The changes you are looking at are for another version of mame and the variable mentioned is not defined. try

show_gameinfo = show_warnings = FALSE;

BuZz

BTW is this even needed ? did you check out the "Nagscreen patch Enabled" core option ?

Expello

Yes i try it, I found the variable in "retromapper.c" too, but it doesn´t work.

I changed the config file as follows
/opt/retropie/configs/all/retroarch-core-options.cfg

mame_current_nagscreenpatch_enable = "enabled"

Or did I miss something?

Thanks a lot

Expello

Ok, i recompiled it without

show_mandatory_fileman

No errors, thats good...but it doesnt work, he further shows the LEGAL NOTICE SCREEN.

Very mysterious ... what else can I do?

Expello

no one?
any programmer here?
or am I the only one that finds great that this nag screens disappear?

dabone

I'm working on this at the moment, it should be easy to just disable the messages, ignoring the ability to toggle them.

Just look at the patch in the ui.c..

and comment out the messagebox commands. I seem to remember they start around line 304 or so.

Later,
dabone

dankcushions

lr-mame2003 and lr-imame4all have a built in option to disable these. if you're actually editing the code you might as well add a core option and submit it as a pull request to https://github.com/libretro/mame2010-libretro (or just use these other versions of mame..)

Expello

@dankcushions said:

lr-mame2003 and lr-imame4all have a built in option to disable these. if you're actually editing the code you might as well add a core option and submit it as a pull request to https://github.com/libretro/mame2010-libretro (or just use these other versions of mame..)

Thanks for your reply, but the built in option doesn´t work....see above.

mame_current_nagscreenpatch_enable = "enabled"

Maybe I'm just too stupid ... where is the trick?

I have added this issue.
https://github.com/libretro/mame2010-libretro/issues/16

Best wishes

dankcushions

i didn't say it did work in mame2010 - i said it DOES work in mame2003 and imame4all.

i've responded to your ticket. whilst there is a core option to disable nagscreens in 2010, that option doesn't appear to be connected to anything within the code. a fix is required i think.

movisman

@dankcushions said:

i didn't say it did work in mame2010 - i said it DOES work in mame2003 and imame4all.

i've responded to your ticket. whilst there is a core option to disable nagscreens in 2010, that option doesn't appear to be connected to anything within the code. a fix is required i think.

Hi,

Just a quick question about the nag screen in 2003, great you added the option to suppress the disclaimer in the core options back in Feb, works great but is there any way to suppress the "screen flipping" and "inaccurate emulation" type nag screens?

Cheers

dankcushions

@movisman not without a further change, although it would be pretty easy. i think those screens are quite useful though!

movisman

@dankcushions

Thanks, I was just curious more than anything. I agree, those screens do serve a purpose and can be very useful. I only have a few ROMs which give a warning on launch when using 2003 anyway, but actually the games run fine. If there was a quick core option to disable I might consider using it, but it's really no big deal. It's probably not worth implementing as the warnings are shown for a reason.

mauruco

Hello!
You only need to comment out the line 301-323 (src/emu/ui.c).
Yes, only the fully block "switch".
I tested and everything seems to work.
Cheers

bisus

@dankcushions said in [lr-mame2010 \

lr-mame2003 and lr-imame4all have a built in option to disable these.
Hi
could you please tell me how to do this on mame2003 ?
thanks a lot

dankcushions

@bisus said in lr-mame2010 - editing and compiling the source code to disable the nag screens:

@dankcushions said
lr-mame2003 and lr-imame4all have a built in option to disable these.

Hi
could you please tell me how to do this on mame2003 ?
thanks a lot

if you've got the latest version it should skip the nagscreen by default. note, this is the 'copyright' screen, not the warning screen about incomplete graphics or whatever. those will always be shown.

dsstrainer

@dankcushions I have the latest 4.0.1 and installed the latest lr-mame2010 from binaries and it still nags about being allowed to play blah blah