IR-FBA Not Saving High Scores/Corrupts Game
-
info taken from bringing up in-game Retroarch menu
Clean install and everything updated to 4.3.5 with dkong.zip :
fba 2.97.42 928a4d6 (not working after hiscore is created)Old install :
fba 2.97.42 1aebd0 (working as intended) -
@casdha said in IR-FBA Not Saving High Scores/Corrupts Game:
info taken from bringing up in-game Retroarch menu
Clean install and everything updated to 4.3.5 with dkong.zip :
fba 2.97.42 928a4d6 (not working after hiscore is created)Old install :
fba 2.97.42 1aebd0 (working as intended)thanks!
not working commit is: https://github.com/libretro/fbalpha/commit/928a4d66b9bf80a4ad1652298db30803814017ef- this isn't actually latest, so you should update lr-fbalpha from source.
i think your second commit has a typo, because this url should find it, but no luck:
https://github.com/libretro/fbalpha/commit/1aebd0 -
Yes it was a typo, sorry I left out a letter: 1aebdb0 (working)
working link 1aebdb0
-
V0.2.97.42 2021f2d is the version is shows for me and high scores are not working. Will refresh back to my working build and post last working version later.
-
@casdha thanks - I think you/someone should log this here: https://github.com/libretro/fbalpha/issues/new
Describe the issue and give the working and non-working commits. I would narrow it down ("bisect") to a single commit but not sure when I will get the time :( Maybe this is enough information for the developers.
-
@dankcushions I would but I gotta have an account for that and I don't have one.
Additional Information: I just tried this again and installed the core from source and 2.97.42 7332926 is doing the same thing.
I guess this would be the page fba V 2.97.42 7332926
Side question, can I just take the core file out of an older image and place it in the folder or are there other files to worry about?
Edit: I transferred the entire folder "lr-fbalpha" from an old image into a fully up to date one 4.3.7 with the source update mentioned above and it still has the corruption issue.
I pulled up the in-game retroarch screen and is says 2.97.42 1aebd0 which is the same one that worked previously. If this was all i needed to try then it appears it is something outside of this folder/core causing the issue.
(casual reader) as for how I did it, if someone wants to know bad enough they will figure it out, I don't want to be responsible for someone messing up their build by following my instructions, these permissions are normally locked to prevent file writing and deleting in this part of the system.
-
I went offline for a bit but I finally have time to get back into this project. It looks like you all have jumped into this issue (thank you) so it's time for me to play catch up.
It sounds like the issue is coming from running the latest versions of RetroPie (v4.3.X) and fba (v2.97.42) together. I am attempting to run some tests but most versions I have (at the moment) are prior to the version Casdha mentioned so it may be a moot point on my part. Before I get too far into it, has anyone found a solution with RetroPie v4.3.8 (latest as of now), or know the current status of this issue?
I see from a (fba info link) that the placement of the hiscore.dat file has changed from the "home/pi/retropie/Bios/fba" folder to the "home/pi/retropie/roms/arcade" folder. Out of curiosity, does anyone know the reasoning for that?
-
It was reported on github (https://github.com/libretro/fbalpha/issues/162) and i fixed it 10 days ago.
-
@swsboarder13 said in IR-FBA Not Saving High Scores/Corrupts Game:
I see from a (fba info link) that the placement of the hiscore.dat file has changed from the "home/pi/retropie/Bios/fba" folder to the "home/pi/retropie/roms/arcade" folder. Out of curiosity, does anyone know the reasoning for that?
that's not quite what it says - it's /arcade/ or /fba/, depending on where your roms are stored.
i think it hasn't been in BIOS/fba for 2 years or something, if it ever was!
-
@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:
i think it hasn't been in BIOS/fba for 2 years or something, if it ever was!
Looking at the source of the
lr-fbalphamodule, the configure function copies over thehiscore.datto theBIOS/fbafolder, so the location reported by @SWSboarder13 it's correct. Maybe we need to amend the Wiki page ?From: https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/libretrocores/lr-fbalpha.sh#L56
[..] cp "$md_inst/metadata/hiscore.dat" "$biosdir/fba/" chown $user:$user "$biosdir/fba/hiscore.dat" [...] -
@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:
@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:
i think it hasn't been in BIOS/fba for 2 years or something, if it ever was!
Looking at the source of the
lr-fbalphamodule, the install functions copies over thehiscore.datto theBIOS/fbafolder, so the location reported by @SWSboarder13 it's correct. Maybe we need to amend the Wiki page ?From: https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/libretrocores/lr-fbalpha.sh#L56
... cp "$md_inst/metadata/hiscore.dat" "$biosdir/fba/" chown $user:$user "$biosdir/fba/hiscore.dat" ...i stand corrected! i have corrected the wiki: https://github.com/RetroPie/RetroPie-Setup/wiki/lr-fbalpha#high-scores
-
@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:
i stand corrected! i have corrected the wiki: https://github.com/RetroPie/RetroPie-Setup/wiki/lr-fbalpha#high-scores
+1. Note that the
.hifiles are also created in the same folder - underBIOS/fba.@barbudreadmon I noticed the same problem as @SWSboarder13, I'm compiling the latest git and will test tonight. I assume I must delete the existing highscore file (
gamename.hi) and start a new game. -
@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:
@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:
i stand corrected! i have corrected the wiki: https://github.com/RetroPie/RetroPie-Setup/wiki/lr-fbalpha#high-scores
+1. Note that the
.hifiles are also created in the same folder - underBIOS/fba.oh, that's wrong of lr-fbalpha, then. any user-created data (save files, hi scores, etc), should be in savefile_directory. this sounds like it was changed recently as i don't think it was always like this. logged an issue: https://github.com/libretro/fbalpha/issues/171
-
@dankcushions Savefiles are ok (same folder as the ROM), it's just the
.hifile for the game that's saved alongside thehiscore.datfile. -
@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:
I assume I must delete the existing highscore file (gamename.hi) and start a new game.
Yes, the files generated since september were corrupt thanks to some code for windows phone compatibility. Sadly i don't use hiscores so i didn't notice before someone reported the issue.
I don't have the list but i expect several other cores having unexpected issues because of this code, which is present in quite a lot of them, and this code is still in the process of being properly fixed/refactored (a libretro admin pushed 3 commits about this code to lr-fbalpha today, i didn't test them yet since i'm at work, i hope it is not broken again)
-
@barbudreadmon said in IR-FBA Not Saving High Scores/Corrupts Game:
It was reported on github (https://github.com/libretro/fbalpha/issues/162) and i fixed it 10 days ago.
Which versions has the fixed you mentioned?
I have updated RetroPie to v4.3.8 and FB Alpha v0.2.97.42 980171e yet still seem to be experience the same issue from my initial tests.
(I am using the new hgscore.dat file in the "home/pi/retropie/Bios/fba" folder that came with the latest fab update) -
@swsboarder13 said in IR-FBA Not Saving High Scores/Corrupts Game:
@barbudreadmon said in IR-FBA Not Saving High Scores/Corrupts Game:
It was reported on github (https://github.com/libretro/fbalpha/issues/162) and i fixed it 10 days ago.
Which versions has the fixed you mentioned?
I have updated RetroPie to v4.3.8 and FB Alpha v0.2.97.42 980171e yet still seem to be experience the same issue from my initial tests.
(I am using the new hgscore.dat file in the "home/pi/retropie/Bios/fba" folder that came with the latest fab update)I stand corrected, I just tried testing it again with the versions listed above and it appeared to work, I must've forgotten to remove the old ".hi" file. I will test it again tonight to verify.
-
Update: Now it works. I've update fbalpha from sources and now hiscore works.
Thank you.
Same problem here.Fresh Retropie 4.3 install.Problem with fbalpha 2.97.42, running roms in roms/fba and hiscore files in BIOS/fbaTested with Bubble Bobble (bublbobl.zip). With hiscores enabled it generates a .hi file with wrong data that represents bad graphics on hiscore screen position. -
@barbudreadmon said in lr-fpa Not Saving High Scores/Corrupts Game
Yes, the files generated since september were corrupt thanks to some code for windows phone compatibility[..]
OK, updated from source (revision 980171e) and seems to be fixed - thank you.
As a side effect - all the previous saves I had no longer work - but I guess is expected ?. New saves are ok.Seems to be localized to 1 ROM only, other saves seem ok. -
Neogeo or cps i guess ? Expect all of your current savestates to not work anymore when .43 will be released. Perhaps sooner.
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.