IR-FBA Not Saving High Scores/Corrupts Game

dankcushions

@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:

@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:

i think it hasn't been in BIOS/fba for 2 years or something, if it ever was!

Looking at the source of the lr-fbalpha module, the install functions copies over the hiscore.dat to the BIOS/fba folder, so the location reported by @SWSboarder13 it's correct. Maybe we need to amend the Wiki page ?

From: https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/libretrocores/lr-fbalpha.sh#L56
...
cp "$md_inst/metadata/hiscore.dat" "$biosdir/fba/"
chown $user:$user "$biosdir/fba/hiscore.dat"
...

i stand corrected! i have corrected the wiki: https://github.com/RetroPie/RetroPie-Setup/wiki/lr-fbalpha#high-scores

mitu

@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:

i stand corrected! i have corrected the wiki: https://github.com/RetroPie/RetroPie-Setup/wiki/lr-fbalpha#high-scores

+1. Note that the .hi files are also created in the same folder - under BIOS/fba.

@barbudreadmon I noticed the same problem as @SWSboarder13, I'm compiling the latest git and will test tonight. I assume I must delete the existing highscore file (gamename.hi) and start a new game.

dankcushions

@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:

@dankcushions said in IR-FBA Not Saving High Scores/Corrupts Game:

i stand corrected! i have corrected the wiki: https://github.com/RetroPie/RetroPie-Setup/wiki/lr-fbalpha#high-scores

+1. Note that the .hi files are also created in the same folder - under BIOS/fba.

oh, that's wrong of lr-fbalpha, then. any user-created data (save files, hi scores, etc), should be in savefile_directory. this sounds like it was changed recently as i don't think it was always like this. logged an issue: https://github.com/libretro/fbalpha/issues/171

mitu

@dankcushions Savefiles are ok (same folder as the ROM), it's just the .hi file for the game that's saved alongside the hiscore.dat file.

barbudreadmon

@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:

I assume I must delete the existing highscore file (gamename.hi) and start a new game.

Yes, the files generated since september were corrupt thanks to some code for windows phone compatibility. Sadly i don't use hiscores so i didn't notice before someone reported the issue.

I don't have the list but i expect several other cores having unexpected issues because of this code, which is present in quite a lot of them, and this code is still in the process of being properly fixed/refactored (a libretro admin pushed 3 commits about this code to lr-fbalpha today, i didn't test them yet since i'm at work, i hope it is not broken again)

SWSboarder13

@barbudreadmon said in IR-FBA Not Saving High Scores/Corrupts Game:

It was reported on github (https://github.com/libretro/fbalpha/issues/162) and i fixed it 10 days ago.

Which versions has the fixed you mentioned?

I have updated RetroPie to v4.3.8 and FB Alpha v0.2.97.42 980171e yet still seem to be experience the same issue from my initial tests.
(I am using the new hgscore.dat file in the "home/pi/retropie/Bios/fba" folder that came with the latest fab update)

SWSboarder13

@swsboarder13 said in IR-FBA Not Saving High Scores/Corrupts Game:

@barbudreadmon said in IR-FBA Not Saving High Scores/Corrupts Game:

It was reported on github (https://github.com/libretro/fbalpha/issues/162) and i fixed it 10 days ago.

Which versions has the fixed you mentioned?

I have updated RetroPie to v4.3.8 and FB Alpha v0.2.97.42 980171e yet still seem to be experience the same issue from my initial tests.
(I am using the new hgscore.dat file in the "home/pi/retropie/Bios/fba" folder that came with the latest fab update)

I stand corrected, I just tried testing it again with the versions listed above and it appeared to work, I must've forgotten to remove the old ".hi" file. I will test it again tonight to verify.

jlr

Update: Now it works. I've update fbalpha from sources and now hiscore works.

Thank you.

~~Same problem here.~~

~~Fresh Retropie 4.3 install.~~

~~Problem with fbalpha 2.97.42, running roms in roms/fba and hiscore files in BIOS/fba~~

~~Tested with Bubble Bobble (bublbobl.zip). With hiscores enabled it generates a .hi file with wrong data that represents bad graphics on hiscore screen position.~~

mitu

@barbudreadmon said in lr-fpa Not Saving High Scores/Corrupts Game

Yes, the files generated since september were corrupt thanks to some code for windows phone compatibility[..]

OK, updated from source (revision 980171e) and seems to be fixed - thank you.

~~As a side effect - all the previous saves I had no longer work - but I guess is expected ?. New saves are ok.~~ Seems to be localized to 1 ROM only, other saves seem ok.

barbudreadmon

Neogeo or cps i guess ? Expect all of your current savestates to not work anymore when .43 will be released. Perhaps sooner.

mitu

@barbudreadmon said in IR-FBA Not Saving High Scores/Corrupts Game:

Neogeo or cps

I don't know for sure if it's CPS. It's Ghosts'n Goblins (gngt) that had this problem, but for instance 1944 or Rtype (Japan) didn't.

barbudreadmon

@mitu said in IR-FBA Not Saving High Scores/Corrupts Game:

Ghosts'n Goblins

It's not cps, i guess it was the result of the hiscore corruption then (neogeo and cps1/2/3 had a few changes in their savestates for netplay purpose)

SWSboarder13

Ran my second test on another build. RetroPie v4.3.8 and FB Alpha v0.2.97.42 f71f272 (most recent update from source) and it's working great!

AlanOC91

Downloaded the most recent version of fbalpha from source today and I can't seem to get Street Fighter III Third Strike to save its highscore. It keeps resetting after I exit out of the game.

The Rom is in my roms/cps3 folder so I'm not sure if it matters that it's not in the fba folder.

I'll try some other games in the cps3 folder to test. My other arcade games are saving fine such as Defender.

Edit: Other games don't save either. Temporarily resolved it by enabling auto save state start and auto save state exit.

BobHarris

Do you have to do anything for highscores to get saved?
I just updated from source, but Street fighter iii: second impact still does not save my highscore.
(@AlanOC91 My game is located in the fba folder.)

Retroarch: 1.6.7
Retropie 4.3.5
lr-fbalpha v0.2.97.42 a6ce1ff

barbudreadmon

It's a different issue from the one that was fixed : it turned out that fba didn't support hiscores in the cps3 driver (there are a few drivers in fba where the hiscore logic is not implemented).

I just tried adding this logic in my last commit since i had a pretty good guess of what was missing, it seems to work. I'll submit this change upstream to make sure i'm not overlooking something.

FlightRisk

@bobharris Is there a screen in RetroArch that gives all the versions in one place? If not, how can I easily get my version numbers of RA, RP and lr-fba to post? Thank you. I had the same issue but changed emulators to lr-mame2003 for now on a Pi 3b. Do you guys have comments or opinions on the difference between the 2 emulators on a Pi 3?

mitu

@flightrisk said in IR-FBA Not Saving High Scores/Corrupts Game:

Is there a screen in RetroArch that gives all the versions in one place? If not, how can I easily get my version numbers of RA, RP and lr-fba to post

Press Select + X while in game and the RetroArch RGUI should pop up. You can see the RA and emulator's version at the bottom of the screen.
RetroPie version is shown at the top of the dialog when you start the RetroPie setup script from Emulationstation

RetroPie version