runcommand launching images for ANY theme

alphatoanant

@meleu was wondering if you could help me.

I was trying this out my Art Book theme and am not able to generate any launching images.

So I ran with debug on as you suggested in an above comment but I am not really sure what to look for in the output =)

If you have a moment to help out here is the debug output:
http://codepad.org/DQtvtiIe

Structure wise my systems are set up like this:

A system theme example (/gb/theme.xml)

<theme>
   <formatVersion>4</formatVersion>
   <include>./../theme.xml</include>
   <view name="system, basic, detailed, video">
      <image name="logo">
         <path>./_inc/system.svg</path>
      </image>
   </view>
</theme>

and them main /theme.xml at root

<?xml version="1.0" encoding="UTF-8"?>
<theme>
   <formatVersion>4</formatVersion>

   <view name="system,basic,detailed,video">
      <helpsystem name="help">
         <pos>1 1</pos>
      </helpsystem>
      <image name="background" extra="true">
         <origin>0 0</origin>
         <pos>0 0</pos>
         <size>1 1</size>
         <path>./_inc/images/space.png</path>
         <color>141414</color>
      </image>
   </view>
...

Thank you for any help you can provide and for your work on this script

meleu

@alphatoanant the tool I use to parse xml files is very very rigorous with XML specification. It's failing to generate your images because in your default theme.xml you put some comments at the start of document and then the XML declaration. The xmlstarlet is complaining about this:

XML declaration allowed only at the start of the document
<?xml version="1.0" encoding="UTF-8"?>

I've submitted a PR to your repo fixing this issue: https://github.com/anthonycaccese/es-theme-art-book/pull/1

Look how the Master System's one looks like:

alphatoanant

@meleu awesome, thank you! Your PR has been merged. Sorry for missing such a small change =)

Knowing this now I can also update my other themes easily.

meleu

@alphatoanant You're welcome!

cyperghost

@meleu
A small improvment imho
Instead using /tmp would it not be better to use /dev/shm?
So there is no need for cleanup?

meleu

@cyperghost My reasoning was "most users use this tool on a Raspberry Pi where the amount of RAM is not so plentiful". If you don't clean up, the files will occupy your RAM. But now I'm thinking about using /dev/shm (and keeping the cleanup procedure) due to possible performance benefits.

I'll try to make some tests with /dev/shm in the future.

Thanks ;-)

cyperghost

@meleu Can you step in here please? I think this is an interesting feature. I never used launching images and so some ideas were reinvented :)

EctoOne

So i just noticed that this script doesn't work with themes that use variables instead of system/theme.xml.
Would it be possible to implement that?

meleu

@ectoone yeah, I'm planning to do that. Can you point a theme that uses variables so I can test my code?

lilbud

@meleu You can try to use my Minimal Theme, it uses variables heavily.

A Bored Ninja

@meleu Love this tool!

Is there a way to change the text color AFTER you've set it up? Do I just run this again?

I find all white letters causes issues reading when Mega Drive is loading.

Thanks!

meleu

@A-Bored-Ninja you can choose the lettering color on this screen:
screenshot

benjaminjay

I can't seem to get this to generate a single launch image and I've tried a bunch of different themes...
EDIT: was able to get this to work with TronkyFran but the launch images have a large black border around them

TheBlueDragon

@meleu When i try to run your generation script (for lightswitch theme) i get this error:

Failed to create background image

This error appears for all systems :_( How do i fix this?

DarishZone

Seems the script get some error, it installs but say: "failed to install binary"
Then you can access menu but unable to generate any image.
Any clue?
Edit: It installed after update RetroPie but still refuse to generate images, i'm also unable to select specific systems image, toughs?

ExarKunIv

im with @DarishZone i cant update and will not generate anything
not sure why

DarishZone

I think script is broken with new RetroPie updates, let's wait meleu answer on this.

ExarKunIv

@DarishZone i just opened a issue on github for this

DeweyCox

@ExarKunIv You have a link to the github repository?

DeweyCox

Any support for the Hurstyblue theme?