Problem run ROMS with comma character

[gleam2003]

Run EmulationStation from ssh terminal for watch the error, report:
sh: 1: Syntax error: "(" unexpected

Pi Model or other hardware: Pi3
RetroPie Version Used (eg 3.6, 3.8.1, 4.1 - do not write latest): 4.3
Built From: RetroPie 4.3 clean image
USB Devices connected: none exept snes style controler
Controller used: SNES style (type="joystick" deviceName="USB Gamepad " deviceGUID="03000000790000001100000010010000")
Error messages received: sh: 1: Syntax error: "(" unexpected
Log found in /dev/shm/runcommand.log (if relevant): No data logged! (work with working roms)
Guide used: (Mention if you followed a guide)
File: Action Fighter (USA, Europe).7z
Emulator: all emulator
How to replicate the problem: use roms with , OR (,) on name

[mitu]

@gleam2003 I have no problem with ROMs having , in their names, either running or showing in Emulationstation. Can you try an update for all packages (from binary) from the RetroPie-Setup and then restart Emulationstation ?

[gleam2003]

Update, same issue

I test with change the roms name to find when the problem occurs.

A space after "(" is the problem. My error is to suppose that the problem is the ","

Can you verify?

[gleam2003]

@mediamogul @mitu
This is the command pass to system() command in runSystemCommand function in platform.cpp

/opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS mastersystem /home/pi/RetroPie/roms/mastersystem/Alex\ Kidd\ in\ Miracle\ World\ (USA,\ Europe).7z

My EmulationStation is the development version and I think the problem is in StringUtil.cpp that substitute the strreplace function

[cyperghost]

This post is deleted!

[cyperghost]

@gleam2003 Don't know what going wrong here I just renamed one mastersystem ROM to Alex Kidd in Miracle World (USA, Europe).sms and it worked without any flaws.
Does your 7zip file contain more than one ROM?

[gleam2003]

@cyperghost
Probably problem is only in development version of emulationstation
Wait i'm going to recompile the stable branch to watch if is ok

[gleam2003]

I can confirm, the problem is with development tree

with stable:
/opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS mastersystem /home/pi/RetroPie/roms/mastersystem/Alex\ Kidd\ in\ Miracle\ World\ \(USA,\ Europe\).7z

with development:
/opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS mastersystem /home/pi/RetroPie/roms/mastersystem/Alex\ Kidd\ in\ Miracle\ World\ (USA,\ Europe).7z

In stable ther's escapePath function, missing completely in development

[Tomaz]

I fix this later today when I'm not at work.

There is still an escapePath function, it's just moved to a different location in the source.

Looking at the output, it seems it didn't escape the last ')' properly.

[gleam2003]

@tomaz
Thank you
Not only last ) but also ( and I think any other charachter escape in stable branch with escapePath() function

Edit: there's a space before (

[Tomaz]

@gleam2003
I see now that both ( and ) fails, but the new escapePath function definitely runs since it has escaped all the spaces, will know more when I'm back home later today.

[Tomaz]

@gleam2003
Fixed and submitted, just need to wait for it to be accepted and merged.

[gleam2003]

@tomaz
Thank you, compiled and tested.

[Tomaz]

@gleam2003
Did the fix work for you? It should be merged in the dev branch now.

[gleam2003]

@tomaz
Yes sorry I think you understand from my previous post

[Dwarfboysim]

Hi,
There are free utilities that can search an entire folder and remove that one character from all file names. Pretty sure it’s called Bulk Rename Utility. I used it to tidy up all my file names

Dwarfboysim