• Recent
  • Tags
  • Popular
  • Home
  • Docs
  • Register
  • Login
RetroPie forum home
  • Recent
  • Tags
  • Popular
  • Home
  • Docs
  • Register
  • Login
Please do not post a support request without first reading and following the advice in https://retropie.org.uk/forum/topic/3/read-this-first

Problem run ROMS with comma character

Scheduled Pinned Locked Moved Help and Support
romsruncommandbug
20 Posts 6 Posters 2.6k Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • G
    gleam2003
    last edited by gleam2003 2 Feb 2018, 06:44 2 Feb 2018, 06:44

    Update, same issue

    I test with change the roms name to find when the problem occurs.

    A space after "(" is the problem. My error is to suppose that the problem is the ","

    Can you verify?

    1 Reply Last reply Reply Quote 0
    • G
      gleam2003
      last edited by gleam2003 2 Feb 2018, 07:58 2 Feb 2018, 07:31

      @mediamogul @mitu
      This is the command pass to system() command in runSystemCommand function in platform.cpp

      /opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS mastersystem /home/pi/RetroPie/roms/mastersystem/Alex\ Kidd\ in\ Miracle\ World\ (USA,\ Europe).7z

      My EmulationStation is the development version and I think the problem is in StringUtil.cpp that substitute the strreplace function

      1 Reply Last reply Reply Quote 0
      • C
        cyperghost
        last edited by cyperghost 2 Feb 2018, 08:06 2 Feb 2018, 07:55

        This post is deleted!
        1 Reply Last reply Reply Quote 0
        • C
          cyperghost
          last edited by 2 Feb 2018, 08:07

          @gleam2003 Don't know what going wrong here I just renamed one mastersystem ROM to Alex Kidd in Miracle World (USA, Europe).sms and it worked without any flaws.
          Does your 7zip file contain more than one ROM?

          G 1 Reply Last reply 2 Feb 2018, 08:18 Reply Quote 0
          • G
            gleam2003 @cyperghost
            last edited by 2 Feb 2018, 08:18

            @cyperghost
            Probably problem is only in development version of emulationstation
            Wait i'm going to recompile the stable branch to watch if is ok

            1 Reply Last reply Reply Quote 0
            • G
              gleam2003
              last edited by gleam2003 2 Feb 2018, 08:41 2 Feb 2018, 08:38

              I can confirm, the problem is with development tree

              with stable:
              /opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS mastersystem /home/pi/RetroPie/roms/mastersystem/Alex\ Kidd\ in\ Miracle\ World\ \(USA,\ Europe\).7z

              with development:
              /opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS mastersystem /home/pi/RetroPie/roms/mastersystem/Alex\ Kidd\ in\ Miracle\ World\ (USA,\ Europe).7z

              In stable ther's escapePath function, missing completely in development

              1 Reply Last reply Reply Quote 0
              • T
                Tomaz
                last edited by Tomaz 2 Feb 2018, 08:48 2 Feb 2018, 08:47

                I fix this later today when I'm not at work.

                There is still an escapePath function, it's just moved to a different location in the source.

                Looking at the output, it seems it didn't escape the last ')' properly.

                G 1 Reply Last reply 2 Feb 2018, 08:51 Reply Quote 0
                • G
                  gleam2003 @Tomaz
                  last edited by gleam2003 2 Feb 2018, 08:51 2 Feb 2018, 08:51

                  @tomaz
                  Thank you
                  Not only last ) but also ( and I think any other charachter escape in stable branch with escapePath() function

                  Edit: there's a space before (

                  T 2 Replies Last reply 2 Feb 2018, 10:41 Reply Quote 0
                  • T
                    Tomaz @gleam2003
                    last edited by 2 Feb 2018, 10:41

                    @gleam2003
                    I see now that both ( and ) fails, but the new escapePath function definitely runs since it has escaped all the spaces, will know more when I'm back home later today.

                    1 Reply Last reply Reply Quote 0
                    • T
                      Tomaz @gleam2003
                      last edited by 2 Feb 2018, 16:38

                      @gleam2003
                      Fixed and submitted, just need to wait for it to be accepted and merged.

                      G 1 Reply Last reply 2 Feb 2018, 17:37 Reply Quote 0
                      • G
                        gleam2003 @Tomaz
                        last edited by 2 Feb 2018, 17:37

                        @tomaz
                        Thank you, compiled and tested.

                        T 1 Reply Last reply 2 Feb 2018, 20:39 Reply Quote 0
                        • T
                          Tomaz @gleam2003
                          last edited by 2 Feb 2018, 20:39

                          @gleam2003
                          Did the fix work for you? It should be merged in the dev branch now.

                          G 1 Reply Last reply 5 Feb 2018, 06:41 Reply Quote 0
                          • G
                            gleam2003 @Tomaz
                            last edited by 5 Feb 2018, 06:41

                            @tomaz
                            Yes sorry I think you understand from my previous post

                            1 Reply Last reply Reply Quote 0
                            • D
                              Dwarfboysim
                              last edited by 5 Feb 2018, 07:02

                              Hi,
                              There are free utilities that can search an entire folder and remove that one character from all file names. Pretty sure it’s called Bulk Rename Utility. I used it to tidy up all my file names

                              Dwarfboysim

                              1 Reply Last reply Reply Quote 0
                              16 out of 20
                              • First post
                                16/20
                                Last post

                              Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                              Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.

                                This community forum collects and processes your personal information.
                                consent.not_received