Last Played Collection - Possible to limit?

Alturis

@pjft wouldnt you just expose a new public method of FileData that manipulates the mChildren table to remove X elements from the end?

Simiar to the sort function itself?

void FileData::sort(ComparisonFunction& comparator, bool ascending)
{
	std::stable_sort(mChildren.begin(), mChildren.end(), comparator);

	for(auto it = mChildren.cbegin(); it != mChildren.cend(); it++)
	{
		if((*it)->getChildren().size() > 0)
			(*it)->sort(comparator, ascending);
	}

	if(!ascending)
		std::reverse(mChildren.begin(), mChildren.end());
}

void FileData::remove(  int rmvCount )

Alturis

@alturis said in Last Played Collection - Possible to limit?:

@pjft wouldnt you just expose a new public method of FileData that manipulates the mChildren table to remove X elements from the end?

Simiar to the sort function itself?

Nevermind. Looks like you already took care of this. Missed that. Thank you!

mediamogul

@pjft

Holy hannah that was fast! Well done, sir. It seems as though it's about to be accepted too. I look forward to testing it.

Alturis

@mediamogul said in Last Played Collection - Possible to limit?:

It seems as though it's about to be accepted too

It has been. I imagine if you update from sources it would be there now?

mediamogul

@alturis said in Last Played Collection - Possible to limit?:

I imagine if you update from sources it would be there now?

I updated from source about 45 minutes after the commit went through and still had over 800 games in the list. I'll try it again tomorrow.

mitu

@mediamogul Are you using the emulationstation-dev package, because otherwise you'll be updating from the stable branch, whereas the modification has been committed to the master branch.

mediamogul

@mitu

Ah, good to know. Thanks.

hiulit

Wow, that was quick! Thanks @pjft :D!!

mediamogul

@pjft

Everything seems to be working well. From a user experience point of view, the list now definitely feels less cumbersome and more manageable. However, your first instinct to include 100 items may have been more appropriate, as 50 bottoms out a lot faster than I would have thought. The best number for this is always going to be subjective, but it'll be interesting to hear a consensus after more people have had a chance to try it. Fantastic work!

pjft

@mediamogul thanks for testing. I'd definitely be interested in hearing others' thoughts after a week or so of use, and then we can certainly adjust.

I have another fix for ES to keep me busy before lr-fuse, so it'll still be easy to change if needed.

Best.

cyperghost

@pjft Wow nice add-on
I vote for 100 items as default.

Clyde

I'm amazed what an idea plus some collaboration can accomplice. I love such communities like this one. :)

pjft

Hi all.

Just a note for those of you who moved to the development branch because of this. I seem to have run into an unrelated issue in that branch whereby the metadata of the games you play, if you're saving it on exit, may write incorrect paths for video and Marquee.

Check the games you've played (if any) and see if the metadata on reloading is still ok. I'll try to see if I can fix it (or others as well) soon, but you might be better off with the main branch right now, or at least not saving the metadata. I'd check the metadata for the games you played since updating.

Best.

Alturis

@pjft said in Last Played Collection - Possible to limit?:

Hi all.

Just a note for those of you who moved to the development branch because of this. I seem to have run into an unrelated issue in that branch whereby the metadata of the games you play, if you're saving it on exit, may write incorrect paths for video and Marquee.

Yeah even though I was the one that instigated the request for this feature I have decided to be patient and wait for it in the next stable drop. Experience has taught me never to grab latest until its been tested. ;)

pjft

@alturis it's not related to this particular change - though it also won't graduate to the stable branch if it isn't tested by people.

My comment was that there's this specific issue in the development branch for now, unrelated to this, that I ran into and thought I'd let others know.

Alturis

@pjft said in Last Played Collection - Possible to limit?:

it's not related to this particular change

Right. Sorry didn't mean to imply that. Just saying that who knows what other changes are in the latest along with it.

mediamogul

Ha, looks like this bit me in the backside on a few gamelist files. I suppose it's all part of walking the razor's edge of open source advancement. Actually, I've never felt more alive. I might even take up sky diving next, or perhaps record a ball game without the express written consent of Major League Baseball.

Anyone looking to check if any files were affected, look for any gamelist.cfg files that have a modification date past when you updated ES from source and look/search for any image tags starting with:

<image>./ownloaded_images/

and replace that part with

<image>/home/pi/.emulationstation/downloaded_images/

Unfortunately, I don't use videos on my setup, so I don't know exactly how they would have been affected.

pjft

@mediamogul interesting. Do you confirm that those are the exact before and after versions of one such path?

In my case the images stayed well. I was looking through the code and I think I suspect what might be the issue, but I don't know that code well enough to pass a judgement without effectively testing it.

Welcome to the bleeding edge of development:)

mediamogul

@pjft said in Last Played Collection - Possible to limit?:

Do you confirm that those are the exact before and after versions of one such path?

Yes. The image tag for every game that was played after the update was affected in that same way. I corrected them all with a find and replace.

pjft

@mediamogul thank you. Interesting.

What's your ROM path in the gamelist files for one of those ROMs, can you also share it?