• Recent
  • Tags
  • Popular
  • Home
  • Docs
  • Register
  • Login
RetroPie forum home
  • Recent
  • Tags
  • Popular
  • Home
  • Docs
  • Register
  • Login
Please do not post a support request without first reading and following the advice in https://retropie.org.uk/forum/topic/3/read-this-first

Last Played Collection - Possible to limit?

Scheduled Pinned Locked Moved Help and Support
emulationstatiocollectionslastplayed
65 Posts 9 Posters 13.4k Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • P
    pjft
    last edited by 27 Feb 2018, 23:08

    Here you go:

    https://github.com/RetroPie/EmulationStation/pull/383

    If anyone does want to test it out for bugs and such, I'd certainly appreciate a second pair of hands/eyes on it.

    Best.

    M 2 Replies Last reply 28 Feb 2018, 02:15 Reply Quote 4
    • D
      darknior
      last edited by 27 Feb 2018, 23:45

      Thanks a lot, really good idea :)

      Life is game, just play it !

      1 Reply Last reply Reply Quote 0
      • A
        Alturis
        last edited by Alturis 27 Feb 2018, 23:56

        @pjft wouldnt you just expose a new public method of FileData that manipulates the mChildren table to remove X elements from the end?

        Simiar to the sort function itself?

        void FileData::sort(ComparisonFunction& comparator, bool ascending)
        {
        	std::stable_sort(mChildren.begin(), mChildren.end(), comparator);
        
        	for(auto it = mChildren.cbegin(); it != mChildren.cend(); it++)
        	{
        		if((*it)->getChildren().size() > 0)
        			(*it)->sort(comparator, ascending);
        	}
        
        	if(!ascending)
        		std::reverse(mChildren.begin(), mChildren.end());
        }
        
        void FileData::remove(  int rmvCount )
        
        

        RP 4.7.1 • Pi4 4Gig • CanaKit Aluminum • 64GB microSD • 1920x1080 BarTop [2 Sanwa sticks]

        A 1 Reply Last reply 28 Feb 2018, 00:39 Reply Quote 1
        • A
          Alturis @Alturis
          last edited by 28 Feb 2018, 00:39

          @alturis said in Last Played Collection - Possible to limit?:

          @pjft wouldnt you just expose a new public method of FileData that manipulates the mChildren table to remove X elements from the end?

          Simiar to the sort function itself?

          Nevermind. Looks like you already took care of this. Missed that. Thank you!

          RP 4.7.1 • Pi4 4Gig • CanaKit Aluminum • 64GB microSD • 1920x1080 BarTop [2 Sanwa sticks]

          1 Reply Last reply Reply Quote 1
          • M
            mediamogul Global Moderator @pjft
            last edited by mediamogul 28 Feb 2018, 02:15

            @pjft

            Holy hannah that was fast! Well done, sir. It seems as though it's about to be accepted too. I look forward to testing it.

            RetroPie v4.5 • RPi3 Model B • 5.1V 2.5A PSU • 16GB SanDisk microSD • 512GB External Drive

            A 1 Reply Last reply 28 Feb 2018, 03:48 Reply Quote 1
            • A
              Alturis @mediamogul
              last edited by 28 Feb 2018, 03:48

              @mediamogul said in Last Played Collection - Possible to limit?:

              It seems as though it's about to be accepted too

              It has been. I imagine if you update from sources it would be there now?

              RP 4.7.1 • Pi4 4Gig • CanaKit Aluminum • 64GB microSD • 1920x1080 BarTop [2 Sanwa sticks]

              M 1 Reply Last reply 28 Feb 2018, 04:41 Reply Quote 0
              • M
                mediamogul Global Moderator @Alturis
                last edited by mediamogul 28 Feb 2018, 04:41

                @alturis said in Last Played Collection - Possible to limit?:

                I imagine if you update from sources it would be there now?

                I updated from source about 45 minutes after the commit went through and still had over 800 games in the list. I'll try it again tomorrow.

                RetroPie v4.5 • RPi3 Model B • 5.1V 2.5A PSU • 16GB SanDisk microSD • 512GB External Drive

                M 1 Reply Last reply 28 Feb 2018, 04:55 Reply Quote 0
                • M
                  mitu Global Moderator @mediamogul
                  last edited by 28 Feb 2018, 04:55

                  @mediamogul Are you using the emulationstation-dev package, because otherwise you'll be updating from the stable branch, whereas the modification has been committed to the master branch.

                  M 1 Reply Last reply 28 Feb 2018, 04:56 Reply Quote 1
                  • M
                    mediamogul Global Moderator @mitu
                    last edited by 28 Feb 2018, 04:56

                    @mitu

                    Ah, good to know. Thanks.

                    RetroPie v4.5 • RPi3 Model B • 5.1V 2.5A PSU • 16GB SanDisk microSD • 512GB External Drive

                    1 Reply Last reply Reply Quote 0
                    • H
                      hiulit
                      last edited by 28 Feb 2018, 08:43

                      Wow, that was quick! Thanks @pjft :D!!

                      My little contributions to the RetroPie project:

                      • Shell-Script-Boilerplate
                      • Fun-Facts-Splashscreens
                      • Limit-Last-Played-Games
                      1 Reply Last reply Reply Quote 0
                      • M
                        mediamogul Global Moderator @pjft
                        last edited by 28 Feb 2018, 15:25

                        @pjft

                        Everything seems to be working well. From a user experience point of view, the list now definitely feels less cumbersome and more manageable. However, your first instinct to include 100 items may have been more appropriate, as 50 bottoms out a lot faster than I would have thought. The best number for this is always going to be subjective, but it'll be interesting to hear a consensus after more people have had a chance to try it. Fantastic work!

                        RetroPie v4.5 • RPi3 Model B • 5.1V 2.5A PSU • 16GB SanDisk microSD • 512GB External Drive

                        P 1 Reply Last reply 28 Feb 2018, 15:28 Reply Quote 1
                        • P
                          pjft @mediamogul
                          last edited by 28 Feb 2018, 15:28

                          @mediamogul thanks for testing. I'd definitely be interested in hearing others' thoughts after a week or so of use, and then we can certainly adjust.

                          I have another fix for ES to keep me busy before lr-fuse, so it'll still be easy to change if needed.

                          Best.

                          C 1 Reply Last reply 28 Feb 2018, 18:03 Reply Quote 0
                          • C
                            cyperghost @pjft
                            last edited by 28 Feb 2018, 18:03

                            @pjft Wow nice add-on
                            I vote for 100 items as default.

                            C 1 Reply Last reply 28 Feb 2018, 22:25 Reply Quote 1
                            • C
                              Clyde @cyperghost
                              last edited by 28 Feb 2018, 22:25

                              I'm amazed what an idea plus some collaboration can accomplice. I love such communities like this one. :)

                              1 Reply Last reply Reply Quote 1
                              • P
                                pjft
                                last edited by 28 Feb 2018, 22:58

                                Hi all.

                                Just a note for those of you who moved to the development branch because of this. I seem to have run into an unrelated issue in that branch whereby the metadata of the games you play, if you're saving it on exit, may write incorrect paths for video and Marquee.

                                Check the games you've played (if any) and see if the metadata on reloading is still ok. I'll try to see if I can fix it (or others as well) soon, but you might be better off with the main branch right now, or at least not saving the metadata. I'd check the metadata for the games you played since updating.

                                Best.

                                A 1 Reply Last reply 28 Feb 2018, 23:18 Reply Quote 0
                                • A
                                  Alturis @pjft
                                  last edited by Alturis 28 Feb 2018, 23:18

                                  @pjft said in Last Played Collection - Possible to limit?:

                                  Hi all.

                                  Just a note for those of you who moved to the development branch because of this. I seem to have run into an unrelated issue in that branch whereby the metadata of the games you play, if you're saving it on exit, may write incorrect paths for video and Marquee.

                                  Yeah even though I was the one that instigated the request for this feature I have decided to be patient and wait for it in the next stable drop. Experience has taught me never to grab latest until its been tested. ;)

                                  RP 4.7.1 • Pi4 4Gig • CanaKit Aluminum • 64GB microSD • 1920x1080 BarTop [2 Sanwa sticks]

                                  P 1 Reply Last reply 28 Feb 2018, 23:41 Reply Quote 0
                                  • P
                                    pjft @Alturis
                                    last edited by 28 Feb 2018, 23:41

                                    @alturis it's not related to this particular change - though it also won't graduate to the stable branch if it isn't tested by people.

                                    My comment was that there's this specific issue in the development branch for now, unrelated to this, that I ran into and thought I'd let others know.

                                    A 1 Reply Last reply 1 Mar 2018, 00:18 Reply Quote 0
                                    • A
                                      Alturis @pjft
                                      last edited by 1 Mar 2018, 00:18

                                      @pjft said in Last Played Collection - Possible to limit?:

                                      it's not related to this particular change

                                      Right. Sorry didn't mean to imply that. Just saying that who knows what other changes are in the latest along with it.

                                      RP 4.7.1 • Pi4 4Gig • CanaKit Aluminum • 64GB microSD • 1920x1080 BarTop [2 Sanwa sticks]

                                      1 Reply Last reply Reply Quote 0
                                      • M
                                        mediamogul Global Moderator
                                        last edited by mediamogul 3 Jan 2018, 03:40 1 Mar 2018, 03:39

                                        Ha, looks like this bit me in the backside on a few gamelist files. I suppose it's all part of walking the razor's edge of open source advancement. Actually, I've never felt more alive. I might even take up sky diving next, or perhaps record a ball game without the express written consent of Major League Baseball.

                                        Anyone looking to check if any files were affected, look for any gamelist.cfg files that have a modification date past when you updated ES from source and look/search for any image tags starting with:

                                        <image>./ownloaded_images/
                                        

                                        and replace that part with

                                        <image>/home/pi/.emulationstation/downloaded_images/
                                        

                                        Unfortunately, I don't use videos on my setup, so I don't know exactly how they would have been affected.

                                        RetroPie v4.5 • RPi3 Model B • 5.1V 2.5A PSU • 16GB SanDisk microSD • 512GB External Drive

                                        1 Reply Last reply Reply Quote 1
                                        • P
                                          pjft
                                          last edited by 1 Mar 2018, 07:03

                                          @mediamogul interesting. Do you confirm that those are the exact before and after versions of one such path?

                                          In my case the images stayed well. I was looking through the code and I think I suspect what might be the issue, but I don't know that code well enough to pass a judgement without effectively testing it.

                                          Welcome to the bleeding edge of development:)

                                          M 1 Reply Last reply 1 Mar 2018, 07:28 Reply Quote 0
                                          53 out of 65
                                          • First post
                                            53/65
                                            Last post

                                          Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                          Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.

                                            This community forum collects and processes your personal information.
                                            consent.not_received