EmulationStation crash when edit metadata from collection

sleve_mcdichael

RPi4, RP 4.8.7 (f6411621), ES-dev 4a064a2 installed from binary.

Go to any collection (*tested All Games and Last Played; I don't have any Favorites or custom collections to test those.)

With any game highlighted, press Select to open Options menu, then choose edit this game's metadata. Change any metadata value (*tested name, sortname, description, developer, toggle kidgame).

Press B to exit Metadata menu. Press A to "save changes." Press B to exit Options menu and return to gamelist view.

(Optional side-quest: press left-right to change systems. Maybe play some games if you want. After switching systems, you can press B to return to system carousel from a page other than the collection where you edited the metadata. Everything seems fine. Return to the collection where you made the change, eg. All Games. If you're at the system carousel, press A to re-enter gamelist view.)

From the collection page where the edit-metadata was performed, press B to return to system carousel; crash occurs reliably at this point. Edits are not saved to gamelist.

Make the same metadata edits from system-menu eg. Arcade or SNES, all works fine.

mitu

Yes, I see this happening, but it's only on the dev branch. Must be something added recently, thanks for reporting.

mitu

Bisected to https://github.com/RetroPie/EmulationStation/commit/45259de2c79e1555c15558139a1b888f2fa48b72, added by @Lolonois.
Not only does it crash when going back to systems' view, when going back the gamelist after editing the metadata it screws up the list of entries in the collection, adding entries from - seemingly - another collection.

I'll see what may cause this, maybe try to find a fix.

Lolonois

Thanks for reporting this. The testing path (metadata edit within collections and navigating to carousel) escaped me back then.

I filed a PR to fix this and tested it to have no regressions when the flag refreshListCursorPos in setCursor() is true.

https://github.com/RetroPie/EmulationStation/pull/878

pjft

@Lolonois Thanks for the prompt response, thanks @mitu for bisecting and @sleve_mcdichael for reporting.

@sleve_mcdichael or @mitu if you could check that this fixes things on your end, I'm happy to merge.

Thanks all, and hope you have a great week!

sleve_mcdichael

@pjft seems good from here, I can edit data from the All Games and Last Played collections, and then return to the carousel view without crashing now.

pjft

@sleve_mcdichael Thanks. This has been merged now.