EmulationStation, folders, and play count

sleve_mcdichael

Pi 4 / EmulationStation-dev 6b4281a

In themes that show playcount, it is displayed incorrectly on folders. It should probably just show zero, or alternatively add up all the play counts of the games within the folder. Instead, it shows the count for whatever game was highlighted prior (depending on if you scroll down from above or up from below).

See: Gran Turismo 2 is a folder (has Arcade mode/simulation modes inside). It shows a play count of 0 when scrolling down from Final Fantasy Tactics, and play count 2 when scrolling up from Harmful Park:

(Animated gif): https://imgur.com/a/PD4Swr1.gif

mitu

What does the gamelist.xml look like for those folders ?

sleve_mcdichael

@mitu

        <folder>
                <path>./Gran Turismo 2 (USA)</path>
                <name>Gran Turismo 2</name>
                <thumbnail />
                <image>/home/pi/.emulationstation/downloaded_media/psx/screenshots/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).png</image>
                <marquee>/home/pi/.emulationstation/downloaded_media/psx/marquees/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).png</marquee>
                <texture />
                <video>/home/pi/.emulationstation/downloaded_media/psx/videos/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).mp4</video>
                <rating>0.8</rating>
                <desc>Gran Turismo 2 is fundamentally based on the racing game genre. The player must maneuver an automobile to compete against artificially intelligent drivers on various race tracks. The game uses two different modes: arcade and simulation. In the arcade mode, the player can freely choose the courses and vehicles they wish to use. However, the simulation mode requires the player to earn driver's licenses, pay for vehicles, and earn trophies in order to unlock new courses. Gran Turismo 2 features nearly 650 automobiles and 27 racing tracks.</desc>
                <releasedate>19991223T000000</releasedate>
                <developer>Polyphony Digital</developer>
                <publisher>Sony Computer Entertainment</publisher>
                <genre>Race, Driving</genre>
                <players>2</players>
                <kidgame>true</kidgame>
        </folder>

...

        <game>
                <path>./Gran Turismo 2 (USA)/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).chd</path>
                <name>Disc 1: Arcade Mode</name>
                <desc>Gran Turismo 2 is fundamentally based on the racing game genre. The player must maneuver an automobile to compete against artificially intelligent drivers on various race tracks. The game uses two different modes: arcade and simulation. In the arcade mode, the player can freely choose the courses and vehicles they wish to use. However, the simulation mode requires the player to earn driver's licenses, pay for vehicles, and earn trophies in order to unlock new courses. Gran Turismo 2 features nearly 650 automobiles and 27 racing tracks.</desc>
                <image>~/.emulationstation/downloaded_media/psx/screenshots/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).png</image>
                <video>~/.emulationstation/downloaded_media/psx/videos/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).mp4</video>
                <marquee>~/.emulationstation/downloaded_media/psx/marquees/Gran Turismo 2 (USA) (Arcade Mode) (Rev 1).png</marquee>
                <rating>0.8</rating>
                <releasedate>19991223T000000</releasedate>
                <developer>Polyphony Digital</developer>
                <publisher>Sony Computer Entertainment</publisher>
                <genre>Race, Driving</genre>
                <players>2</players>
                <kidgame>true</kidgame>
                <playcount>2</playcount>
                <lastplayed>20241221T114512</lastplayed>
        </game>

...

        <game>
                <path>./Gran Turismo 2 (USA)/Gran Turismo 2 (USA) (Simulation Mode) (Rev 2).chd</path>
                <name>Disc 2: Simulation Mode</name>
                <thumbnail />
                <image>/home/pi/.emulationstation/downloaded_media/psx/screenshots/Gran Turismo 2 (USA) (Simulation Mode) (Rev 2).png</image>
                <marquee>/home/pi/.emulationstation/downloaded_media/psx/marquees/Gran Turismo 2 (USA) (Simulation Mode) (Rev 2).png</marquee>
                <texture />
                <video>/home/pi/.emulationstation/downloaded_media/psx/videos/Gran Turismo 2 (USA) (Simulation Mode) (Rev 2).mp4</video>
                <rating>0.85</rating>
                <desc>Gran Turismo 2 is fundamentally based on the racing game genre. The player must maneuver an automobile to compete against artificially intelligent drivers on various race tracks. The game uses two different modes: arcade and simulation. In the arcade mode, the player can freely choose the courses and vehicles they wish to use. However, the simulation mode requires the player to earn driver's licenses, pay for vehicles, and earn trophies in order to unlock new courses. Gran Turismo 2 features nearly 650 automobiles and 27 racing tracks.</desc>
                <releasedate>19991223T000000</releasedate>
                <developer>Polyphony Digital</developer>
                <publisher>Sony Computer Entertainment</publisher>
                <genre>Race, Driving</genre>
                <players>2</players>
                <kidgame>true</kidgame>
        </game>

mitu

I've looked at the code and both last played and play count are specifically not computed if the gamelist entry not a game. In general, metadata on folders is not the same as metadata on games, though the differences are not so easyly visible or exposed to the theme definition.
You can either add your own values or try this branch of EmulationStation to see if it fixes the issue.

sleve_mcdichael

You can either add your own values

<playcount>42</playcount>

This didn't seem to work...still shows play count of previously-selected item when coming from above or below (or page up/down).

or try this branch of EmulationStation to see if it fixes the issue.

rp_module_repo="git https://github.com/cmitu/EmulationStation metadata-fix"

This...sort of did? Play count showed empty, nothing at all, until I switched to "detailed" view style to take a screenshot -- then it reverts to the old behavior, show whatever was last-selected above or below. "Automatic" and "video" (and "basic") view styles both show correct (empty) play count. Only "detailed" seems to show it still wrong (I can't do much with grid view on my Pi4 but the themes I tried don't seem to support it well anyway.)

mitu

@sleve_mcdichael said in EmulationStation, folders, and play count:

This didn't seem to work..

Yes, that couldn't work - I realized after posting.

...

This...sort of did? [...]

Ok, I guess there are a couple other places that need modifying. I'll take a look at it later, thanks for testing.

mitu

I have modified the listing for the other view types in the same branch, so you can test by re-fetching it, but I wonder if it's not better to just remove the elements from view altogether since this metadata type is not supported on folders.

sleve_mcdichael

I have modified the listing for the other view types in the same branch, so you can test by re-fetching it,

Yes this shows (correctly) nothing when on "detailed" view style now also: