Video Preview in EmulationStation

Nismo

@fieldofcows I have some questions...

Are you planning to include music for eachsystem in system view? if yes, maybe whould be a good idea to add option for disable background music in sound settings.
In my theme i have to respect some image box sizes to be a little more realistic, but some images are a bit small, for example zxspectrum cassette or dreamcast cd. ( I don't want to do a casstette bigger than a zx spectrum or half a tv).
I'ts possible to add a preview image mode by pressing (or pressing and hold) Y button (for example) inside video view to preview zoomed image in screen?

Something like this:

<view name="video">

        <imagepreview>
		<origin>0 0</origin>
		<pos>0.5 0.5</pos>
		<maxSize>0.5 0.5</maxSize>
	</imagepreview>
		
</view>

And the result when you press Y button:

image preview

What do you think? i think this request whould be hard to do, but dreaming it's free.

Regards.

fieldofcows

@Nismo said in Video Preview in EmulationStation:

@fieldofcows maybe you can test this because you are the only one at this moment that has a Rpi build of beta 6.

I can confirm that your latest theme does not exhibit the white screen of death problem on my Rpi 3 with default configuration :) The theme looks beautiful and works perfectly.

@Rion I'm sure the WSOD problem can be solved. I've already got some ideas. If @Nismo's theme had WSOD'd I would be fixing it now...

Nismo

@fieldofcows Nice to read that. I suppose you talking about 720p version.
In that version i keep in mind that no one background or system art has more than 225kb, so seems that it's working for now.

fieldofcows

@Nismo Yes, I've only tried the 720p version on the pi so far. I'll try the 1080p version and get back to you.

Nismo

@fieldofcows I'm sure 1080p version will have the white screen bug, so don't try if you don't want it.

720p version it's good enough for an Rpi.

Nismo

@fieldofcows I've found a little issue, if i manually scrape a game inside ES, it deletes my video and marquees tags in gamelist.xml.

fieldofcows

@Nismo said in Video Preview in EmulationStation:

if i manually scrape a game inside ES, it deletes my video and marquees tags in gamelist.xml

I've added this as an issue in GitHub. https://github.com/fieldofcows/EmulationStation/issues/13

Nismo

@fieldofcows new system coming...

Game boy:

Do you like it?

fieldofcows

@Nismo Haha! Yes! Do you ever stop?

Nismo

@fieldofcows said in Video Preview in EmulationStation:

Do you ever stop?

Not for now... he he. Keep the ball rolling...

fieldofcows

@Nismo said in Video Preview in EmulationStation:

Not for now... he he. Keep the ball rolling...

My thoughts exactly. I'm enjoying working on ES and am quite keen to implement some of the big features that people are after along with some of my own. This thread is not the time or place and supporting your theme is my priority at the moment but it would be nice if some of the changes we are working on gain momentum and get pulled into general use.

Nismo

@fieldofcows yes, i'm with you, you did a few fixes apart from theming. When are you planning to lauch the Rpi build?

fieldofcows

@Nismo I built it last night and was just in the process of setting up a fresh image on and SD card to test it and write up some instructions when I noticed how late it was so I went to bed :) It's not far away...

I'm not sure the best or proper way to distribute this ES version. Should I just publish a binary as a release in GitHub that is compatible with a retropie image like I have done for Windows or should I provide build instructions? Anyone?

Nismo

@fieldofcows I think it's more easy for noobs a binary release instead of needing to compile...

When more people can test it more easy to find bugs and solve... i whould like as stable version as possible.

But let people say their opinion.

Zigurana

@fieldofcows
There is also the possibility of setting up a module in the retropie expermental settings, which would allow users to install the latest version from github, by cloning into it and building it on their pi's. All automated, just takes an hour or so. See this for an example.
This way, you do not need to keep building binaries for the pi, and people always get the latest and greatest. (Although it's nice to be able to fall back on older versions as well, esp for more experimental branches).

Nismo

Thi is definitively better, almost for Rpi users.

cyrax3

@Nismo said in Video Preview in EmulationStation:

Thi is definitively better, almost for Rpi users.

not only for rpi user but also for a noob windows users like me...i'm not able to compile a sotware and a "downloadable .exe" is the best thing. you are the only ones who have progressed to this fronted (windows version)

herb_fargus

@Zigurana what would really be ideal is if we stopped creating multiple forks and focused on integrating singular features that can be tested to be included in the retropie fork- lots of people have had great ideas and made some great improvements between you with kids mode, jacobfk20 with gridview and this one with video support, along with a few other features on the way. Jools has been amicable to accepting good tested code and perhaps it would be good to start submitting some clean pull requests for testing and inclusion.

fieldofcows

@herb_fargus said in Video Preview in EmulationStation:

what would really be ideal is if we stopped creating multiple forks and focused on integrating singular features that can be tested to be included in the retropie fork

I don't see any harm in creating forks so long as the purpose isn't to compete with the forked repository but instead to provide a space to collaborate on major feature development. I am reliant on others to make suggestions, test, provide themes, etc. in order to make the video feature work so forking the repository provides me with a useful tool to achieve that. Once we have got to a stage where the code is tested and stable I fully intend to submit this back to the retropie fork.

Zigurana

I agree with the sentiment that forks are fine for the experimental testing stage, for instance: I had the child-friendly stable for about 9 months, only to have it blow up in my face because of a use case I had not anticipated. At that point I was glad I had not yet taken the time to polish it down into a PR which, if accepted, would have impacted many more people.

But I agree with you both, delivering back to the Retropie branch should be the end goal. Its reassuring to see Buzz come around to that point of view.