Video Preview in EmulationStation
-
@Nismo said in Video Preview in EmulationStation:
@fieldofcows maybe you can test this because you are the only one at this moment that has a Rpi build of beta 6.
I can confirm that your latest theme does not exhibit the white screen of death problem on my Rpi 3 with default configuration :) The theme looks beautiful and works perfectly.
@Rion I'm sure the WSOD problem can be solved. I've already got some ideas. If @Nismo's theme had WSOD'd I would be fixing it now...
-
@fieldofcows Nice to read that. I suppose you talking about 720p version.
In that version i keep in mind that no one background or system art has more than 225kb, so seems that it's working for now. -
@Nismo Yes, I've only tried the 720p version on the pi so far. I'll try the 1080p version and get back to you.
-
@fieldofcows I'm sure 1080p version will have the white screen bug, so don't try if you don't want it.
720p version it's good enough for an Rpi.
-
@fieldofcows I've found a little issue, if i manually scrape a game inside ES, it deletes my video and marquees tags in gamelist.xml.
-
@Nismo said in Video Preview in EmulationStation:
if i manually scrape a game inside ES, it deletes my video and marquees tags in gamelist.xml
I've added this as an issue in GitHub. https://github.com/fieldofcows/EmulationStation/issues/13
-
-
@Nismo Haha! Yes! Do you ever stop?
-
@fieldofcows said in Video Preview in EmulationStation:
Do you ever stop?
Not for now... he he. Keep the ball rolling...
-
@Nismo said in Video Preview in EmulationStation:
Not for now... he he. Keep the ball rolling...
My thoughts exactly. I'm enjoying working on ES and am quite keen to implement some of the big features that people are after along with some of my own. This thread is not the time or place and supporting your theme is my priority at the moment but it would be nice if some of the changes we are working on gain momentum and get pulled into general use.
-
@fieldofcows yes, i'm with you, you did a few fixes apart from theming. When are you planning to lauch the Rpi build?
-
@Nismo I built it last night and was just in the process of setting up a fresh image on and SD card to test it and write up some instructions when I noticed how late it was so I went to bed :) It's not far away...
I'm not sure the best or proper way to distribute this ES version. Should I just publish a binary as a release in GitHub that is compatible with a retropie image like I have done for Windows or should I provide build instructions? Anyone?
-
@fieldofcows I think it's more easy for noobs a binary release instead of needing to compile...
When more people can test it more easy to find bugs and solve... i whould like as stable version as possible.
But let people say their opinion.
-
@fieldofcows
There is also the possibility of setting up a module in the retropie expermental settings, which would allow users to install the latest version from github, by cloning into it and building it on their pi's. All automated, just takes an hour or so. See this for an example.
This way, you do not need to keep building binaries for the pi, and people always get the latest and greatest. (Although it's nice to be able to fall back on older versions as well, esp for more experimental branches). -
Thi is definitively better, almost for Rpi users.
-
@Nismo said in Video Preview in EmulationStation:
Thi is definitively better, almost for Rpi users.
not only for rpi user but also for a noob windows users like me...i'm not able to compile a sotware and a "downloadable .exe" is the best thing. you are the only ones who have progressed to this fronted (windows version)
-
@Zigurana what would really be ideal is if we stopped creating multiple forks and focused on integrating singular features that can be tested to be included in the retropie fork- lots of people have had great ideas and made some great improvements between you with kids mode, jacobfk20 with gridview and this one with video support, along with a few other features on the way. Jools has been amicable to accepting good tested code and perhaps it would be good to start submitting some clean pull requests for testing and inclusion.
-
@herb_fargus said in Video Preview in EmulationStation:
what would really be ideal is if we stopped creating multiple forks and focused on integrating singular features that can be tested to be included in the retropie fork
I don't see any harm in creating forks so long as the purpose isn't to compete with the forked repository but instead to provide a space to collaborate on major feature development. I am reliant on others to make suggestions, test, provide themes, etc. in order to make the video feature work so forking the repository provides me with a useful tool to achieve that. Once we have got to a stage where the code is tested and stable I fully intend to submit this back to the retropie fork.
-
I agree with the sentiment that forks are fine for the experimental testing stage, for instance: I had the child-friendly stable for about 9 months, only to have it blow up in my face because of a use case I had not anticipated. At that point I was glad I had not yet taken the time to polish it down into a PR which, if accepted, would have impacted many more people.
But I agree with you both, delivering back to the Retropie branch should be the end goal. Its reassuring to see Buzz come around to that point of view.
-
@fieldofcows yes, I misspoke, thanks for clarifying. Not anything wrong with creating forks as that's what the code is for, but once aloshi left ES has become very fragmented so there are lots of great ideas without a central home or maintainer to combine all the good ideas. Hopefully retropie can be the home for some of them and I agree its good to have a separate fork for testing new features. I appreciate that you're willing to put in the work to help push some of it upstream
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.